From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60B3CC4167B for ; Wed, 6 Dec 2023 16:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DAi/6q7NJq8Ls6oyWwNDab+hareUzsltlYzbzyGYcMU=; b=nuzRNckawdmExsOjDZUM9kywfQ hoPseCY+ME4d8dfYbHs8QzpWCWVYipCpLe+S3Ko8WRcNQKKuXxACH3NlvNzfcc9bJDJY6pfAgJE7+ 4GMPYu0wwNLc0OUU2ChhUGN38s+juCzQmiLvRyq412GwwMH84UJ1hcO0wWDBEaxP64xF/X+74lMEa ZNWiuDZGL21hcQAyMaHJh72rgn/MHHQAZpgl9KhTJaDhmxjGnTPb0rUHvQpMvplN5gARhmi8X2qyb u+P3GPQCkgg0xUjxNI/oUzApnh2bHbB8z4tsCZN54Zxi+xIVTlSk3sbh7eZgur34sEylo39hmYrSb PUsn/fLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAuZg-00AjQM-0y; Wed, 06 Dec 2023 16:16:36 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAuZd-00AjPN-0q for linux-arm-kernel@lists.infradead.org; Wed, 06 Dec 2023 16:16:34 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a1e116f2072so86140466b.0 for ; Wed, 06 Dec 2023 08:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701879389; x=1702484189; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ANhsNm1z1q5r0k4ig7l9fgQ6wnefNabJyB6yrVtO5Dw=; b=Dj6eFP4zZ+apypyeHVCvAJUcq/3DJCmh9rK3xhCfgQLIoAU01BWHdqCsAUx3GuTohu PEF8Kxag9XNJH/g3Aq3dqyiY2O+1wdJGBJNEDzk4xd9F8Ae9BvUZk1yZJ+0jm3yWBh5W Po8g/jeK3B2FfvBfByqKaVlxu2Jt7bKLknfqA+tARrXaVdEJ92g4lRNqZQVRhWEs8HX+ juzVMKlGHOBqsWUjBzEZkBf3QnPRVpPNngc4XYWt2shBH3ODbuwvtf8srUhRN15m6k5O FL1d0o15lBX2WaJZ6gi1J7Y/x/tX5YZbHtFCta7PbUSTRKowsQ1tBYDFTx0j9rUMI3CC fu3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701879389; x=1702484189; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ANhsNm1z1q5r0k4ig7l9fgQ6wnefNabJyB6yrVtO5Dw=; b=TpGKsrbaXdfAto+hFsqDMKhGG2QmM2yR5usKQuu/iXF/B3GarhHIhgejzaQPAkslpg uXH3H51CnQkACVWVM6og8f7x+HVAP5lTp38KhPpyE7ivS0uoAa8/J/hBQwNRJ5RqIYc6 /0+/Tzu0ld/r3iwgM76C8fbK2IvL9Tfoy/tIOY9lwq+aHajiWljGI/sCCJmoCF0/bsmT ejypYBTBK61cDsG4C57Y/qYbSnr5/oi0YnAxeUj9/ebNq6NDeIO10c+r5YHkeK8pwAQe tUGWP73XHYKNLwqtgKMGvfmS2kb5HDXJwUpXycys9dGbq0RXQCWXnHZeY61AbmMzT4P9 jQPw== X-Gm-Message-State: AOJu0Yy96m2Sgu82EnZ02mep2BsQlgzT+WInIp1UoXE4yROL4+zsVl8f IQ1IOOSRsVbXj9s1Q1ULhqc= X-Google-Smtp-Source: AGHT+IFy8x5NdSw4gMUVcSn6gTYvfx+5ZcFZaDpA+FIzL/xuDBuyQYdp284Mn4A9tfEwJ5Vrnr8htQ== X-Received: by 2002:a17:906:185:b0:a1d:d900:271b with SMTP id 5-20020a170906018500b00a1dd900271bmr958745ejb.2.1701879388726; Wed, 06 Dec 2023 08:16:28 -0800 (PST) Received: from orome.fritz.box (p200300e41f0fa600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f0f:a600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id s14-20020a170906454e00b00a1ce98016besm108989ejq.224.2023.12.06.08.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 08:16:28 -0800 (PST) Date: Wed, 6 Dec 2023 17:16:26 +0100 From: Thierry Reding To: Krzysztof Kozlowski Cc: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman , Jiri Slaby , Wim Van Sebroeck , Guenter Roeck , linux-fsd@tesla.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 2/6] dt-bindings: pwm: samsung: add specific compatible for Tesla FSD Message-ID: References: <20231205092229.19135-1-krzysztof.kozlowski@linaro.org> <20231205092229.19135-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 In-Reply-To: <20231205092229.19135-3-krzysztof.kozlowski@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_081633_298497_83F76838 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2723541312054894316==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2723541312054894316== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CFJ6EccMqQxL/2Mm" Content-Disposition: inline --CFJ6EccMqQxL/2Mm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 05, 2023 at 10:22:25AM +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. >=20 > Add Tesla FSD compatible specific to be used with an existing fallback. >=20 > Signed-off-by: Krzysztof Kozlowski >=20 > --- >=20 > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 + > 1 file changed, 1 insertion(+) You point to the guidelines that say we should have specific compatible strings, but then the string that you add seems very generic. Now, I'm obviously not an expert on Tesla hardware, but just FSD seems to be quite generic according to the internet. It seems like the chip derived =66rom Samsung used to be known as AP3/HW3, but there's now also AP4/HW4, so I wonder if those differ in some way and if these shouldn't include some sort of version/generation number. Thierry --CFJ6EccMqQxL/2Mm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmVwnlkACgkQ3SOs138+ s6HNNxAAr18wT2Xx7P6HZfEgxKUQPSCBFlyEXUDvbkHuvzp6EQKPzf/qxwtlsnFk nrFGQTrZn7i6PREWY3t2J9yOd4OjSUvwbkuSJnivXzZla7r0+H1u4iFD8cOWT1JH RdzvcGTRIO6NVCyYH1uq8zszeWkMftGYP65u15WlMFoNhbvDshpTRHpTtBH+GKzw uOvHeU+XGckCiuWLTlw5G3X1B/ApmiGb7faNwlIEOWcHtDSfq+z0ypjAA509NKkJ UqcrFJbn28pcuPPzudHQBDhw8h6azTRS7cYdaAI9XrU5+kg0dSthoWXWUHnxCluq 888aZXm1xsCwMAy09y1GLOraEBTuy+qtDKr4hqydKJ5fs2jJEVseX9X2vQpL4Tvm 4rS68YgmsbAtt9rvGeKgh9qoP+uk9jlzv5TqF4/p8ou4WPjLCm/tY8tnGYDhU23p 4kSXpyHYJ2FJQjaCpHMVpRJhQ86lO0HuBecJU5l+/meu/iWk6wRvJMOQ00/+5PpR tjRwy3Wey7HTT7o9FUwrP7zvWbyIzyhANX6tKCEBHfTQvH0o3Iawa959Ip9lzkrV sB3j6nS8OiPWn4TjogGQHIjvm86H1r8hMPNQQGV26iLXxmbarWylBsJviqkGHPyP UpsvXImtnoR0/WG2qYO/VbbzK1k3PU6PWhJ0CJuPhrYnaISX5Uc= =yEhC -----END PGP SIGNATURE----- --CFJ6EccMqQxL/2Mm-- --===============2723541312054894316== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2723541312054894316==--