From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10ECAC4167B for ; Thu, 7 Dec 2023 13:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fk05OLW9xuZv+u4hRY5lDnypECMMTNnsOdI5/yR2FoY=; b=gnhE3+LLne2Uao Y1fhhUNiOgVqabm/skSiPS+9yWaSfLebfr0x/zrzKr3kdESXup0zkprQyiuMdfvGaTHEZcu4OQWRq gylGxfBo4GL3lRb0yZuSKaWVosZgG2FNgHMEnlK1/MvOqX4UUBLAnWLHl9HHBpTRKgtAqcSH1CyGZ Sr+jHmH96olz/5XCXnRxpTBIxBLZq8/qKVvbfq0Uz7f2d9e20izpAuOJbX8WZGWheiZSw2nlp8xO0 7SV3QFSObI1cgf2A94vTYbPPqCyGeSEJj6vc2wBBpxm20c09ayh7Y9ld0V1zJ7PgkvKX+v23Y3B1Q bXq8f5j5swPJzGAjVGcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBEn5-00Cwnb-0F; Thu, 07 Dec 2023 13:51:47 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBEn2-00Cwmr-1S for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 13:51:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7697BCE239E; Thu, 7 Dec 2023 13:51:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2E23C433C7; Thu, 7 Dec 2023 13:51:38 +0000 (UTC) Date: Thu, 7 Dec 2023 13:51:36 +0000 From: Catalin Marinas To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, broonie@kernel.org, dave.hansen@linux.intel.com, maz@kernel.org, oliver.upton@linux.dev, shuah@kernel.org, will@kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v3 05/25] arm64: context switch POR_EL0 register Message-ID: References: <20231124163510.1835740-1-joey.gouly@arm.com> <20231124163510.1835740-6-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231124163510.1835740-6-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_055144_664491_35874B43 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 24, 2023 at 04:34:50PM +0000, Joey Gouly wrote: > @@ -498,6 +508,17 @@ static void erratum_1418040_new_exec(void) > preempt_enable(); > } > > +static void permission_overlay_switch(struct task_struct *next) > +{ > + if (system_supports_poe()) { > + current->thread.por_el0 = read_sysreg_s(SYS_POR_EL0); > + if (current->thread.por_el0 != next->thread.por_el0) { > + write_sysreg_s(next->thread.por_el0, SYS_POR_EL0); > + isb(); > + } > + } Nitpick: use "if (!system_supports_poe()) return;" to avoid too much indentation. W.r.t. the isb(), I think we accumulated quite a lot on this path. It might be worth going through them and having one at the end, where possible. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel