From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 353ABC4167B for ; Fri, 8 Dec 2023 12:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vBLZKFLnb8ouqrNjcc9KBwddvbzJEwydP72xdBccyD0=; b=1bkwd+iLsetUkV 9dnzIg/ZbRM46dA+QfOUQYLefEAmC+g5TZLbJblkgZ1d1408nX49IwlNSEbRaQwR33pfGFXuEWOEa hhkR6pUmL7qY5lYBg6VLZttJ6Yp7tIyTgDAfPqSbhsbfHUPIOEExI6YY2B9MonKWNIQ6BZQws7grb Eq6toR/xCM6F3a3VWyGOjNtwkFlIJuEdvRtPPqB3eH6Ipr+vY06dX2Ua0+SCghmhE1cLOnEwtwv9C wuOqSEFoQrhx3/z29h41043cixYOTXO2cGE9x0zvs7IGzzeTpBx3oow3qi0cRFps3n4EQp762uWhb /hKYdlie5JShYcePR3wA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBa6f-00FcBp-2y; Fri, 08 Dec 2023 12:37:25 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBa6c-00FcB7-1v for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 12:37:23 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a00cbb83c80so232898966b.0 for ; Fri, 08 Dec 2023 04:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702039038; x=1702643838; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WPQ6igrFJgaAkCCJ/PrY9rvOQPcIfSLQwy5XAAYTFZ4=; b=ghPETLAiwtc3WW2wgtFhW33gAIqosVx72BrRkcTsqXDM2gXbHPqyyfcCqB+upAl66B SAxdZinkIUrgzAzoI7TRHnd2ZqQMDU7186/duL4gusxjTyTpeax7Iyzhg66rZQTndC6G w2AnVDavh6rS9NoxigyBNvcD4ZugqPh+pBg1TKGsBgVZWVA1KEFG79hueEJSBMd1BKT0 oO2k/vtr5xVOqx/RQd3MlR9BARmU3HkLLdgSCZRvgyyaSGGNdm4DsSFeBxjsgtZW0+Gq 8Mc0G/l82YvF4rzu8bVN8UkjgGLAsBhMrKEmp5qLVQGkrS3wK7WzAWGXtkdsDA613/lZ artw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702039038; x=1702643838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WPQ6igrFJgaAkCCJ/PrY9rvOQPcIfSLQwy5XAAYTFZ4=; b=gnx4IRSXYos7mxb7q/HJWC/RIrLHXveHgYE5HPGpEOgpjGNtccn1C1pNl8f0bTuXvv p5JeuzWQDqgQa01p+GUmkD+Ql1sDjQCFw9dTfAPhFm4eL+cpsn9Fo5cykEgWy82GcjgM W9YGAN7OVpb1fQM4XOc99ACePUAv9okxCCqmlFh14puX35RDBmnyTLsDm7hVPuc3Haw2 0CTTVzMvVbEsvcm9lMKUqgqAsFC4gte2OISpqsM85R37iiRs9ZO1egjfnvfrf5src+mh +7kn/6M+pPgm8GGAd4jNDJX95eWI8fhLAHjpfoZhhirjf4tNTBK4hlGoEVmhuIT3crqC NdUw== X-Gm-Message-State: AOJu0YzcHgP8yhJp+U8UMuuckczo3p68ML2Cccg1drkXisyFI5gM+C9a BeCsspKDn5krT0OUV2CypZM= X-Google-Smtp-Source: AGHT+IFifdS6Qk1seBmfoJXsGQi4ktaHsgxpPEGE814Znqh9/iODFHgV0KfjFcbZ42XhVpjwJN7Btw== X-Received: by 2002:a17:906:718:b0:a18:35e2:de31 with SMTP id y24-20020a170906071800b00a1835e2de31mr1973793ejb.63.1702039037564; Fri, 08 Dec 2023 04:37:17 -0800 (PST) Received: from eichest-laptop ([2a02:168:af72:0:905b:7c28:f9e2:a6aa]) by smtp.gmail.com with ESMTPSA id jl26-20020a17090775da00b00a1d20467a90sm957286ejc.214.2023.12.08.04.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 04:37:13 -0800 (PST) Date: Fri, 8 Dec 2023 13:37:08 +0100 From: Stefan Eichenberger To: Krzysztof Kozlowski Subject: Re: [PATCH v1 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-in-suspend property Message-ID: References: <20231207111300.80581-1-eichest@gmail.com> <20231207111300.80581-2-eichest@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_043722_653721_F51755D5 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, nick@shmanahar.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, dmitry.torokhov@gmail.com, claudiu.beznea@tuxon.dev, Stefan Eichenberger , robh+dt@kernel.org, alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Thu, Dec 07, 2023 at 05:59:08PM +0100, Krzysztof Kozlowski wrote: > On 07/12/2023 12:12, Stefan Eichenberger wrote: > > diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > index c40799355ed7..047a5101341c 100644 > > --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > @@ -87,6 +87,12 @@ properties: > > - 2 # ATMEL_MXT_WAKEUP_GPIO > > default: 0 > > > > + atmel,poweroff-in-suspend: > > + description: | > > + When this property is set, all supplies are turned off when the system is > > + going to suspend. > > You described the desired Linux feature or behavior, not the actual > hardware. The bindings are about the latter, so instead you need to > rephrase the property and its description to match actual hardware > capabilities/features/configuration etc. Thanks a lot for the feedback. Would the following be okay as a description? vdda and vdd are switched off in suspend mode. Best regards, Stefan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel