From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 040D5C10F05 for ; Mon, 11 Dec 2023 15:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=75MCKKVarcGugsrthOI/NbKT1kDePIDF+XQ3XjVInQI=; b=M6se7se2dl2ccNKrWigyBSPbSk 2GgYIeLmz+y4RIwWZJhbIb3uR5ktsH3UMumL5osscTK+h8prlde/w/PNfSwysx0qap6iIcR/Fm9qo eIfIfSFllO/m/cCDcjBUyRcvjEFWvj64w3Kq3VcyeQbotrH/tD/kjWfTZwKAxeKcbUaeTjigcEUtp 5KOJ5DKUHIIO9Wvk5z2GACKgZK0H6WUYvZAZu60DHaVL2HyMcm/yqpXOj3oj2Sfcpuw88eg6dyTJE ZcUbTyqbwRSW7SH9jUrz8kMnHNk0tCdv1DyR0alwtsnvPIOl7HMgXqXfPgMn1MGwY9JDxMQVj2PYS SZ36zv+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCiEr-005RUH-2r; Mon, 11 Dec 2023 15:30:33 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCh6D-0059Ow-0P; Mon, 11 Dec 2023 14:17:40 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a1ef2f5ed02so480550166b.1; Mon, 11 Dec 2023 06:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702304251; x=1702909051; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xjgDoH5wpFTvBtjku8JEMjQ8hKrrQC8Hfkdc8NZQjks=; b=eVbvYFGbf3NAuylOMiPhiTQJV5lP9EyYnBHYAsdy97Lher/6qQMWmmidewTE/vLiXe pu9kc6mvGy7IKmALz/dzYQ6xXoQW9cihD4HSR6WFJq9MXhQZKGKiQuxT3C+DHUK5y45x 0lKcBg37XJ6P54YbuEfg7xk0ed3hfn6X3zD3e0Vg95OQHxqIlz5vvu+0XDdnFn4cFF3z +mD6hRsM8r7GcF6bIL8OBcHMroxh3DKA/fU0I3CP+Vyygdq8/JvxQOc9OXU0UMlJVJYA 1xK9B9KkoAwRiVmmzsXTMbW+I52VLO/0oMYLJwW/WTaOFpGFzrWMuuoR0SkhfqxVHnXM WNaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702304251; x=1702909051; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xjgDoH5wpFTvBtjku8JEMjQ8hKrrQC8Hfkdc8NZQjks=; b=fgHGfeBRP5PgyaxkiS6TS9ClDfo5jGDDqE0ssNWLylDHAdaz2DmTfJPNaqlLpKBmpK EaYLoJTgbJRtzIU9ylPYpLKQET/YkR8UeJpjRhArHUM51lCRHjBc8peAY1QvCO595vFG P2aQwWRe1bSRXk10pdzIbnTn0/Alc2aHHN6/LaOW7gyNWqtISkW77Lhlk3ip8oKpwNfD HPM8rb+8D6IJK9ES9ZT55w7gscA0Rg9x/zxpJK4R4w7RIyo7I3DB9fgT+jxeUPwiI5k1 w0Dm05PP3OPLyW8sh7R9mCD156GiCw3OyUysYNlvR8pAjJIsMgPiKSeyeegkDYw/SMhh Vomg== X-Gm-Message-State: AOJu0YyWBax97bDbI73uTyVMywKVmgBsb4A7nNo+HPsKzbVtvCcmvDyc 04dD7vN1jiGxwtYeDC2I8Lc= X-Google-Smtp-Source: AGHT+IGvtRp1DsOkZJ5XmsG/dnogTspAPXgW486VHcUzxU/sxVwTq6S7cWTfJRA7TFXSMcwnZYFJ4w== X-Received: by 2002:a17:906:512:b0:a19:a1ba:8cb6 with SMTP id j18-20020a170906051200b00a19a1ba8cb6mr2088159eja.84.1702304250718; Mon, 11 Dec 2023 06:17:30 -0800 (PST) Received: from orome.fritz.box (p200300e41f0fa600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f0f:a600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id vc11-20020a170907d08b00b00a1ce58e9fc7sm4849982ejc.64.2023.12.11.06.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 06:17:30 -0800 (PST) Date: Mon, 11 Dec 2023 15:17:28 +0100 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Sean Young , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/4] pwm: bcm2835: allow pwm driver to be used in atomic context Message-ID: References: <179dc1ce85702a8b64b43c0e0df656b0c5e3ce30.1701248996.git.sean@mess.org> <20231208172040.mgw7aicmwlw6yjyb@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20231208172040.mgw7aicmwlw6yjyb@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_061733_165097_72D3BE7B X-CRM114-Status: GOOD ( 26.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3004279992006083586==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3004279992006083586== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gN2yPszgClY7v+2k" Content-Disposition: inline --gN2yPszgClY7v+2k Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 08, 2023 at 06:20:40PM +0100, Uwe Kleine-K=C3=B6nig wrote: > On Fri, Dec 08, 2023 at 05:01:26PM +0000, Sean Young wrote: > > On Fri, Dec 08, 2023 at 05:22:52PM +0100, Thierry Reding wrote: > > > On Wed, Nov 29, 2023 at 09:13:36AM +0000, Sean Young wrote: > > > > clk_get_rate() may do a mutex lock. Fetch the clock rate once, and = prevent > > > > rate changes using clk_rate_exclusive_get(). > > > >=20 > > > > Signed-off-by: Sean Young > > > > --- > > > > drivers/pwm/pwm-bcm2835.c | 31 +++++++++++++++++++++---------- > > > > 1 file changed, 21 insertions(+), 10 deletions(-) > > >=20 > > > s/pwm/PWM/ in the subject. Although, I guess you could just drop the > > > "PWM" altogether because the subject prefix implies that this is for > > > PWM. > >=20 > > $ git log --no-merges --oneline drivers/pwm/ | sed -r 's/^\w* ([^:]+): = =2E*/\1/' | sort | uniq -c > > 1197 pwm > > 1 PWM > > ... > >=20 > > The vast majority of the commits use pwm: as a prefix, only one uses PW= M:.=20 > > In fact if you look across the tree almost everywhere lower case is used > > for the prefix. >=20 > Thierry doesn't want you to change the subject prefix, but only the > second "pwm" to make it read: >=20 > pwm: bcm2835: allow PWM driver to be used in atomic context >=20 > While I understand Thierry here, I'm fine with a lowercase pwm here, > too. In my book a PWM in all uppercase is the type of hardware and pwm > in all lowercase is the framework's name. If you use "PWM driver" or > "pwm driver" then doesn't matter much. I'm not fine with a lowercase "pwm" in what is clearly text. Text should be grammatically correct and PWM being an abbreviation it should be all caps. The framework name is also PWM, not pwm. We use the lowercase pwm as prefix because it represents the directory where the subsystem lives and we usually don't use capitalization in file and directory names. Thierry --gN2yPszgClY7v+2k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmV3GfgACgkQ3SOs138+ s6G4gQ/+JdOurEDhll7cImaJ6eu6WXI6EmxsPcFtvXqydrGyPaoLvSaw1eKq9cYU QUWpM6rdBZW3kQTlx+6766tmW5GMa4hK9LZiRUpH5wQfJrq+TMTyp+sOqq2pIw9C voiT2ShRE8Z5uYu4lRr+mp08Ws9RcL44wvIYOLXm6V+xNe4IS5kup9N3ObX+HvK6 OIlbZKPgCLt4zmlDyYDOy0A5v7uAmaaejjx1jeVmBeDc9pIspK7CrNBZSmKS5jVY SNJydpNNmoDcGmkPhkTjzB3nyolXuo/UyqdaDGfd7YkCO7sIBhYoxIcXxyF7/6mQ 1lPy5QM0WxhAjeU2ScfKoHXoPH9YATPYj2Mf2ZQp8ltchmmXnZGLX64WfPcgp8f2 bJs19PfF24c52n5HvdHkVMVM0loWpbNp+ozY0o/wcKDna6UksuLNkEf2PJ8bS9gD vUoBH/uTVRFXtl7QXSRk1Vnbn20dwPoORFmLdBSGQI44K7hcEaUkQtS3/t5PXpBW bIOkYwMB5jyARmUgbnFld2wT/6t5FV7hNseEyRHszZc1CFn1gSiPz9j4TRkCAoE8 CvlZ5QG/6BzU1haNEplHPn9wfsYKOdJ3k/GNfgYAEfWpB7Pi1gkgameq57TuUxSA B+Z7nhZCd3hWoNF+oRlqe1e0zH7CuTRIgQ3yBxjX9nNjeclKo5c= =FV2f -----END PGP SIGNATURE----- --gN2yPszgClY7v+2k-- --===============3004279992006083586== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3004279992006083586==--