From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A3DC4332F for ; Fri, 15 Dec 2023 16:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gFqohU2jNk1yBmJo9krwazxK/W5LRmH80CihZtrDK3o=; b=rB+UzHhRSRa8Gb lsXDlPBo3wAsDjCSyB9myGMkxFBKyYfQXUMt7ZH+AMn7NDrtwaINDg3L7A/uxAbysJ0qwKiv9u/hh X58xCAOQZIAFYAzYCW5HyEmrzshgiqxSo+DJN/2R7V2g4LqsJMnE1q/cisWfbzdmgcX2ptXjtfF00 pn6KtNu+y6Ja5d0pU8CQcG0pPoxja4AO0OcZ0nklTRsUcw3eSRM6MKt/KvhSeMNNVzpoWOgQeav8L 9oL3qDhNOMp0rB3u2J7Ekji9F9ihA2T3wo3O7EIQqx9ZVkkAxjiPxKowEW8XA+hrTfc/YmCUDxepP NqF+EVPGuirsESygfAAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEB77-003sbK-2W; Fri, 15 Dec 2023 16:32:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEB73-003sZZ-3C; Fri, 15 Dec 2023 16:32:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 59655626B9; Fri, 15 Dec 2023 16:32:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECD69C433C8; Fri, 15 Dec 2023 16:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702657953; bh=5xSZ6gC57XpMcrBYmJ5djtgBGtNosockr7ypfWQ/UoA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u23WidcobeXI8hJTBO02gH39xAVyMZg3S/gk8R3+oMsy1a46PrrJRqER62yDtrdtf 1sP9G3jW6bt0TkUH+FVWaUXb2WUMuoifq5UkKLSL9Vihbw/4tLEgQtVy3f2vCcs/Dv wXTrDDgayoevbU8NQT5CXG0gCcWFBHIOSHMEoJhbkn1WLbj/H/Eu2Fuq4FA4d679tr 0edO8rQox64QgmVeY5DX9u/1v/sBmf4kwA7Zaxt4jUW2eY9C5xbVFoGtvPd+mKK3Eo sfxBmvoKrJU1x51n4fbHg8VooER+eL425YDkyzu8lDJ1d7HJ/0OT8IaPHRNo28jX8y dWVhTFyyt4wKA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rEB6x-0000ZV-31; Fri, 15 Dec 2023 17:32:28 +0100 Date: Fri, 15 Dec 2023 17:32:27 +0100 From: Johan Hovold To: Francesco Dolcini Cc: Greg Kroah-Hartman , Jiri Slaby , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, greybus-dev@lists.linaro.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, chrome-platform@lists.linux.dev, platform-driver-x86@vger.kernel.org, linux-serial@vger.kernel.org, linux-sound@vger.kernel.org, Francesco Dolcini , Luiz Augusto von Dentz , Alex Elder , Jonathan Cameron , Lee Jones , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "David S. Miller" , Krzysztof Kozlowski , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Benson Leung , Tzung-Bi Shih , Rob Herring Subject: Re: [PATCH v1] treewide, serdev: change receive_buf() return type to size_t Message-ID: References: <20231214170146.641783-1-francesco@dolcini.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_083234_117143_73283E55 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 15, 2023 at 02:59:35PM +0100, Francesco Dolcini wrote: > On Fri, Dec 15, 2023 at 02:51:09PM +0100, Johan Hovold wrote: > > On Thu, Dec 14, 2023 at 06:01:46PM +0100, Francesco Dolcini wrote: > > > From: Francesco Dolcini > > > > > > receive_buf() is called from ttyport_receive_buf() that expects values > > > ">= 0" from serdev_controller_receive_buf(), change its return type from > > > ssize_t to size_t. > > > drivers/bluetooth/btmtkuart.c | 4 ++-- > > > drivers/bluetooth/btnxpuart.c | 4 ++-- > > > -static ssize_t btnxpuart_receive_buf(struct serdev_device *serdev, > > > - const u8 *data, size_t count) > > > +static size_t btnxpuart_receive_buf(struct serdev_device *serdev, > > > + const u8 *data, size_t count) > > > { > > > struct btnxpuart_dev *nxpdev = serdev_device_get_drvdata(serdev); > > > > A quick check of just the first two functions here shows that they can > > return negative values. > > This is already fixed. Patches are in next. > > There were 3 buggy user of this API. > - 1 patch was merged a few days ago in mainline > - 2 patches are in next, the maintainer decided to wait for the next merge window > > commit 687d2de93b11 ("Bluetooth: btmtkuart: fix recv_buf() return value") > commit 7954bbcdd7ea ("Bluetooth: btnxpuart: fix recv_buf() return value") > commit c8820c92caf0 ("platform/surface: aggregator: fix recv_buf() return value") Then why was that not mentioned in the patch (e.g. below the --- line)? You are certainly not making it easy for reviewers, but good to see that you thought about this, and I see now when reviewing the mail archives that those bugs were the reason for this patch in the first place. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel