From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB8CAC35274 for ; Fri, 15 Dec 2023 22:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hoJ0YXDNlYhiYdk4v9m0lYNYGZc0zVFQon6nhvd0epE=; b=EIfJDP2a6CXTTB aR/3CABQxZkaPD8ins+yKDzV5Popgjf+vSFHrHWTXg8RIlnkHq2ziTwOuXwKNKDYFbkpHsFnVecgZ t7alWAoyO62SNff9T5PnB16tR84/+zJxTCFnsDvpXOyqUz7sm2L/9JWe9hkEAOmnBLtpoyJ+6loLe yJvLKzRZaLAySjXaFmt2JsHNR6FSA4dIjv9hXcbjx0Vi1EyynzxZkl1zicoBHCeBnxnzjJB5XCOM/ zse4nP+pQ60fYh6Pe5U9mOPho8jW0lIXoCE5bn9PAKfXj51+kJ77kVbZmPgWOb6lkkMCS7n49A2BR 5OBhSNLjCLVwDn/RTFPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEGaA-004klZ-2E; Fri, 15 Dec 2023 22:22:58 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEGa7-004kl2-0y for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 22:22:56 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-77f35009e78so75954385a.1 for ; Fri, 15 Dec 2023 14:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hefring-com.20230601.gappssmtp.com; s=20230601; t=1702678973; x=1703283773; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7TFw7xg7w2M+8qc28EqEusL4T4Plz+lf2upO0JPQgw0=; b=rPjmfD3eoScivckZc5Z50Yit2Iy/9KkEP1SewD7OnPZE5Ucm0nuh79FIA8CyF0Avwv wDY0tGM+yQ+Ey7jRVXL7tkxeucQf45aGFyAo9urLL2KFjhCk6Me0jHL9ROL5M6oo1ORf IdN5sA2CTN1M+vHIA7zclz+6V7pFgSq3b1wiOu85xXiWjaZdPhvpp5f8c5FJz03xfNWE s4j/FbCRwmeGqj76gIokNnyBBRaTGOpVXcKYHWrpdiW2AMQVjnqljl3/QijTsaxdWHWH ltDun5BfFFX2MOq5xHnrrStV8F7Po3g1xvIJs5rce/hr2Rh45HvpbrAIa+YXwpEPO6yO vlqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702678973; x=1703283773; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7TFw7xg7w2M+8qc28EqEusL4T4Plz+lf2upO0JPQgw0=; b=OUggd1JvF0UZNtQLIJE0WxcD1mYB3XiXPFiginJVgn7ksWEp/6bLxEYk3c+28OcphX ZYx8LgunOG2c43VhwTa2EUferSp71P5Z5c0/UvoK36R+TvgENMzDuBoUp7dJrRHfMCHi 62czv4lO9DKFDk/32GjLnm2f0JMAQkQ81W2rcntDhAoLloaYxMlcR5YPG5M5kuRqRnYQ BkAJNy19HdIIYK3+v27dOtuJxIUF6+J4BxBk/R06wkG4WbKQdaXi4rtP70tVkRScuwHT HH4R/fKlRmWEiikn2gabdV2x1Zk9wauuCMH5mMyr4MYcAXCiJGekVQD6c/Li1un7ZVxs PeWQ== X-Gm-Message-State: AOJu0YyNmgeY7zCnQi5TNY+qvqmbPw4iAeqmAqQ0D785EIpOg/6o7mLO 0GWP6qIz+L1j9uTCMAtSVQYDxg== X-Google-Smtp-Source: AGHT+IEJekFwo4r+H8PtOrZH0hYzvRpj9POtATtBQr7tyBiNEDTS/FAF2UzeUfuDf/WaBoIwrOUJ3A== X-Received: by 2002:a05:620a:146d:b0:77f:878:b58 with SMTP id j13-20020a05620a146d00b0077f08780b58mr14261801qkl.153.1702678973632; Fri, 15 Dec 2023 14:22:53 -0800 (PST) Received: from dell-precision-5540 ([50.212.55.89]) by smtp.gmail.com with ESMTPSA id m1-20020ae9e701000000b007759a81d88esm6333130qka.50.2023.12.15.14.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 14:22:53 -0800 (PST) Date: Fri, 15 Dec 2023 17:22:03 -0500 From: Ben Wolsieffer To: Mark Brown , linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue Subject: Re: [PATCH] spi: stm32: use runtime PM to enable/disable controller Message-ID: References: <20231204202055.2895125-1-ben.wolsieffer@hefring.com> <58897511-3187-4583-bf29-11871dd4d136@sirena.org.uk> <20231215182739.GA96945@gnbcxd0016.gnb.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231215182739.GA96945@gnbcxd0016.gnb.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_142255_552930_671EF246 X-CRM114-Status: GOOD ( 24.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 15, 2023 at 07:27:39PM +0100, Alain Volmat wrote: > Hi, > > sorry for the delay. > > On Thu, Dec 14, 2023 at 10:58:54AM +0000, Mark Brown wrote: > > On Mon, Dec 04, 2023 at 03:20:55PM -0500, Ben Wolsieffer wrote: > > > Instead of disabling the SPI controller between each message, do it > > > as part of runtime PM. > > > > This doesn't apply against current code, please check and resend. > > I rapidly gave a try on this patch on top of the spi/for-next branch > (manually fixing the conflict due to the MASTER->HOST renaming). > It turns out that with that applied, transfers on the MP13 > (compatible: st,stm32h7-spi) are not working anymore while simply > removing it back it works again. > (test is simply doing loopback spidev_test) That's unfortunate; I was worried about something like this because I only have an STM32F7 to test. If you can't easily determine what's going wrong, it would be interesting to know if the original version of this patch has the same problem: https://lore.kernel.org/lkml/ZWpoKEcM0ZeYAsBa@dell-precision-5540/T/ > > spi mode: 0x0 > bits per word: 8 > max speed: 500000 Hz (500 kHz) > TX | 8D D6 73 8B 9D 8B 1C 7D 8D 80 EC 32 F9 0D BA AD 9F 88 A5 9B 3F AA 48 8C 21 35 0D C1 C8 E5 6A 81 |..s....}...2........?.H.!5....j.| > RX | 8D 00 00 00 D6 00 73 00 8B 00 00 00 9D 00 00 8B 1C 00 00 00 7D 00 00 8D F9 00 00 00 BA 00 00 00 |......s.............}...........| > > The RX data contains lots of 00 between each byte. Moreover it seems > that with this patch applied non-dma transfer (when there is no dmas > properties within the node) are now failing. > > I'll check that and give more details but could you avoid applying this > patch for the time being ? > > Thanks. > Alain _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel