From: Wolfram Sang <wsa@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/1] i2c: lpi2c: use clk notifier for rate changes
Date: Tue, 19 Dec 2023 17:56:15 +0100 [thread overview]
Message-ID: <ZYHLL8fiLKJNEJ+8@shikoro> (raw)
In-Reply-To: <2912069.e9J7NaK4W3@steina-w>
[-- Attachment #1.1: Type: text/plain, Size: 915 bytes --]
Hi,
> > ... improve the commit message, reporting the real deadlock case
> > instead of a lockdep warning and...
>
> I've improved the commit message about an actual deadlock.
That means a v8 is in your queue?
> > ... find a more appropriate error number, I will ack this patch.
>
> Thinking about this again, I think EINVAL is an appropriate error code.
> The parent clock frequency is also an input for the i2c transfer. So if, for
> whatever reason, that clock frequency is 0, it is an invalid value (argument).
> I've checked other drivers what they do if that clock is 0. Unfortunately most
> don't consider this case at all. But some do, so e.g. i2c_lpc2k_probe() or
> dc_i2c_init_hw() both return EINVAL if the clk or a calculated divider is 0.
IMHO, the return value doesn't matter that much as we have a descriptive
text accompanying it anyhow.
Happy hacking,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-12-19 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 14:12 [PATCH v7 1/1] i2c: lpi2c: use clk notifier for rate changes Alexander Stein
2023-11-07 21:20 ` Andi Shyti
2023-11-08 6:46 ` Alexander Stein
2023-11-08 9:15 ` Andi Shyti
2023-11-08 9:18 ` Wolfram Sang
2023-11-08 10:26 ` Andi Shyti
2023-11-08 23:38 ` Andi Shyti
2023-11-09 7:54 ` Alexander Stein
2023-11-09 9:10 ` Andi Shyti
2023-11-10 12:27 ` Andi Shyti
2023-11-14 12:27 ` Alexander Stein
2023-12-19 16:56 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYHLL8fiLKJNEJ+8@shikoro \
--to=wsa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexander.sverdlin@siemens.com \
--cc=andi.shyti@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox