From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71035C46CD2 for ; Sun, 24 Dec 2023 08:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hgpGUSyalijqOjhi9Xv7rqQy2djWhsYtA+p7uoh5g+8=; b=zfc9uu+jQn/5mP ZO4lClAT6rGT170ovUSXpa28FFz42knDLdyzbbwAp6jy580aYmUNIlV2M9MWcJ7LrqnRCAUiC5tCE 1nyfY8bLv/IIxsgOiopVmGE//Lzcnmf5vu2/nzbFEnPR+432kf+/Uw5eV3NtFlHxpfG+VUI/mqNE1 D7zbFXXOXlN2Vu8r+EXFWJzSh075rGBqH/4TkgmAe6AOEgwCJcyuo/p1uZU+HJvqsMROkshSO7UY4 rDqp5xZQEHnklfk8Hyo70Bq9AfvZrDTL91Sy7yn8vIeMmoWaRC/UGkhxbptFd9H0xbTZnEtu8Opju 9NJjIFGruClgwHGKL6RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHK8i-0093pg-07; Sun, 24 Dec 2023 08:47:16 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHK8f-0093pK-1z for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2023 08:47:14 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-35fe994dab5so6933995ab.0 for ; Sun, 24 Dec 2023 00:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703407632; x=1704012432; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z+TdUy7n0bW8MoAnemDGn/iTVbgzWkn9TsPCN0MQJmM=; b=cRQxsv97poEfV5LR+jLdCj2VBbYYg15vg5AMDyykAogPuysTXIHXO4HhZZSjDPOqTm eRNfSrfBXwiPZv8TS7e3yOK2UilmmNo39YKMeauSD75wr+sGVw9RfEk4FSXBIxvJHx7R yqWGktpKbP+0Lh8eNjLRBOpLc4OQAWm59GNMe+OyESTXgva5GAwWXc/v+vRq9Y5rY7Q1 8n4WN1IyN7l/M6gqroNYeOFqe3lzRIQASsQk7/WGowq6SFq7Mlpq6jP6wXRgXgxEtGT0 V2wEBbK03U4JgrlayqvHCsddXWhngQE9uCLl6HKjqLoWV13KArWVQ3btklezfZTEcM3L JIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703407632; x=1704012432; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z+TdUy7n0bW8MoAnemDGn/iTVbgzWkn9TsPCN0MQJmM=; b=ou3/GuIPQ2NU8ovnm5RacQ6ICDahhOUOGNi6P/HwQ9ycuZrQ8/CYEmsl8zP/TROK1A 05HaSGdVTc5IaJ+4jsQ3egX2NB0hJjxsKB8m8//ukn5djGg6xvLgg5Y7ChMduRsw/hNs WDzLBh9lCWhkuF5ZEby5qvRGd218KzkdandwekAkc5UO+uI7m8ndSTg8zEHyrCkQM7tM mp9tQmA9z1jsQsajlLyQyO9jvKsRcUKbhQet88OJUaoNZmtzDNcg+cws2F83QrbfUaL7 rtkc8Ua98FhYS+zEk8cfFkgzWudqUCX+kLGFtLs/0aF6puFomzm1BC/uTPzzJlj52vPm fvFQ== X-Gm-Message-State: AOJu0Yz2NkBUv/6hKeoKVkpRmER3X1JSHtFxU7nwryi/kY9fuUDTGEWE iP6U8a1iA5frRieHU6oml+c= X-Google-Smtp-Source: AGHT+IEfyabAxIPyqID6z4uLc/cDFZmYixgKiJUf3SeAKqiHZfaGcAN6FVP1MeKJoZBzGkrD20Atow== X-Received: by 2002:a05:6e02:15c1:b0:35f:c73b:7ff7 with SMTP id q1-20020a056e0215c100b0035fc73b7ff7mr8010250ilu.59.1703407632141; Sun, 24 Dec 2023 00:47:12 -0800 (PST) Received: from google.com ([2620:15c:9d:2:765c:936e:ea43:6046]) by smtp.gmail.com with ESMTPSA id h6-20020a17090a2ec600b0028afdb88d08sm10020003pjs.23.2023.12.24.00.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 00:47:11 -0800 (PST) Date: Sun, 24 Dec 2023 00:47:08 -0800 From: Dmitry Torokhov To: Andreas Kemnade Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, rydberg@bitmath.org, linus.walleij@linaro.org, Jonathan.Cameron@huawei.com, u.kleine-koenig@pengutronix.de, heiko@sntech.de, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] ARM: dts: imx6sl-tolino-shine2hd: fix touchscreen rotation Message-ID: References: <20231223221213.774868-1-andreas@kemnade.info> <20231223221213.774868-5-andreas@kemnade.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231223221213.774868-5-andreas@kemnade.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231224_004713_697432_243DB45F X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 23, 2023 at 11:12:13PM +0100, Andreas Kemnade wrote: > The display is in landscape orientation, but the touchscreen is in portrait > orientation. Specify that properly in the devicetree. This needs to be merged by the board maintainer. > > Signed-off-by: Andreas Kemnade > --- > arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > index 815119c12bd48..5636fb3661e8a 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > @@ -141,8 +141,10 @@ zforce: touchscreen@50 { > interrupts = <6 IRQ_TYPE_EDGE_FALLING>; Could you please prepare a patch changing this to IRQ_TYPE_LEVEL_LOW to match what the driver is actually doing? > vdd-supply = <&ldo1_reg>; > reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > - x-size = <1072>; > - y-size = <1448>; > + touchscreen-size-x = <1072>; > + touchscreen-size-y = <1448>; > + touchscreen-swapped-x-y; > + touchscreen-inverted-x; > }; > > /* TODO: TPS65185 PMIC for E Ink at 0x68 */ > -- > 2.39.2 > Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel