From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27485C3DA6E for ; Mon, 25 Dec 2023 09:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xutMK9gksLMon7Pitfulws0uPexqkfOwVTSTWRGKnnw=; b=wuVqohuPbyVItS Syszj5sYF74WSrc+fvGkkz4vTDyPPiywlByNTH72GSoKaYWqDgwDrNJe7IQdIzej9KmfOST47ILA4 +B8hGhS59XXbIEhsIn1GxKKZ4if4fRiOMEHujE5eDsDNB8W0zdzwine4d7nLpYK+rvj1pTo/QLHbK i4Y8q/n1u2ezOIqcms8VXArXi6/vrutDv4v5JlUcEJo3tJr8/hAuq3SoW/GXXXM0hyaSvD72O5UCD 2Fs6y37mEd6beiC+Pso6M9PY33c8qE7T7R8jj3Fi2PFL9MZSlcP5jykq031/aM43cujpOxGWsqron /yP4FZgsD3gPjBz8QD4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHhdC-00AUla-2F; Mon, 25 Dec 2023 09:52:18 +0000 Received: from out28-82.mail.aliyun.com ([115.124.28.82]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHhd9-00AUkF-2d for linux-arm-kernel@lists.infradead.org; Mon, 25 Dec 2023 09:52:17 +0000 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07447141|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.157524-0.0058014-0.836675;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047187;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---.VsS8aFT_1703497925; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VsS8aFT_1703497925) by smtp.aliyun-inc.com; Mon, 25 Dec 2023 17:52:06 +0800 Date: Mon, 25 Dec 2023 17:52:05 +0800 From: fuyao To: Andre Przywara Cc: fuyao , Lee Jones , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , maijianzhang Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number Message-ID: Mail-Followup-To: Andre Przywara , fuyao , Lee Jones , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , maijianzhang References: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> Organization: work_work_work X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231225_015216_015778_C69CEAC9 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 20, 2023 at 11:54:12AM +0000, Andre Przywara wrote: > On Wed, 20 Dec 2023 15:23:17 +0800 > fuyao wrote: > > Hi, > > > __platform_get_irq_byname determinies whether the interrupt > > number is 0 and returns EINVAL. > > can you please say what this fixes, exactly? Is something not working at > the moment? Can you please provide parts of the error message? > With open MFD_SUN4I_GPADC and SUN4I_GPADC, It happens: [ 0.185068] ------------[ cut here ]------------ [ 0.185093] WARNING: CPU: 3 PID: 1 at drivers/base/platform.c:451 __platform_get_irq_byname+0xb8/0xc4 [ 0.185131] 0 is an invalid IRQ number [ 0.185140] Modules linked in: [ 0.185160] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 6.7.0-rc6 #9 [ 0.185179] Hardware name: Allwinner sun8i Family [ 0.185203] unwind_backtrace from show_stack+0x10/0x14 [ 0.185234] show_stack from dump_stack_lvl+0x48/0x54 [ 0.185262] dump_stack_lvl from __warn+0xcc/0x1ac [ 0.185285] __warn from warn_slowpath_fmt+0xb4/0x168 [ 0.185304] warn_slowpath_fmt from __platform_get_irq_byname+0xb8/0xc4 [ 0.185328] __platform_get_irq_byname from platform_get_irq_byname+0x10/0x38 [ 0.185354] platform_get_irq_byname from sun4i_irq_init+0x40/0xdc [ 0.185382] sun4i_irq_init from sun4i_gpadc_probe+0x1cc/0x310 [ 0.185403] sun4i_gpadc_probe from platform_probe+0x98/0xc0 [ 0.185426] platform_probe from really_probe+0x10c/0x374 [ 0.185450] really_probe from __driver_probe_device+0x90/0x188 [ 0.185473] __driver_probe_device from driver_probe_device+0x3c/0x198 [ 0.185496] driver_probe_device from __driver_attach+0x118/0x1b4 [ 0.185518] __driver_attach from bus_for_each_dev+0x104/0x148 [ 0.185540] bus_for_each_dev from bus_add_driver+0x164/0x25c [ 0.185560] bus_add_driver from driver_register+0x70/0x118 [ 0.185582] driver_register from do_one_initcall+0xcc/0x29c [ 0.185605] do_one_initcall from do_initcall_level+0x80/0x8c [ 0.185630] do_initcall_level from do_initcalls+0x50/0x80 [ 0.185653] do_initcalls from kernel_init_freeable+0xb0/0xfc [ 0.185675] kernel_init_freeable from kernel_init+0x14/0x1b4 [ 0.185698] kernel_init from ret_from_fork+0x14/0x28 [ 0.185720] Exception stack(0xf0825fb0 to 0xf0825ff8) [ 0.185737] 5fa0: 00000000 00000000 00000000 00000000 [ 0.185756] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.185775] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 0.185788] ---[ end trace 0000000000000000 ]--- [ 0.185804] sun4i-gpadc-iio sun6i-a31-gpadc-iio.0: error -EINVAL: IRQ FIFO_DATA_PENDING not found [ 0.185828] sun4i-gpadc-iio: probe of sun6i-a31-gpadc-iio.0 failed with error -22 The gpadc-iio can not request irq. > And maybe expand the explanation a bit more? For instance mention that the > identifiers are used as IRQ resource numbers, where 0 is treated specially. > thanks > Cheers, > Andre > > > > > Signed-off-by: fuyao > > Acked-by: Jernej Skrabec > > --- > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > index ea0ccf33a459..021f820f9d52 100644 > > --- a/include/linux/mfd/sun4i-gpadc.h > > +++ b/include/linux/mfd/sun4i-gpadc.h > > @@ -81,8 +81,8 @@ > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > #define SUN4I_GPADC_DATA 0x24 > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > /* 10s delay before suspending the IP */ > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > -- CYG Technology. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel