From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AA72C4707B for ; Thu, 11 Jan 2024 09:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XMoRypXghYEO5zyOJI3Jej1EdhoRxAGhZzGj9/9sgjs=; b=1CuXuCSnEZkJZb Zh00eRSimaFRozab2Alj5qJYnoR31eyADUyTyjIbxIrXaI2Te/tdLgo5lnmEpLg6IG7N+h6C3piRm D5D9OxXcw+t98m+nDuHfA6rNGkmpnFRr3hGY8bWKVvoR5Vhng9BWFgJVNUec3cV/GJeOpziqv7+jr WAy+v5PHaqVKFfHAU4nW+N4aylLhzrGM+Z/mAVDeYr8eXk59f3LzeP/ckHCOYzdiQzDpzWzgfcGCs ywOnROA9G+QQKw7Y6I6XWO0LVqDXyfYkSd4NOjY1hqWMu7dRY6HLqKh4B+IoUUSiu+l76c6MlKgGS Rtnj4BLQPitxEnmT9BDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNrmO-00Gre2-00; Thu, 11 Jan 2024 09:55:16 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNrmK-00GrcH-1Z for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2024 09:55:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EgiHrGWYBA6aL4HOR5JD3n9X8Y9twX1PfVqPn+eiAKA=; b=IpU5IN+B34WDy0CdImrjCB5WZe OHDlJQaJKmKSVHc2w2Nh09yX4A+VhlZ9fwiWHxwOcL1G0tF3VMReE0HxmMDgNZpHTAojewAc2A/Sk XNYSABtgl+5qpYwKsAHCN2OsOgA4OQ2/fwFMiktkuoFJUmItKYSKmHQw/eq9J/2DvkJH56s6Uh9ka HxF2fqLpJOsUMyFWEByfyhCExC/8evs5UiBE3ipBoP0s9M91B0YguVS30aGydIXhZPgYFqOp0svMI 3u2sryub2gSy2g5+betsApN85KWVayl+YMFRJb3hZtJ5M/ECsNey1MOBCke7lVpdn0ORhrXWPWkap fS5FdDjg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47350) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNrm2-0006Li-2J; Thu, 11 Jan 2024 09:54:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rNrm2-0006Fz-K2; Thu, 11 Jan 2024 09:54:54 +0000 Date: Thu, 11 Jan 2024 09:54:54 +0000 From: "Russell King (Oracle)" To: "Gan, Yi Fang" Cc: Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Looi, Hong Aun" , "Voon, Weifeng" , "Song, Yoong Siang" , "Choong, Yong Liang" Subject: Re: [PATCH net v3 1/1] net: phylink: Add module_exit() Message-ID: References: <20240104101255.3056090-1-yi.fang.gan@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_015512_815090_65ECDCFF X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 11, 2024 at 06:38:58AM +0000, Gan, Yi Fang wrote: > Hi Andrew, > > Regarding the justification on why it is safe to remove phylink, > we had done some memory leak check when unloading the phylink module. > > root@localhost:~# lsmod | grep "phylink" > phylink 73728 0 > root@localhost:~# rmmod phylink > root@localhost:~# echo scan > /sys/kernel/debug/kmemleak > root@localhost:~# cat /sys/kernel/debug/kmemleak > root@localhost:~# > > So far, we didn't observe any memory leaking happened when unloading > phylink module. Is it sufficient or do you have any other suggestions to check > on whether the module is safe to remove? I have no idea why one would think that memory leaks are in some way related to whether a module can be removed or not. To me at least they are two separate issues. I'll continue waiting for the justification... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel