From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69085C46CD2 for ; Tue, 9 Jan 2024 18:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jfZwCZOiJdePagpYkuhUtvsrzoqkjpd1QBcUPfHzirE=; b=fdYANIJM8xXP5+ cQ6TR2htRYIOQgQmB0jhKL0okoqrXOxFQrlGDkkjvyox9galGPVZvbUu6pveyF1ENlefjlWLkc28b uJVz1GrNN0WwqM/2aUNblRe78WULwJCkDPgRlT2v3A9yMxfpBLbBfgaLQ7NhvMpZVqnwZvpjVOqL/ BhU3GYwky6jS3GVo4ChableC0fsbBVQE4jAJdtVh7bEvscO1mabl6PcSXed/Y7Tm3qW7fdS8dZclE DYQ8OU0GZePCW1dTVqmViTc5lucgj4r0QawF2Kmx+ZI+3zP/J0DvKsV1TJouPc2m1gwdRj1PNH2sC rrzogH52a1Pe6aM0peuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNGgx-0097oo-1H; Tue, 09 Jan 2024 18:19:11 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNGgu-0097nf-0U for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 18:19:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704824346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KzzgvE0gIC11hFErVwmkGJExGtvPilC4PjYEKFATcqE=; b=F04YMkBzQGthM3Q1K/ToluUaYU77gTnBcMOWZ7Pm7Bds56aMLA2Z6VqFirAXapeGMmAFeY OUpjm1LMMN1b4x/WaXToLgnnOIxPZKfht0DGN4whUvyq0HNeRZD/C8lRtcCSEws6QiGa0b 99t2C8L36weLnBvXF9j9I3zsLtka1Ng= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-9DpylTEENsu3DHjMprXNnA-1; Tue, 09 Jan 2024 13:18:36 -0500 X-MC-Unique: 9DpylTEENsu3DHjMprXNnA-1 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-1d45ddf3f58so31292635ad.1 for ; Tue, 09 Jan 2024 10:18:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704824315; x=1705429115; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KzzgvE0gIC11hFErVwmkGJExGtvPilC4PjYEKFATcqE=; b=X5Ivqs5Sx6iD5SpbyNgGJz7veMZolDtwQBCpVRlbKRvzlo+dO1N8/TXiswmNuPmOQG wJVSD2+WQ1OJdlKT1ARloQ8riDgWf3gRdNakUMwqZlbctBc/OG/t30eVL1Nen2jlaLfR 5TMcZBQAW0xylPT/CdekHK1XVUkm2w1PoMGFTg2ctrwdGGB/32rK6JGNJSnBV3gghAMo fyL1Mvd85yBShuAwrHrG73KsfkiZjdWk+dhGoT+2sl6WxswUGEx5yGIt7k2awOhgzba6 2WDQAFLLtZ9FMLCGJQShbRg5aGxqiVbr4KBNXGpCrD70ymXXfYSllNpt5TT8yttmaS6M kGVw== X-Gm-Message-State: AOJu0YyXJkN2Th5bFW1g/g0qIQ2uhOifvOD3OwnNoRkmCkvUSvsNQbuD Yp7E3IaPjkA93xdKPFEg9KnRfeRC2gkj5eMu0qLJM91Fa1KVyh5XUHol1+9OCGxk862+aqO2AN2 aKyboMpoCiWSBdyrXGewA9Yn5R0pZHrrZnkFO4vGq9YM= X-Received: by 2002:a17:903:228f:b0:1d5:6cd7:6d41 with SMTP id b15-20020a170903228f00b001d56cd76d41mr115964plh.86.1704824315316; Tue, 09 Jan 2024 10:18:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYBvNo74Agm9CQkIKURXpO44BHS1rks1II+1CfrivxQ/3t8wFldRXmijXd1pjefSzIYwyH3g== X-Received: by 2002:a17:903:228f:b0:1d5:6cd7:6d41 with SMTP id b15-20020a170903228f00b001d56cd76d41mr115943plh.86.1704824314978; Tue, 09 Jan 2024 10:18:34 -0800 (PST) Received: from LeoBras.redhat.com ([2804:1b3:a803:26a5:3f32:e12b:5335:3c2d]) by smtp.gmail.com with ESMTPSA id iy4-20020a170903130400b001d3eaab64a3sm2086232plb.219.2024.01.09.10.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 10:18:34 -0800 (PST) From: Leonardo Bras To: Arnd Bergmann Cc: Leonardo Bras , Catalin Marinas , Will Deacon , "Eric W. Biederman" , Kees Cook , Oleg Nesterov , Mark Brown , Mark Rutland , Steven Rostedt , Guo Hui , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] arm64: remove unnecessary ifdefs around is_compat_task() Date: Tue, 9 Jan 2024 15:18:28 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: <2f2e8df4-d8bb-4eff-8e70-0ac38736bd74@app.fastmail.com> References: <20240108174330.472996-2-leobras@redhat.com> <2f2e8df4-d8bb-4eff-8e70-0ac38736bd74@app.fastmail.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_101908_279224_51E5B8CF X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 09, 2024 at 07:18:46AM +0100, Arnd Bergmann wrote: > On Mon, Jan 8, 2024, at 18:43, Leonardo Bras wrote: > > Currently some parts of the codebase will test for CONFIG_COMPAT before > > testing is_compat_task(). > > > > is_compat_task() is a inlined function only present on CONFIG_COMPAT. > > On the other hand, for !CONFIG_COMPAT, we have in linux/compat.h: > > > > #define is_compat_task() (0) > > > > Since we have this define available in every usage of is_compat_task() for > > !CONFIG_COMPAT, it's unnecessary to keep the ifdefs, since the compiler is > > smart enough to optimize-out those snippets on CONFIG_COMPAT=n > > > > This requires some regset code as well as a few other defines to be made > > available on !CONFIG_COMPAT, so some symbols can get resolved before > > getting optimized-out. > > > > Signed-off-by: Leonardo Bras > > --- > > Changes since v1: > > - Move some regset code and other defines outside of CONFIG_COMPAT > > - Closes: > > https://lore.kernel.org/oe-kbuild-all/202401061219.Y2LD7LTx-lkp@intel.com/ > > Link: > > https://lore.kernel.org/all/20240105041458.126602-3-leobras@redhat.com/ > > Looks good to me, and did not cause any regressions in an overnight > randconfig build loop. > > Reviewed-by: Arnd Bergmann > Thanks! Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel