linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer
       [not found] <20240108181610.2697017-1-leitao@debian.org>
@ 2024-01-08 18:16 ` Breno Leitao
  2024-01-08 19:21   ` Andrew Lunn
  0 siblings, 1 reply; 3+ messages in thread
From: Breno Leitao @ 2024-01-08 18:16 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, Alexander Couzens, Daniel Golle,
	Andrew Lunn, Heiner Kallweit, Russell King, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: netdev, open list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
 }
 EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
 
+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
 MODULE_LICENSE("GPL");
-- 
2.39.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer
  2024-01-08 18:16 ` [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
@ 2024-01-08 19:21   ` Andrew Lunn
  2024-01-10 11:48     ` Breno Leitao
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2024-01-08 19:21 UTC (permalink / raw)
  To: Breno Leitao
  Cc: davem, edumazet, kuba, pabeni, Alexander Couzens, Daniel Golle,
	Heiner Kallweit, Russell King, Matthias Brugger,
	AngeloGioacchino Del Regno, netdev,
	open list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support

On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.

Does pcs-lynx.c also have this issue? It can be built at a module.

     Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer
  2024-01-08 19:21   ` Andrew Lunn
@ 2024-01-10 11:48     ` Breno Leitao
  0 siblings, 0 replies; 3+ messages in thread
From: Breno Leitao @ 2024-01-10 11:48 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: davem, edumazet, kuba, pabeni, Alexander Couzens, Daniel Golle,
	Heiner Kallweit, Russell King, Matthias Brugger,
	AngeloGioacchino Del Regno, netdev,
	open list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support,
	moderated list:ARM/Mediatek SoC support

On Mon, Jan 08, 2024 at 08:21:03PM +0100, Andrew Lunn wrote:
> On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
> 
> Does pcs-lynx.c also have this issue? It can be built at a module.

Absolutely. I can see the warning in pcs-lynx and pcs-pts.

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs_xpcs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs-lynx.o


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-10 11:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20240108181610.2697017-1-leitao@debian.org>
2024-01-08 18:16 ` [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
2024-01-08 19:21   ` Andrew Lunn
2024-01-10 11:48     ` Breno Leitao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).