From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A920C46CD2 for ; Tue, 2 Jan 2024 05:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kkg1nEh8nasS2/MUSb+hYdHpGgRlr9Em/YdBxwlT784=; b=nktH52SNj/06xc E6aDA0Lt4DiC4B76OdMlsa+rL7uNNzgp2mvF23HxpicCwENdVFrwRPlyJevWUyg92QlXypBnJDzwK Nfxgga8mX5DOBQX/YSR2g3X00UOGxciRsM2DpGXhGHXHTwz/eFaqRJop/bPevCpZAuEe8ucn5M3h5 d+HxaGSiCeXmjuWpcFPB8Q2ZlXK5rcRt44wTAoxWol3u4NE6f6TWfdgxQjf9HG3uUNFn8hWmYjV2E UXKk0q/neRnv2oZvJ8CPEckIokHkROEeedOu4JuNM5VroKGyLbNgLswy8c+yWinHsrQ9QBiSXBY9+ Trm7AlBYfYTft2A1pwgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKXTA-0077t7-1f; Tue, 02 Jan 2024 05:37:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKXT7-0077rW-0l for linux-arm-kernel@lists.infradead.org; Tue, 02 Jan 2024 05:37:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=Odj7rz48zp0HHWF24KJK3cwlgQo/J4wkGft2blXKh0bPgU+Am7N0j6QZgAGM+iELbDMA3R cbnACgNgxhvOTt8EaPVRigYeyE72G14ntjNv3lOBY+8/EXG38cBgTjTVUW9r7LGVgjr+Cf 8c0y4/+nBWKoaRo9KePvQmvUvj3/Fm8= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-RC_xA5nVNlGjp8VG6lR9MA-1; Tue, 02 Jan 2024 00:37:32 -0500 X-MC-Unique: RC_xA5nVNlGjp8VG6lR9MA-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-28bea0ff98cso2090992a91.0 for ; Mon, 01 Jan 2024 21:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704173851; x=1704778651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=mSNEJ/FP9uWMTUNF1uQ/CSB8gzPg6V+v2dDvWSy16CsbkjXovBpGTV022AHoKg9x3H mqYchRgOF2pk8n1DCPT88gizXltIq/k+SdeCDOMq1M2X0Nrq7ZrenWun7NC769MKNZ5C D8JY5BM8cIg22o1xK6yPH6IJJ35AaTLnVfguzCkcfi9OYYjq8EIfYudTJzS64/szuhpP UZzz0kTu3Madjb+x882oXWdqiqUk1K5PtjArh95CV+4ettqMbdOaaR8xx9oorH70DtN2 on3uUazoGszabuRmGTpKlyWFxWIvquvjviG2gkpfnD+eY5xze4RAgQANrwH8EfvJSQu1 VEEA== X-Gm-Message-State: AOJu0Yyh1sES75lEBRoPfjFXxYEeUdPwTvoySy2s6UiNsVdV1CJknF9a LuU/tC9sqqpR+2szzpv9I+7gXFUS8Yx7y8JFpQOuIyQgKWcWHz/UFcbRcwnVEHsOG3UiFB3jO2b xnCaZ+Kv02CoqQv0ymNpA9LqxeYAOkrgo97oeA4rXCes= X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590828plg.6.1704173851407; Mon, 01 Jan 2024 21:37:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENzr2M0aJyyZm2vt3XzuVCeWLevZs5IuWsUdjc1ZzU9FWxHr/jzg4D3MMktI1x4ptpcHyFg== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590810plg.6.1704173851161; Mon, 01 Jan 2024 21:37:31 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id v4-20020a17090331c400b001d49c0daf60sm6900347ple.265.2024.01.01.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:37:30 -0800 (PST) Date: Tue, 2 Jan 2024 13:37:14 +0800 From: Peter Xu To: Muchun Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() Message-ID: References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> MIME-Version: 1.0 In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_213737_785912_4AA5393A X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: > > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) > > #endif /* pmd_write */ > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#ifndef pmd_thp_or_huge > > I think it may be the time to rename to pmd_thp_or_hugetlb, > the "huge" is really confusing. thp is not huge? Actually, > it is huge. It is better to make it more specific from now on, like > "hugetlb". The rename will need to touch ARM code, which I wanted to avoid, see: arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) So far this series only touches generic code. Would you mind I keep this patch as-is, and leave renaming to later? > > BTW, please cc me via the new email (muchun.song@linux.dev) next edition. Sure. Thanks for taking a look. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel