From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4382CC3DA6E for ; Wed, 3 Jan 2024 11:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q4qk0PMuR9yFMCYxO/PTzt9ibVyK43PSdzy8KARU2oo=; b=IiDN/k2mU3kVyh Pzwa4plr/HYZDxTn7a0U4gV7bFQDWLmtl84c2WisYihyHUGcshnWrnupfsdyVX30idbRTL67YWZ5t fPIh08AHCFmRSTzZO0UqsXVLzZ1g6Y+LBpJehjXj/4NGQ+HHICNolFNI5BxUUNPwJjAOr5/wBwy6j TkOimg+1wAe7Pi2tWWMa0Iz6/Cuc8BN1Gn3uI9NvXvHqF+St58XYxmcu46NOWcEJju4dAJ0B5u1Bd 3ik7ggQH17NtBqxfpymxCa/x6Ah5CyqDMthly98a/YkNTby6cCa7xL850RHq6L96ycJN6OmaaWQtC oWrQBb2TSOXGgqSSo0zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKzIN-00AV3A-1H; Wed, 03 Jan 2024 11:20:23 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKzIK-00AV2J-1C; Wed, 03 Jan 2024 11:20:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qP4o6WoadvxoWxPxLI1uV5qkWBeO6DZ9IGfpq4QrUwM=; b=1LwAzpg5o164Q7dDM9h0kCLQRX ZhFvB8bNZsY3zVtUr7dvjrBjTSqUhd8wZ4s7pqfkeibfWzX3VFLCnCO8Ec4qwC66yYOro862n8TFs TDL87PYZmwdXOdrqCcOSkCUVkD4UQf2xQ7/zZDbdOejlH6DwOg52wqHAJc7CPzqYMtbeTKFgQocgu 8Ocad2nSaAHjGXrShQiez8wRD3wGLAnEIZbayKMcr10ayRC47M29rxd8VJ4Qe+APZmx6jFAtAkFSH mXFCi3bwVL1PxZvInDR8mwawQy2e4u+143EjF2aEQef1ElZX4W0d9MZQmzxO77hFOq8IyAh+LDXH3 YrfzIrEw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46830) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rKzI6-0007NQ-0R; Wed, 03 Jan 2024 11:20:06 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rKzI6-0006Ji-05; Wed, 03 Jan 2024 11:20:06 +0000 Date: Wed, 3 Jan 2024 11:20:05 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: Eric Woudstra , Alexander Couzens , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x Message-ID: References: <20240102074408.1049203-1-ericwouds@gmail.com> <92190426-3614-4774-9E9F-18F121622788@gmail.com> <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> <6666EB36-984E-4898-A41A-2D9713DE4DB0@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_032020_408842_46BFB141 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 03, 2024 at 12:10:54AM +0100, Daniel Golle wrote: > On Tue, Jan 02, 2024 at 11:13:58PM +0100, Eric Woudstra wrote: > > I believe the general idea is that phylink should be aware wether to use inband or outband negotiation in order to setup the hardware correctly. Speaking of a situation where there is a PHY attached. > > Well, SGMII speed/duplex AN is not defined for 2500Base-X by any > standard and not supported by the hardware (unlike e.g. RealTek > which came up with their own proprietary extension called HiSGMII). I give up trying to work out whether people are abusing the SGMII term or not. SGMII *IS NOT ANY* BASE-X. SGMII is Cisco SGMII, defined to operate at 10, 100 and 1000M speeds over a single serdes lane operating at 1.25GBaud. 2500Base-X was many proprietary standards (called by many different names like HiSGMII, HS-SGMII, 2500base-X etc) that eventually got IEEE acceptance in one form as 2500base-X. ``PHY_INTERFACE_MODE_2500BASEX`` This defines a variant of 1000BASE-X which is clocked 2.5 times as fast as the 802.3 standard, giving a fixed bit rate of 3.125Gbaud. Note: not "SGMII upclocked by 2.5 times". We do have devices that _do_ use 802.3z (NOT SGMII) negotiation over 2500base-X - not for speed or duplex, but for the pause modes, and we have devices where it is specified that when operating in BASE-X mode, inband AN *must* be enabled - which means upclocking 1000base-X to 2500base-X requires inband AN for these devices. Simply hacking PCS to do whatever they care for 2500BASE-X is not acceptable. We need a *proper* solution to this, and we need to stop fart arsing about over this, and we need to stop fart arsing around calling things stuff that they are not, perpetuating the confusion in the wider industry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel