From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0023C47073 for ; Wed, 3 Jan 2024 17:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3rLyjrdSjcj1NqMw2HFuS5OWQNeD0mBcERgZrqxPdpQ=; b=wBXi/vyN61O/We wLR7AU37BulEijtFAqWw4jxqv90UeGxkWK9bvAp5c+cl/4L0oTI8JhuFX34lyXTxCeP9P2yA5nqZb gt9CSFLSGE80Y/i1zWqwQGIRxLFYrvarnk/4J2NP28wTufhb5FEi9xZfhg8O5Z8Z62MdgncxWEdsL Gbb9Vyb9Q8vPAjYN2RNu+2qMH1OyexYYKKI+zjuD2Wy++mqLIhTescl7OJWOMigbQwSryk6TRKbnB Q+vn2qnfRrxzoyciJV5D/4COQ3VkUeSLblZFB6FhIX1tYAQKchjc29YrsHy0Mv0c4utWAuEfxU2Io 0JtpVhGuigWgb4QypZyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rL4bM-00BTYV-1L; Wed, 03 Jan 2024 17:00:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rL4bI-00BTWz-2f for linux-arm-kernel@lists.infradead.org; Wed, 03 Jan 2024 17:00:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oVTmI+8SJlo66J8e4e/1PXwZd0ZEK+jDBeMKC2o+Ab8=; b=EFh0ToC/9RxY68FyQPfSmJBxkr 0jQUb8I3mc4fZ2atp9SL3oJkZTRcg5BoLVYQXEK4hQX5h1kbKX9FzGKjkNJ4L28jthZSTu54Xkgl9 vJP2aYFpNgdwHXJWtAG2ZeWkOqYMEakNXaZID41bdpzDRS+Aig2KRdKGcxTullSakE9yUhOYUmMNm WVPNX32gxmcPQmyi8pnR7R7wYIKyxjDlwCdE1gTsasGdWynZb2Zf4/1W/FJdEF3X7UGxoF2yub4WL DF/oaj211yxamL9CtaPiSrKsXS2Vu57xo/2owzMqI00cbOX134oGZKetqzS3AkbO9LeA/f/t5Ufzj qeLsKXBg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55008) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rL4as-0007iH-2U; Wed, 03 Jan 2024 16:59:50 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rL4as-0006Xp-OQ; Wed, 03 Jan 2024 16:59:50 +0000 Date: Wed, 3 Jan 2024 16:59:50 +0000 From: "Russell King (Oracle)" To: Christian Marangi Cc: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Jacek Anaszewski , =?iso-8859-1?Q?Fern=E1ndez?= Rojas , Sven Schwermer , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v6 5/5] net: phy: at803x: add LED support for qca808x Message-ID: References: <20240102183835.5332-1-ansuelsmth@gmail.com> <20240102183835.5332-6-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102183835.5332-6-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_090016_887252_8231C7FC X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 02, 2024 at 07:38:34PM +0100, Christian Marangi wrote: > + if (active_low) { > + ret = phy_clear_bits_mmd(phydev, MDIO_MMD_AN, > + QCA808X_MMD7_LED_POLARITY_CTRL, > + QCA808X_LED_ACTIVE_HIGH); > + } else { > + ret = phy_set_bits_mmd(phydev, MDIO_MMD_AN, > + QCA808X_MMD7_LED_POLARITY_CTRL, > + QCA808X_LED_ACTIVE_HIGH); > + } Maybe: return phy_modify_mmd(phydev, MDIO_MMD_AN, QCA808X_MMD7_LED_POLARITY_CTRL, active_low ? 0 : QCA808X_LED_ACTIVE_HIGH); -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel