From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 342EFC3DA6E for ; Fri, 5 Jan 2024 15:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EHq6J/e0v/h3ojPoJd6SZm1r4MTgU9sCIxXgzptHbKQ=; b=VF8wGUaHdZ5Jkk J3Zl+6khtrkSYa03eOo4zUU4reylsWTvbKfhvcq+0CXUwjwN82IvM/NwWSe6pGVwn/QXZwmuXAcw1 cNjKOfgH/pRIEsZ+skG3p+/NZ+TT6JLo5SYmsAlDO464CQgn95uOPfr3JTklSDk057B58GJeLyviU bzmMwkuYtakjbfgOz8XBtIW8wAJrDE9idj+V6eaVchv034zFg2Go/rMO9TatBVboT55ZcxbMPBYJV E+/P/30hABbNanr15gHjwgTVf9HMW2Nf3VN09gG+YtvsWOW2dgiD3WSA0Zeqih+UBodTIcA2lcEzS H21jISuxqZ2BsHLXwjSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLlyd-00H9UE-2j; Fri, 05 Jan 2024 15:19:15 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLlyZ-00H9Sj-1U for linux-arm-kernel@lists.infradead.org; Fri, 05 Jan 2024 15:19:13 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a26f73732c5so180652166b.3 for ; Fri, 05 Jan 2024 07:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704467949; x=1705072749; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=cXM8mUu2b7I5NINWgE1xN7lsAgN9ikjmrQenDxvMoYo=; b=KV5Ycnxk9ig8irhI9iMTQKquOJpd/ACPshxMsgquVZ0Xlpnz6wi6G4lkB3RwP35p5A fjDMUS3O/8hehxIM2fZlDrm0VOLiDLhyMxpqHd+usgupkvcn6Yku6biOxWVeIHwK/fCi H+4CQEwHwttdP7yTahbEZJf0CapRpm9+KgwKqmqCNABr21BsUq5GeWykwMmn1CUpVtjy A1fjANwLm2GpjATdCRsB1JrHbzqelNmMTBK72CVpBe7VwZT+MJyW185Q2WL0dCdkcwei oV0111hbOBXwh6DTVe2KDU9+6heJJfFxXtaHdqxQE4SEB4G0JRhmGUhh3hWNaw+CLuDl 68Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704467949; x=1705072749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cXM8mUu2b7I5NINWgE1xN7lsAgN9ikjmrQenDxvMoYo=; b=W5C+xMniLR9paC9X7y4BqB1xDRd1MG6/TiM4ddSTeH3dYCOKDmx/VyuFicj0X220Uj Tk6sQLTqATjn2M1hgoQsGWVtApNE0xVY+FMC7NlRKpXlPiPNMbXqWhNfhBuFJXmdTViX iJZboKjXo5kHeRQYOWERyVOK/XKYu9GSZIyeVJ1vjqxbxDC4f/1Y/y31Wd26EUl4lh4f kV5lVzRRhukhODsI4wVmlQM+jGR2kW2TJg/DxK/yRhCuVBzoL8f/rJMJNf+gblgWE5uD wjjOGUIPdsqGet4IF7m1oZ8kKQrr8Kq0+2xZMtf4W1bajYs/ElxEkoS8ivy9idyLwNIv Hesg== X-Gm-Message-State: AOJu0YxIlSAyCUHsfpKViu6+Iv+EvWBQocCK5HOpKFbn13yI0opBTZjA l/Vd9Mh5xBSLPvtC05PNpNg= X-Google-Smtp-Source: AGHT+IHMylC1f/uOwiPnE54XyvPyUNJflvpVz3FB0ZLbHNPVoLKw4ML5AEQ2yE/zVzZzRQJG9qQEHw== X-Received: by 2002:a17:906:6a82:b0:a23:4c5d:dab4 with SMTP id p2-20020a1709066a8200b00a234c5ddab4mr1164549ejr.62.1704467948901; Fri, 05 Jan 2024 07:19:08 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id mj20-20020a170906af9400b00a27a7fa8691sm979246ejb.137.2024.01.05.07.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 07:19:07 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Fri, 5 Jan 2024 16:19:06 +0100 To: Daniel Xu Cc: bpf@vger.kernel.org, fsverity@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, cgroups@vger.kernel.org, netdev@vger.kernel.org, alexei.starovoitov@gmail.com, olsajiri@gmail.com, quentin@isovalent.com, alan.maguire@oracle.com, memxor@gmail.com Subject: Re: [PATCH bpf-next v2 0/3] Annotate kfuncs in .BTF_ids section Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240105_071911_497412_0507ADB0 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 04, 2024 at 07:45:46PM -0700, Daniel Xu wrote: > === Description === > > This is a bpf-treewide change that annotates all kfuncs as such inside > .BTF_ids. This annotation eventually allows us to automatically generate > kfunc prototypes from bpftool. > > We store this metadata inside a yet-unused flags field inside struct > btf_id_set8 (thanks Kumar!). pahole will be taught where to look. > > More details about the full chain of events are available in commit 3's > description. > > The accompanying pahole changes (still needs some cleanup) can be viewed > here on this "frozen" branch [0]. > > [0]: https://github.com/danobi/pahole/tree/kfunc_btf-mailed great, lgtm.. seems I've got the tags in right places (128 kfuncs) please send it on the list once you're done with that, so we could comment on that thanks, jirka > > === Changelog === > > Changes from v1: > * Move WARN_ON() up a call level > * Also return error when kfunc set is not properly tagged > * Use BTF_KFUNCS_START/END instead of flags > * Rename BTF_SET8_KFUNC to BTF_SET8_KFUNCS > > Daniel Xu (3): > bpf: btf: Support flags for BTF_SET8 sets > bpf: btf: Add BTF_KFUNCS_START/END macro pair > bpf: treewide: Annotate BPF kfuncs in BTF > > drivers/hid/bpf/hid_bpf_dispatch.c | 8 +++---- > fs/verity/measure.c | 4 ++-- > include/linux/btf_ids.h | 21 +++++++++++++++---- > kernel/bpf/btf.c | 4 ++++ > kernel/bpf/cpumask.c | 4 ++-- > kernel/bpf/helpers.c | 8 +++---- > kernel/bpf/map_iter.c | 4 ++-- > kernel/cgroup/rstat.c | 4 ++-- > kernel/trace/bpf_trace.c | 8 +++---- > net/bpf/test_run.c | 8 +++---- > net/core/filter.c | 16 +++++++------- > net/core/xdp.c | 4 ++-- > net/ipv4/bpf_tcp_ca.c | 4 ++-- > net/ipv4/fou_bpf.c | 4 ++-- > net/ipv4/tcp_bbr.c | 4 ++-- > net/ipv4/tcp_cubic.c | 4 ++-- > net/ipv4/tcp_dctcp.c | 4 ++-- > net/netfilter/nf_conntrack_bpf.c | 4 ++-- > net/netfilter/nf_nat_bpf.c | 4 ++-- > net/xfrm/xfrm_interface_bpf.c | 4 ++-- > net/xfrm/xfrm_state_bpf.c | 4 ++-- > .../selftests/bpf/bpf_testmod/bpf_testmod.c | 8 +++---- > 22 files changed, 77 insertions(+), 60 deletions(-) > > -- > 2.42.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel