From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DE9AC47077 for ; Mon, 8 Jan 2024 15:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hjLyX9vfQqQfIF5JbHME6es569+kkHSbUaOw5igG61I=; b=XI/EvsvyImhRL6 VTnTEhmHifuBRjvidMvZdlEmi9vCBZB61Luq6O/EpYTkTdrTKVgaA3XazT5MW+WfLOTOf5UMqQ0HY E30fFvZOFBO+6AvIIDgPkRm99Jno+iK4aCr0SX/FFYrDFKrHUmpth2l6AYGlRqmvx6th9ydPVPeUK 9MGAqRJ0cs869xCXqySQ5GWkXskX9pFN3yufk6W9ev7wDXfBkIKahev+PBZBlvVA/31gARi0qSAC0 qa3hBLdlcbuFN92i+HHmObl+THLXx6aFbCpoD5i8fsTGD8pMpgMQBwnMnSuka8z8/UxHzgRDaUzDn TI5LmuxHBLGUxhDN1PHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMrER-005Qqc-2C; Mon, 08 Jan 2024 15:08:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMrEN-005Qq7-1Z for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 15:08:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704726477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGkGg6RWYBQE5b/vbAuEGwRY5SKVcqrmQKtMawiQB5k=; b=jRs4eCTlQ6dqKOp3KfqRxkByzT6QJxSYNbwc9YLrHGuY/dJSjjgLj532hPyGi8gzkNt8XG 3I7MQVnRuFaRmYqB/MRB1iFp5n1VcjMGk/xFbP9ArlYXECd9YLiuj2Q7zs68fAeW6sW+hg 39bF8d7RnyZuNDpeabwjFYvH07i7pjM= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-NQakP5gNMw6jlbVyZBhoww-1; Mon, 08 Jan 2024 10:07:55 -0500 X-MC-Unique: NQakP5gNMw6jlbVyZBhoww-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-28b77ca8807so585893a91.3 for ; Mon, 08 Jan 2024 07:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704726475; x=1705331275; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGkGg6RWYBQE5b/vbAuEGwRY5SKVcqrmQKtMawiQB5k=; b=IECNlk+OQtWkqLCsDT+Qcxu1hJV0JTsXpKDdfwxk841HX856iQM927eIjZAuzuLDkm FSLyDpHCilTCuZ5yfDXL4Fl2cLNc5ZxJiMHzO2Sp7O0lmC3h9t70MhrKb4dRTbEK4VRG LCqnevVez/3ktZyDEfVqyOm02Ee9o4Ab2Gb9gzcG7cj5gFpH2HBG6uBW7Uj2dFuryi8h UaTLbmCSrNsLuRADdtivPrqCWjkjBH4gthFgtTItAOgYADGXsZjYLmd+XKSYIsMb3sFc MFNKsZuAzy9MKF1S0KUPAtrmlz7FNOqMehfgdRE52KiLZOLDVS76v5BEfl2sagzlBqeG 4nRw== X-Gm-Message-State: AOJu0YwWjGKdFKYCcGs8eE/mpe1uM2qvD58phZ9nufjiZGnASkMDrhDG WpzDDfdBasTOIs6eNuNhYp5IM1hNWZHDgT0eXlYtfxAMGJtid5Tvf97BSrEAQdxV41zF52Bn94B g5kX6Kl7LwyPHyn8ILS6GnPpSJCcKOkY9Mdr83sGPeeY= X-Received: by 2002:a17:90a:9a92:b0:28c:6529:ec9c with SMTP id e18-20020a17090a9a9200b0028c6529ec9cmr1176646pjp.92.1704726474809; Mon, 08 Jan 2024 07:07:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8hI/FTvmA45bxfRTbHrh7uolmBIN6qyyCS+HvONvtiC8qNzr83Hlrhe2QGgtKCUrt2aUQIg== X-Received: by 2002:a17:90a:9a92:b0:28c:6529:ec9c with SMTP id e18-20020a17090a9a9200b0028c6529ec9cmr1176622pjp.92.1704726474474; Mon, 08 Jan 2024 07:07:54 -0800 (PST) Received: from LeoBras.redhat.com ([2804:1b3:a803:26a5:3f32:e12b:5335:3c2d]) by smtp.gmail.com with ESMTPSA id l21-20020a17090ac59500b0028acb86f7b5sm57168pjt.44.2024.01.08.07.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 07:07:54 -0800 (PST) From: Leonardo Bras To: Arnd Bergmann Cc: Leonardo Bras , Mark Rutland , Oleg Nesterov , Catalin Marinas , Will Deacon , Mark Brown , Steven Rostedt , Guo Hui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] arm64: remove unnecessary ifdefs around is_compat_task() Date: Mon, 8 Jan 2024 12:07:48 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: <112ae7d5-61b2-4887-a56f-35ea7c3b1bfa@app.fastmail.com> References: <20240105041458.126602-3-leobras@redhat.com> <112ae7d5-61b2-4887-a56f-35ea7c3b1bfa@app.fastmail.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_070759_601131_1A144BC6 X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 05, 2024 at 03:38:05PM +0100, Arnd Bergmann wrote: > On Fri, Jan 5, 2024, at 14:14, Mark Rutland wrote: > > On Fri, Jan 05, 2024 at 01:15:00AM -0300, Leonardo Bras wrote: > > arch/arm64/kernel/ptrace.c:2121:25: note: each undeclared identifier is > > reported only once for each function it appears in > > arch/arm64/kernel/ptrace.c:2123:25: error: 'user_aarch32_ptrace_view' > > undeclared (first use in this function) > > 2123 | return &user_aarch32_ptrace_view; > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > make[4]: *** [scripts/Makefile.build:243: arch/arm64/kernel/ptrace.o] > > Error 1 > > make[3]: *** [scripts/Makefile.build:480: arch/arm64/kernel] Error 2 > > make[2]: *** [scripts/Makefile.build:480: arch/arm64] Error 2 > > make[1]: *** [/home/mark/src/linux/Makefile:1911: .] Error 2 > > make: *** [Makefile:234: __sub-make] Error 2 > > > > ... and looking at the code, user_aarch32_view and user_aarch32_ptrace_view are > > both defined under ifdeffery for CONFIG_COMPAT, so that's obviously not going > > to work... Thanks for noticing, Mark! > > I suspect it's enough to remove all of the other > "#ifdef CONFIG_COMPAT" checks in this file and rely on > dead code elimination to remove the rest, but there might > be additional problems if some extern declarations are > hidden in an #ifdef as well. > > Arnd Sure, I sill send a v2 soon. Thanks! Leo > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel