From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 281C8C3DA6E for ; Mon, 8 Jan 2024 16:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sw6m1P9MemdSIW5RwAd/mMctqok5jzcyLteXjcykLPo=; b=jLZzxduhpn8ojbhJrFK5U5Djnc tHLexVC3IMtd52U8iYILDdHkkPU1mtQGR+9+KOP+SBxa3GPEuMGpfUnjtxye9preFKoXmuLe1KUn2 4leqMmrL0Qv3WCZhZZMGpygUDYdPzeKt5bFWO7F2LW3HEhbIMGLOkCYoBS9uG4gZiGvaxy081ZuWU AXwxTdDSEPr28QgphPKb7pUaTzQ1fwkljurUHOmS2Xti8s95Gt/Rjif42wd1U3KyqFyOSLIZD4KZV 7XMf/sH/fYpsokq41H8837lv0/wWbWlSZmBH/nKr55L5rNotxgHsWOkxWSeBkwVol9W81E3ZMYFgs NVxb5JqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMslv-005gKk-2D; Mon, 08 Jan 2024 16:46:43 +0000 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMslt-005gJg-0n for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 16:46:42 +0000 Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-467a18fc0fcso255765137.3 for ; Mon, 08 Jan 2024 08:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704732400; x=1705337200; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v86cSdeLVN4Eor53KHOEZU66rYPCIfEGIjL+hEGlyNA=; b=T9dkGbgFZWS6YRAw9VkLEp8yVjdFEeMgGDrCT7frLKVMcpx7n32BO2FqOxjSGzJeOm l36GpxM+sriC4O9YzYyUqlR6y+VkX4Akf8bobev+mAgbpA7laTfu4cdH8Fqs5dI1dVLZ H44J58/1naePTWXenDwBKz0beghu0D+aYLG7xpxdgvIcVYvA21o1ALGqJ0cSM4CuiPxS snb8yuugTzXwPmBUPXtkU042tCB3VB8YkAZ4lUqCMomDLlEReyTrAwGmrcX2eVJg8Ueb 2cYtg5i8sYdHxAAN0huZguTyDvfcwzRymhhushcBgfRauHvMpy5fcLDMpwt5Orl7Zq6K bOeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704732400; x=1705337200; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v86cSdeLVN4Eor53KHOEZU66rYPCIfEGIjL+hEGlyNA=; b=hd2ES3kM/agjpMDMriVt/t/22fCrDAa5bFBMDBEnikCBYDGZyDW1+j5rHYe5fooULm K67jbOK5vx2ZjTs6Sl+4YpndaxN1xQvORygAu33cLBt99UNzF652S/G2VDayzoNCOUD+ Rf4qWd59NZ9h4tAG9xX2PIzna6kvplvQSRhDzKYnbQqIhAtyB+ClxR64OMMyF8r7kpoq ibdf64pQFBKO2umVcmgqwWW16+yNH4IvHtr9K6zb5XtjHH0apBJwnTzxXcFP/4td/753 42YQk5NrMeuRTek+jAK5Wen8Ze1th8MZmr1QpZvWNto7838r70enntLX0Isq+1sH5HhO RDEg== X-Gm-Message-State: AOJu0YyU+JF2/DC/HMORfYAaPJKBT5tyjb9O/Q1665Go18YWXH0cdfIt MUg51i7gm31I7LyvQlkiTRylu98HNvo9Ww== X-Google-Smtp-Source: AGHT+IFDHtN0shChS/FabzBprTpMRYYx1/bf2NeDqz0LAzczeUWPYsOkVksyLMdiy/L1EaVaq6GIxA== X-Received: by 2002:a67:e687:0:b0:467:a189:2f51 with SMTP id hv7-20020a67e687000000b00467a1892f51mr1623827vsb.66.1704732399907; Mon, 08 Jan 2024 08:46:39 -0800 (PST) Received: from ubuntu-server-vm-macos (072-189-067-006.res.spectrum.com. [72.189.67.6]) by smtp.gmail.com with ESMTPSA id hx6-20020a67e786000000b00467be2e0fa1sm26884vsb.25.2024.01.08.08.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 08:46:39 -0800 (PST) Date: Mon, 8 Jan 2024 16:46:37 +0000 From: William Breathitt Gray To: Fabrice Gasnier Cc: lee@kernel.org, alexandre.torgue@foss.st.com, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/10] counter: stm32-timer-cnt: introduce clock signal Message-ID: References: <20231220145726.640627-1-fabrice.gasnier@foss.st.com> <20231220145726.640627-5-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20231220145726.640627-5-fabrice.gasnier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_084641_284220_5B65084E X-CRM114-Status: GOOD ( 18.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2642789000598954188==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2642789000598954188== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FfZYnz6NI7seIHjE" Content-Disposition: inline --FfZYnz6NI7seIHjE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 20, 2023 at 03:57:20PM +0100, Fabrice Gasnier wrote: > Introduce the internal clock signal, used to count when in simple rising > function. Also add the "frequency" extension to the clock signal. >=20 > With this patch, signal action reports a consistent state when "increase" > function is used, and the counting frequency: > $ echo increase > function > $ grep -H "" signal*_action > signal0_action:none > signal1_action:none > signal2_action:rising edge > $ echo 1 > enable > $ cat count > 25425 > $ cat count > 44439 > $ cat ../signal2/frequency > 208877930 >=20 > Signed-off-by: Fabrice Gasnier Reviewed-by: William Breathitt Gray The code is all right, but some minor suggestions below. > +static struct counter_comp stm32_count_clock_ext[] =3D { > + COUNTER_COMP_SIGNAL_U64("frequency", stm32_count_clk_get_freq, NULL), It might be worth introducing a new COUNTER_COMP_FREQUENCY() macro now that we have a second driver with the 'frequency' extension (ti-ecap-capture also has 'frequency'). But it's up to you if you want to add a precursor patch to this series, or I'll introduce it separately myself in a independent patch. > @@ -287,7 +321,13 @@ static struct counter_signal stm32_signals[] =3D { > { > .id =3D STM32_CH2_SIG, > .name =3D "Channel 2" > - } > + }, > + { > + .id =3D STM32_CLOCK_SIG, > + .name =3D "Clock Signal", The word "Signal" feels unnecessary to me when both the sysfs path and data structure will have 'signal' already. Do you think "Clock" by itself is clear enough? William Breathitt Gray --FfZYnz6NI7seIHjE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZZwm7QAKCRC1SFbKvhIj K9HkAP9p5tjj9d7bEok5P8rHe8XAO3QFNKaXaaEcdc+BJgMHqAEA2FngXSvqxRzd DSkZbpLR+ErJlXMCYj6LMcwcTUqC2Qk= =D0v2 -----END PGP SIGNATURE----- --FfZYnz6NI7seIHjE-- --===============2642789000598954188== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2642789000598954188==--