From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD41DC3DA6E for ; Mon, 8 Jan 2024 21:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rn4vpRJ3FLPGpIlMU47lJvV35WoKKr+F1CMXPBpiMc0=; b=TLwbsUixXAzMwzOp61gtmKMfH0 +cwdSfM6sFoRGAr8sa1UFC4HCbMDBeKDycmVoWKxRReRvdbHZQDhIFRJmy/FenUYIaBE31KjEZ/Fy SUU7+urubG+pGfB9qXqDM6MbDc8yfEXUcO6lwRGNHd3czLB2IU3x8C+MLNkP2e+bE9zW8dgK2V7kf 5Hlh9AI9V+Xf3MKTjrEueEXTImzrAzZ8glRvqTJz3/N/vIJIPJriaerBokJb1tCtMndiG1N8zkcGT YI3h2uOeRPzIMHzscOrn316G6Q0eVYAkUGR+rR2I7ladYOQ/TgojFy78XkQsX7yPQFD20N+ttmHKJ Tc0tYk+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMwun-006Fby-0P; Mon, 08 Jan 2024 21:12:09 +0000 Received: from mail-ua1-x92e.google.com ([2607:f8b0:4864:20::92e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMwuk-006Faj-2s for linux-arm-kernel@lists.infradead.org; Mon, 08 Jan 2024 21:12:08 +0000 Received: by mail-ua1-x92e.google.com with SMTP id a1e0cc1a2514c-7ce528fc53fso368844241.0 for ; Mon, 08 Jan 2024 13:12:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704748324; x=1705353124; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YBGJtvh92bb/MQJAenOPY/iQdorsefTTda6AN+tF6dQ=; b=jPGZR9BB3JP/w4rGVQfSw6gtva+H8hQnrAj5fKlMI0VN+dkGbSzqq0iMe3ZcfyQKSE lSrRWRiXkJ5FzD1dL7U259ZRzKgPuwCWrtqrk+uWkODfFyL1NKIxtljlaz+1CCB1trWS A4Bc5CjK2LuSuoF/KSZ7OmQINiec1NvMJWlXnd9Vm23CfQZiG6gIWsSHeVrrAuFJDjnI kMXav+B+WXsI3MqHN9irBegzQDn3WyifZl/G1o7LcEC+UZY+ebTBY7lDaghHLvA/d0lR ThiT3SxlQCrdFj1gY6XziJDYX6Wp5K2QLeijrHLKe2TBYeCLUoMqpouHl3ZGYmYVb341 NjKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704748324; x=1705353124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YBGJtvh92bb/MQJAenOPY/iQdorsefTTda6AN+tF6dQ=; b=XXu93dIh0xfBFQ2v/IgPulTRelye8zJN1UpCT1CVNIk3ejqHxCAibqhUSdvThUzY2F aN+5BNwWE9c9EC01bp22MJpVMeISJlH4gzBo3g3nmAh9wm9WmvWDzri06KZt6B5QusrE KRbf/YqNAiEoS/v3PYFsdmELEKZCqxjW9sRA6l5BgYC6mD9xSxyQs6KCcyWwyz5EYi9v 8/8ogTWSgyLtKhDqEm3oP4L6Pd99ie4L+iLFcy4zCk6i8UCf/B/1qI+kYVO1xzFAadbB 2vbwSaYFhYhAOorn/raLy8pDfnPxzwwi+rXBOt7KGQWCUrgdfsqNAG8+5IGgBnjZOCnl x/wg== X-Gm-Message-State: AOJu0Yx70RFSz+k3O0NKuL/VAT+EuNSUXl2WeU75uzQ509vrLG2tSmpb nP1W+LkPOLjlLO8GSIithYdla/Y1DrgarQ== X-Google-Smtp-Source: AGHT+IH3EQQvsaMhKI85+JDKyxLi0PolQ2SDP4LRpa4fw3WIbC3ZktiUYL5iLbnJ2jlU4GzE/GMXnw== X-Received: by 2002:a05:6102:158e:b0:467:da9e:3bd0 with SMTP id g14-20020a056102158e00b00467da9e3bd0mr929523vsv.23.1704748324588; Mon, 08 Jan 2024 13:12:04 -0800 (PST) Received: from ubuntu-server-vm-macos (072-189-067-006.res.spectrum.com. [72.189.67.6]) by smtp.gmail.com with ESMTPSA id g19-20020a05610209d300b0046695b658dcsm92939vsi.30.2024.01.08.13.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 13:12:04 -0800 (PST) Date: Mon, 8 Jan 2024 21:06:52 +0000 From: William Breathitt Gray To: Fabrice Gasnier Cc: lee@kernel.org, alexandre.torgue@foss.st.com, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/10] counter: stm32-timer-cnt: add support for overflow events Message-ID: References: <20231220145726.640627-1-fabrice.gasnier@foss.st.com> <20231220145726.640627-10-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20231220145726.640627-10-fabrice.gasnier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240108_131206_938410_101B2CC8 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6543514821287020751==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6543514821287020751== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eTyfW+fM+V9Seofn" Content-Disposition: inline --eTyfW+fM+V9Seofn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 20, 2023 at 03:57:25PM +0100, Fabrice Gasnier wrote: > diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h > index ca35af30745f..9eb17481b07f 100644 > --- a/include/linux/mfd/stm32-timers.h > +++ b/include/linux/mfd/stm32-timers.h > @@ -41,6 +41,11 @@ > #define TIM_SMCR_SMS (BIT(0) | BIT(1) | BIT(2)) /* Slave mode selection */ > #define TIM_SMCR_TS (BIT(4) | BIT(5) | BIT(6)) /* Trigger selection */ > #define TIM_DIER_UIE BIT(0) /* Update interrupt */ > +#define TIM_DIER_CC1IE BIT(1) /* CC1 Interrupt Enable */ > +#define TIM_DIER_CC2IE BIT(2) /* CC2 Interrupt Enable */ > +#define TIM_DIER_CC3IE BIT(3) /* CC3 Interrupt Enable */ > +#define TIM_DIER_CC4IE BIT(4) /* CC4 Interrupt Enable */ > +#define TIM_DIER_CC_IE(x) BIT((x) + 1) /* CC1, CC2, CC3, CC4 interrupt enable */ > #define TIM_DIER_UDE BIT(8) /* Update DMA request Enable */ > #define TIM_DIER_CC1DE BIT(9) /* CC1 DMA request Enable */ > #define TIM_DIER_CC2DE BIT(10) /* CC2 DMA request Enable */ > @@ -49,6 +54,7 @@ > #define TIM_DIER_COMDE BIT(13) /* COM DMA request Enable */ > #define TIM_DIER_TDE BIT(14) /* Trigger DMA request Enable */ > #define TIM_SR_UIF BIT(0) /* Update interrupt flag */ > +#define TIM_SR_CC_IF(x) BIT((x) + 1) /* CC1, CC2, CC3, CC4 interrupt flag */ > #define TIM_EGR_UG BIT(0) /* Update Generation */ > #define TIM_CCMR_PE BIT(3) /* Channel Preload Enable */ > #define TIM_CCMR_M1 (BIT(6) | BIT(5)) /* Channel PWM Mode 1 */ > @@ -60,16 +66,23 @@ > #define TIM_CCMR_CC1S_TI2 BIT(1) /* IC1/IC3 selects TI2/TI4 */ > #define TIM_CCMR_CC2S_TI2 BIT(8) /* IC2/IC4 selects TI2/TI4 */ > #define TIM_CCMR_CC2S_TI1 BIT(9) /* IC2/IC4 selects TI1/TI3 */ > +#define TIM_CCMR_CC3S (BIT(0) | BIT(1)) /* Capture/compare 3 sel */ > +#define TIM_CCMR_CC4S (BIT(8) | BIT(9)) /* Capture/compare 4 sel */ > +#define TIM_CCMR_CC3S_TI3 BIT(0) /* IC3 selects TI3 */ > +#define TIM_CCMR_CC4S_TI4 BIT(8) /* IC4 selects TI4 */ > #define TIM_CCER_CC1E BIT(0) /* Capt/Comp 1 out Ena */ > #define TIM_CCER_CC1P BIT(1) /* Capt/Comp 1 Polarity */ > #define TIM_CCER_CC1NE BIT(2) /* Capt/Comp 1N out Ena */ > #define TIM_CCER_CC1NP BIT(3) /* Capt/Comp 1N Polarity */ > #define TIM_CCER_CC2E BIT(4) /* Capt/Comp 2 out Ena */ > #define TIM_CCER_CC2P BIT(5) /* Capt/Comp 2 Polarity */ > +#define TIM_CCER_CC2NP BIT(7) /* Capt/Comp 2N Polarity */ > #define TIM_CCER_CC3E BIT(8) /* Capt/Comp 3 out Ena */ > #define TIM_CCER_CC3P BIT(9) /* Capt/Comp 3 Polarity */ > +#define TIM_CCER_CC3NP BIT(11) /* Capt/Comp 3N Polarity */ > #define TIM_CCER_CC4E BIT(12) /* Capt/Comp 4 out Ena */ > #define TIM_CCER_CC4P BIT(13) /* Capt/Comp 4 Polarity */ > +#define TIM_CCER_CC4NP BIT(15) /* Capt/Comp 4N Polarity */ I forgot to mention that you should move the introduction of these defines to the subsequent patch adding support for capture events because that's where the defines are actually used. William Breathitt Gray --eTyfW+fM+V9Seofn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZZxj7AAKCRC1SFbKvhIj K+hKAQDcvx+8TB+sVsYW8HmeYUBMwLZvZN/fvDizKykS/fZDcQD+JaDR+HGTgp3B Lc5+qDJlEopQuesY+K90Tw2taDDrxQY= =S2kh -----END PGP SIGNATURE----- --eTyfW+fM+V9Seofn-- --===============6543514821287020751== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6543514821287020751==--