Re: [PATCH v8 10/13] arm64: dts: Add overlay for RP1 device

Stefan Wahren
2025-04-14T11:47:48Z

Hi Andrea,

just a nit. Could you please add "broadcom:" to the subject?

Am 19.03.25 um 22:52 schrieb Andrea della Porta:
> Define the RP1 node in an overlay. The inclusion tree is
> as follow (the arrow points to the includer):
>
> rp1.dtso
> ^
> |
> rp1-common.dtsi ----> rp1-nexus.dtsi
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> This patch can be considered optional, since it fills just the second
> scenario as detailed in [1], which is the RP1 DT node loaded from a dtb
> overlay by the FW at early boot stage.
> This may be useful for debug purpose, but as such not strictly necessary.
>
> [1] https://lore.kernel.org/all/CAMEGJJ0f4YUgdWBhxvQ_dquZHztve9KO7pvQjoDWJ3=zd3cgcg@mail.gmail.com/#t
> ---
> arch/arm64/boot/dts/broadcom/Makefile | 3 ++-
> arch/arm64/boot/dts/broadcom/rp1.dtso | 11 +++++++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/boot/dts/broadcom/rp1.dtso
>
> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile
> index 4836c6da5bee..58293f9c16ab 100644
> --- a/arch/arm64/boot/dts/broadcom/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/Makefile
> @@ -13,7 +13,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \
> bcm2837-rpi-3-b.dtb \
> bcm2837-rpi-3-b-plus.dtb \
> bcm2837-rpi-cm3-io3.dtb \
> - bcm2837-rpi-zero-2-w.dtb
> + bcm2837-rpi-zero-2-w.dtb \
> + rp1.dtbo
>
> subdir-y += bcmbca
> subdir-y += northstar2
> diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso
> new file mode 100644
> index 000000000000..ab4f146d22c0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&pcie2 {
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + #include "rp1-nexus.dtsi"
> +};