* [PATCH net-next 0/2] net: stmmac: stmmac_pltfr_find_clk() @ 2025-04-07 18:38 Russell King (Oracle) 2025-04-07 18:38 ` [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) 0 siblings, 2 replies; 8+ messages in thread From: Russell King (Oracle) @ 2025-04-07 18:38 UTC (permalink / raw) To: Andrew Lunn, Heiner Kallweit Cc: Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding Hi, The GBETH glue driver that is being proposed duplicates the clock finding from the bulk clock data in the stmmac platform data structure. iLet's provide a generic implementation that glue drivers can use, and convert dwc-qos-eth to use it. drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 14 ++------------ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 11 +++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 3 +++ 3 files changed, 16 insertions(+), 12 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() 2025-04-07 18:38 [PATCH net-next 0/2] net: stmmac: stmmac_pltfr_find_clk() Russell King (Oracle) @ 2025-04-07 18:38 ` Russell King (Oracle) 2025-04-07 19:29 ` Lad, Prabhakar 2025-04-08 13:03 ` Andrew Lunn 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) 1 sibling, 2 replies; 8+ messages in thread From: Russell King (Oracle) @ 2025-04-07 18:38 UTC (permalink / raw) To: Andrew Lunn, Heiner Kallweit Cc: Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding Provide a generic way to find a clock in the bulk data. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 11 +++++++++++ drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index c73eff6a56b8..43c869f64c39 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -709,6 +709,17 @@ devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) #endif /* CONFIG_OF */ EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt); +struct clk *stmmac_pltfr_find_clk(struct plat_stmmacenet_data *plat_dat, + const char *name) +{ + for (int i = 0; i < plat_dat->num_clks; i++) + if (strcmp(plat_dat->clks[i].id, name) == 0) + return plat_dat->clks[i].clk; + + return NULL; +} +EXPORT_SYMBOL_GPL(stmmac_pltfr_find_clk); + int stmmac_get_platform_resources(struct platform_device *pdev, struct stmmac_resources *stmmac_res) { diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h index 72dc1a32e46d..6e6561e29d6e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h @@ -14,6 +14,9 @@ struct plat_stmmacenet_data * devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac); +struct clk *stmmac_pltfr_find_clk(struct plat_stmmacenet_data *plat_dat, + const char *name); + int stmmac_get_platform_resources(struct platform_device *pdev, struct stmmac_resources *stmmac_res); -- 2.30.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() 2025-04-07 18:38 ` [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() Russell King (Oracle) @ 2025-04-07 19:29 ` Lad, Prabhakar 2025-04-08 13:03 ` Andrew Lunn 1 sibling, 0 replies; 8+ messages in thread From: Lad, Prabhakar @ 2025-04-07 19:29 UTC (permalink / raw) To: Russell King (Oracle) Cc: Andrew Lunn, Heiner Kallweit, Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Thierry Reding On Mon, Apr 7, 2025 at 7:39 PM Russell King (Oracle) <rmk+kernel@armlinux.org.uk> wrote: > > Provide a generic way to find a clock in the bulk data. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 11 +++++++++++ > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 3 +++ > 2 files changed, 14 insertions(+) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index c73eff6a56b8..43c869f64c39 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -709,6 +709,17 @@ devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > #endif /* CONFIG_OF */ > EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt); > > +struct clk *stmmac_pltfr_find_clk(struct plat_stmmacenet_data *plat_dat, > + const char *name) > +{ > + for (int i = 0; i < plat_dat->num_clks; i++) > + if (strcmp(plat_dat->clks[i].id, name) == 0) > + return plat_dat->clks[i].clk; > + > + return NULL; > +} > +EXPORT_SYMBOL_GPL(stmmac_pltfr_find_clk); > + > int stmmac_get_platform_resources(struct platform_device *pdev, > struct stmmac_resources *stmmac_res) > { > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h > index 72dc1a32e46d..6e6561e29d6e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h > @@ -14,6 +14,9 @@ > struct plat_stmmacenet_data * > devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac); > > +struct clk *stmmac_pltfr_find_clk(struct plat_stmmacenet_data *plat_dat, > + const char *name); > + > int stmmac_get_platform_resources(struct platform_device *pdev, > struct stmmac_resources *stmmac_res); > > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() 2025-04-07 18:38 ` [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 19:29 ` Lad, Prabhakar @ 2025-04-08 13:03 ` Andrew Lunn 1 sibling, 0 replies; 8+ messages in thread From: Andrew Lunn @ 2025-04-08 13:03 UTC (permalink / raw) To: Russell King (Oracle) Cc: Heiner Kallweit, Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding On Mon, Apr 07, 2025 at 07:38:44PM +0100, Russell King (Oracle) wrote: > Provide a generic way to find a clock in the bulk data. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() 2025-04-07 18:38 [PATCH net-next 0/2] net: stmmac: stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 18:38 ` [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() Russell King (Oracle) @ 2025-04-07 18:38 ` Russell King (Oracle) 2025-04-07 19:33 ` Lad, Prabhakar ` (2 more replies) 1 sibling, 3 replies; 8+ messages in thread From: Russell King (Oracle) @ 2025-04-07 18:38 UTC (permalink / raw) To: Andrew Lunn, Heiner Kallweit Cc: Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c index cd431f84f34f..f5c68e3b4354 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c @@ -34,16 +34,6 @@ struct tegra_eqos { struct gpio_desc *reset; }; -static struct clk *dwc_eth_find_clk(struct plat_stmmacenet_data *plat_dat, - const char *name) -{ - for (int i = 0; i < plat_dat->num_clks; i++) - if (strcmp(plat_dat->clks[i].id, name) == 0) - return plat_dat->clks[i].clk; - - return NULL; -} - static int dwc_eth_dwmac_config_dt(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat) { @@ -132,7 +122,7 @@ static int dwc_qos_probe(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat, struct stmmac_resources *stmmac_res) { - plat_dat->pclk = dwc_eth_find_clk(plat_dat, "phy_ref_clk"); + plat_dat->pclk = stmmac_pltfr_find_clk(plat_dat, "phy_ref_clk"); return 0; } @@ -242,7 +232,7 @@ static int tegra_eqos_probe(struct platform_device *pdev, if (!is_of_node(dev->fwnode)) goto bypass_clk_reset_gpio; - plat_dat->clk_tx_i = dwc_eth_find_clk(plat_dat, "tx"); + plat_dat->clk_tx_i = stmmac_pltfr_find_clk(plat_dat, "tx"); eqos->reset = devm_gpiod_get(&pdev->dev, "phy-reset", GPIOD_OUT_HIGH); if (IS_ERR(eqos->reset)) { -- 2.30.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) @ 2025-04-07 19:33 ` Lad, Prabhakar 2025-04-08 13:04 ` Andrew Lunn 2025-04-08 19:37 ` Jakub Kicinski 2 siblings, 0 replies; 8+ messages in thread From: Lad, Prabhakar @ 2025-04-07 19:33 UTC (permalink / raw) To: Russell King (Oracle) Cc: Andrew Lunn, Heiner Kallweit, Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Thierry Reding On Mon, Apr 7, 2025 at 7:39 PM Russell King (Oracle) <rmk+kernel@armlinux.org.uk> wrote: > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > index cd431f84f34f..f5c68e3b4354 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > @@ -34,16 +34,6 @@ struct tegra_eqos { > struct gpio_desc *reset; > }; > > -static struct clk *dwc_eth_find_clk(struct plat_stmmacenet_data *plat_dat, > - const char *name) > -{ > - for (int i = 0; i < plat_dat->num_clks; i++) > - if (strcmp(plat_dat->clks[i].id, name) == 0) > - return plat_dat->clks[i].clk; > - > - return NULL; > -} > - > static int dwc_eth_dwmac_config_dt(struct platform_device *pdev, > struct plat_stmmacenet_data *plat_dat) > { > @@ -132,7 +122,7 @@ static int dwc_qos_probe(struct platform_device *pdev, > struct plat_stmmacenet_data *plat_dat, > struct stmmac_resources *stmmac_res) > { > - plat_dat->pclk = dwc_eth_find_clk(plat_dat, "phy_ref_clk"); > + plat_dat->pclk = stmmac_pltfr_find_clk(plat_dat, "phy_ref_clk"); > > return 0; > } > @@ -242,7 +232,7 @@ static int tegra_eqos_probe(struct platform_device *pdev, > if (!is_of_node(dev->fwnode)) > goto bypass_clk_reset_gpio; > > - plat_dat->clk_tx_i = dwc_eth_find_clk(plat_dat, "tx"); > + plat_dat->clk_tx_i = stmmac_pltfr_find_clk(plat_dat, "tx"); > > eqos->reset = devm_gpiod_get(&pdev->dev, "phy-reset", GPIOD_OUT_HIGH); > if (IS_ERR(eqos->reset)) { > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 19:33 ` Lad, Prabhakar @ 2025-04-08 13:04 ` Andrew Lunn 2025-04-08 19:37 ` Jakub Kicinski 2 siblings, 0 replies; 8+ messages in thread From: Andrew Lunn @ 2025-04-08 13:04 UTC (permalink / raw) To: Russell King (Oracle) Cc: Heiner Kallweit, Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding On Mon, Apr 07, 2025 at 07:38:49PM +0100, Russell King (Oracle) wrote: > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 19:33 ` Lad, Prabhakar 2025-04-08 13:04 ` Andrew Lunn @ 2025-04-08 19:37 ` Jakub Kicinski 2 siblings, 0 replies; 8+ messages in thread From: Jakub Kicinski @ 2025-04-08 19:37 UTC (permalink / raw) To: Russell King (Oracle) Cc: Andrew Lunn, Heiner Kallweit, Alexandre Torgue, Andrew Lunn, David S. Miller, Eric Dumazet, Jon Hunter, linux-arm-kernel, linux-stm32, Maxime Coquelin, netdev, Paolo Abeni, Prabhakar, Thierry Reding On Mon, 07 Apr 2025 19:38:49 +0100 Russell King (Oracle) wrote: > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > .../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > index cd431f84f34f..f5c68e3b4354 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > @@ -34,16 +34,6 @@ struct tegra_eqos { > struct gpio_desc *reset; > }; > > -static struct clk *dwc_eth_find_clk(struct plat_stmmacenet_data *plat_dat, > - const char *name) > -{ > - for (int i = 0; i < plat_dat->num_clks; i++) > - if (strcmp(plat_dat->clks[i].id, name) == 0) > - return plat_dat->clks[i].clk; > - > - return NULL; > -} Missed one user? drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c:355:25: error: call to undeclared function 'dwc_eth_find_clk'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 355 | plat_dat->stmmac_clk = dwc_eth_find_clk(plat_dat, | ^ drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c:355:23: error: incompatible integer to pointer conversion assigning to 'struct clk *' from 'int' [-Wint-conversion] 355 | plat_dat->stmmac_clk = dwc_eth_find_clk(plat_dat, | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ 356 | data->stmmac_clk_name); | ~~~~~~~~~~~~~~~~~~~~~~ -- pw-bot: cr ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-04-08 19:39 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-07 18:38 [PATCH net-next 0/2] net: stmmac: stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 18:38 ` [PATCH net-next 1/2] net: stmmac: provide stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 19:29 ` Lad, Prabhakar 2025-04-08 13:03 ` Andrew Lunn 2025-04-07 18:38 ` [PATCH net-next 2/2] net: stmmac: dwc-qos: use stmmac_pltfr_find_clk() Russell King (Oracle) 2025-04-07 19:33 ` Lad, Prabhakar 2025-04-08 13:04 ` Andrew Lunn 2025-04-08 19:37 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).