From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3495C369BA for ; Wed, 16 Apr 2025 17:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F/+k1VaPPfC6JjSP1qAD5erxrr3Ql1dchYoION8KrN4=; b=mHfBMC1DCv2P1OijnTKfJAJNpo S2rQNtZNf957vGItfWeg381sopCowliIipnNHHeYESU6ZbUJ30sAVWqzCGckLM1Y2D6M/Q4hEh7s6 fQORimLkk+S7IuuesL1sJHup2YGcm3Rtzlk79I43Kypxch0kyPK389vGJwOF5U0qfIqSAWa7ccTjs cEXGeVMgMYAKahcNbVvSs2Le7r/wIGx/3NcOW6ArrazqrMRRbJjLMUX94UjoLoiiEe4f9CMMbqfkG vhzXE66CBKpUVZUxfdl8drjg8A3Ylu9UG6cEoqamJTD9zw7+UFK5MRQTPMhhvg+QOaXBU/Tz+ZZlg QPCSsbfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u56nc-0000000AS9w-1Qf8; Wed, 16 Apr 2025 17:43:48 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u56ll-0000000ARxY-3mcX for linux-arm-kernel@lists.infradead.org; Wed, 16 Apr 2025 17:41:55 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-ac7bd86f637so199124266b.1 for ; Wed, 16 Apr 2025 10:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744825312; x=1745430112; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=F/+k1VaPPfC6JjSP1qAD5erxrr3Ql1dchYoION8KrN4=; b=Dmg0zCxQgRexMGWrWBLtpISmpduPOQlze6+Rhg0wZj+h9BaJJMH3AXWVHO0IuE6PL8 YZtlNSoIqbM0JPFufYio35HyOIz+AZqKS53r33jvofziRtsHjMLDv3IuQJbhj35WwTa8 9mdKDNtZIcTJYswK8xbV26gAcpMDshVRHkUAuF+JJ4BCKaJsiPvqvd02w/yrOcBvm4AI Vy59pwWQxeekM/4AxybYxM/wmoMf+pYxBB2Hf//IiENwHuKnZH341T8TVqkXDwSlV2wu U4DGayFEg/vZ5ZDWHarghkJbce5ZzN+sTbRyYl/U1/EQZYDAezLKo8t48SRh7AsezCuv l8lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744825312; x=1745430112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F/+k1VaPPfC6JjSP1qAD5erxrr3Ql1dchYoION8KrN4=; b=j+Su+7oD3pTGZXfDFdeuFJvNr/D09CB40dyRiiIPphpXCxJAlDGRo8wJ1492T4Af8l W7eCCyzO7k1Mv/7aPmnwGrU0nmYbaf2Dy/J0jOa+OGY1ZzrG2OB/gX9kUphFfDl/3JoB /J17ZHi+2MAYQW03m+l9cGSx2XLDihDScPxNdm2Y6V1+lvwprFGhWI+8V9/LpskqCahX A4ZSLZLaqGld7ArbwTJfyCsKUNhfdlCDxY0TIqWQwavoA4td4syq2A9MasxtYERylArw iWdOA5iWCWiCXCc6byHsNs1DZBHTvk7toyCTL/bnbwjoU0sIwTBYpyxY8i7UgtJNG75p YoKw== X-Forwarded-Encrypted: i=1; AJvYcCVaRyj86SI6SBH60TU5SWtT/i8U6zJuFTECMD7wh69HvdPfOFN+WclYHkSnmfinLxmqcBI0AzIIpkfmCFMjg1Kd@lists.infradead.org X-Gm-Message-State: AOJu0YxraXu6xaQaDcj/TL3QjUToHRFdlZFena2dGcv4LoFNwOhjdWk8 9AerSiamFJFVcjYi1eG7RLTBYO4LkK1YXgEyFzX5OMSfHdQXAT2WEuxrcuou1oA= X-Gm-Gg: ASbGnctVI8It/aNCje0vOr3Wbvz8mKoDilDDxACbqBeDJwhKcfFPlU1bGOYCSTYS3hB FZ4w1PfHgzK4GubOH05cZ8pX/WPVan3yHFxMwyiZGa/vMQMCEHxjHw1vFnYJKMK4AWWnJFP5IJl YDdGuOeunBkuUPN93Ddx0SUAxI45t+SdghiMbOpUFANj02he4GOwDsqpkZslL26CAQBdvKluTrv hpw5mq7AyDeGO+PrY2NkCOLuWwduh3RZjkGgA+VzjTqHMbpwg/4ZEBks+jLSVoi2zzSpjZG5gCy AC4DZRw8oSQrQvZoBnYjcSKHaNuOFVeqGSGJ6ZBlOHKJSw9wv8UK02W7BuUtFk6HBD6hJQY= X-Google-Smtp-Source: AGHT+IG7VChiUUBXbPZt2UsOsnvfmMZv1kTPdmKDqxu0K/iyE0OKTXPbM6G10YQaE7vDg/k0DkFp+g== X-Received: by 2002:a17:907:1b2a:b0:ac7:b1eb:8283 with SMTP id a640c23a62f3a-acb5220ab4dmr51498666b.17.1744825311718; Wed, 16 Apr 2025 10:41:51 -0700 (PDT) Received: from localhost (93-44-188-26.ip98.fastwebnet.it. [93.44.188.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d1ce081sm159581866b.154.2025.04.16.10.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 10:41:51 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Wed, 16 Apr 2025 19:43:14 +0200 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 09/13] arm64: dts: Add board DTS for Rpi5 which includes RP1 node Message-ID: References: <526751d2-c7e8-4097-9454-c9049b880225@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <526751d2-c7e8-4097-9454-c9049b880225@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250416_104153_942395_6AB13C16 X-CRM114-Status: GOOD ( 30.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On 13:48 Mon 14 Apr , Stefan Wahren wrote: > Hi Andrea, > > Am 19.03.25 um 22:52 schrieb Andrea della Porta: > > Add the board 'monolithic' DTS for RaspberryPi 5 which includes > > the RP1 node definition. The inclusion treeis as follow (the > > arrow points to the includer): > > > > rp1-common.dtsi ----> rp1-nexus.dtsi ----> bcm2712-rpi-5-b-monolithic.dts > > ^ > > | > > bcm2712-rpi-5-b.dts > sorry for the delay. I'm not happy with the monolithic appendix. > > How about bcm2712-rpi-5-b-rp1.dts or something more self-explaining?Regards Sure, good catch. I'd go even further saying that we can rename (or merge if the destination file already exists) as: bcm2712-rpi-5-b.dts -> bcm2712-rpi-5-b-norp1.dts (or some better suffix other than -norp1) bcm2712-rpi-5-b-monolithic.dts -> bcm2712-rpi-5-b.dts so the monolithic one, which seems to be the 'safest' option as of now, would be the default dtb. Do you think it could be ok? > > This is designed to maximize the compatibility with downstream DT > > while ensuring that a fully defined DT (one which includes the RP1 > > node as opposed to load it from overlay at runtime) is present > > since early boot stage. > > > > Signed-off-by: Andrea della Porta > > --- > > Right now bcm2712-rpi-5-b.dts is the overlay-ready DT which will make > > the RP1 driver to load the RP1 dtb overlay at runtime, while > > bcm2712-rpi-5-b-monolithic.dts is the fully defined one (i.e. it > > already contains RP1 node, so no overlay is loaded nor needed). > > Depending on which one we want to be considered the default, we can > > swap the file names to align with downstream naming convention that > > has only the fully defined DT called bcm2712-rpi-5-b.dts. > Could you please move some of this good explanation into this dts file as > comment? Sure. Thanks, Andrea > > --- > > arch/arm64/boot/dts/broadcom/Makefile | 1 + > > .../boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > > > diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile > > index 3d0efb93b06d..4836c6da5bee 100644 > > --- a/arch/arm64/boot/dts/broadcom/Makefile > > +++ b/arch/arm64/boot/dts/broadcom/Makefile > > @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += bcm2711-rpi-400.dtb \ > > bcm2711-rpi-4-b.dtb \ > > bcm2711-rpi-cm4-io.dtb \ > > bcm2712-rpi-5-b.dtb \ > > + bcm2712-rpi-5-b-monolithic.dtb \ > > bcm2712-d-rpi-5-b.dtb \ > > bcm2837-rpi-3-a-plus.dtb \ > > bcm2837-rpi-3-b.dtb \ > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > new file mode 100644 > > index 000000000000..3aeee678b0bc > > --- /dev/null > > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-monolithic.dts > > @@ -0,0 +1,8 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/dts-v1/; > > + > > +#include "bcm2712-rpi-5-b.dts" > > + > > +&pcie2 { > > + #include "rp1-nexus.dtsi" > > +}; >