* [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on
@ 2025-04-16 18:06 Janne Grunau via B4 Relay
2025-04-16 18:07 ` Alyssa Rosenzweig
2025-04-19 6:42 ` Sven Peter
0 siblings, 2 replies; 3+ messages in thread
From: Janne Grunau via B4 Relay @ 2025-04-16 18:06 UTC (permalink / raw)
To: Sven Peter, Alyssa Rosenzweig, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Nick Chan, Sasha Finkelstein
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel, Janne Grunau
From: Janne Grunau <j@jannau.net>
The driver depends on boot loader initialized state which resets when the
ps_dispdfr_be power-domain is powered off. This happens on suspend or
when the driver is missing during boot.
Mark the domain as always on until the driver can handle this.
Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
Signed-off-by: Janne Grunau <j@jannau.net>
---
arch/arm64/boot/dts/apple/t8103-j293.dts | 10 ++++++++++
arch/arm64/boot/dts/apple/t8112-j493.dts | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
index 2dfe7b895b2bc0a913e73141e558fa5124a13b2e..e2d9439397f71a93c28b75a7eea589f4bcb3e374 100644
--- a/arch/arm64/boot/dts/apple/t8103-j293.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
@@ -77,6 +77,16 @@ touchbar0: touchbar@0 {
};
};
+/*
+ * The driver depends on boot loader initialized state which resets when this
+ * power-domain is powered off. This happens on suspend or when the driver is
+ * missing during boot. Mark the domain as always on until the driver can
+ * handle this.
+ */
+&ps_dispdfr_be {
+ apple,always-on;
+};
+
&display_dfr {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
index 3d73f9ee2f46a35a3b23da5b233ef316c7372ef7..be86d34c6696cb47d31696541266e504cee8ce10 100644
--- a/arch/arm64/boot/dts/apple/t8112-j493.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
@@ -40,6 +40,16 @@ led-0 {
};
};
+/*
+ * The driver depends on boot loader initialized state which resets when this
+ * power-domain is powered off. This happens on suspend or when the driver is
+ * missing during boot. Mark the domain as always on until the driver can
+ * handle this.
+ */
+&ps_dispdfr_be {
+ apple,always-on;
+};
+
&display_dfr {
status = "okay";
};
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250416-arm64_dts_apple_touchbar-658cd974de97
Best regards,
--
Janne Grunau <j@jannau.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on
2025-04-16 18:06 [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on Janne Grunau via B4 Relay
@ 2025-04-16 18:07 ` Alyssa Rosenzweig
2025-04-19 6:42 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Rosenzweig @ 2025-04-16 18:07 UTC (permalink / raw)
To: j
Cc: Sven Peter, Neal Gompa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nick Chan, Sasha Finkelstein, asahi,
linux-arm-kernel, devicetree, linux-kernel
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Thanks for debugging this
Le Wed , Apr 16, 2025 at 08:06:18PM +0200, Janne Grunau via B4 Relay a écrit :
> From: Janne Grunau <j@jannau.net>
>
> The driver depends on boot loader initialized state which resets when the
> ps_dispdfr_be power-domain is powered off. This happens on suspend or
> when the driver is missing during boot.
> Mark the domain as always on until the driver can handle this.
>
> Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> arch/arm64/boot/dts/apple/t8103-j293.dts | 10 ++++++++++
> arch/arm64/boot/dts/apple/t8112-j493.dts | 10 ++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 2dfe7b895b2bc0a913e73141e558fa5124a13b2e..e2d9439397f71a93c28b75a7eea589f4bcb3e374 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -77,6 +77,16 @@ touchbar0: touchbar@0 {
> };
> };
>
> +/*
> + * The driver depends on boot loader initialized state which resets when this
> + * power-domain is powered off. This happens on suspend or when the driver is
> + * missing during boot. Mark the domain as always on until the driver can
> + * handle this.
> + */
> +&ps_dispdfr_be {
> + apple,always-on;
> +};
> +
> &display_dfr {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index 3d73f9ee2f46a35a3b23da5b233ef316c7372ef7..be86d34c6696cb47d31696541266e504cee8ce10 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
> @@ -40,6 +40,16 @@ led-0 {
> };
> };
>
> +/*
> + * The driver depends on boot loader initialized state which resets when this
> + * power-domain is powered off. This happens on suspend or when the driver is
> + * missing during boot. Mark the domain as always on until the driver can
> + * handle this.
> + */
> +&ps_dispdfr_be {
> + apple,always-on;
> +};
> +
> &display_dfr {
> status = "okay";
> };
>
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250416-arm64_dts_apple_touchbar-658cd974de97
>
> Best regards,
> --
> Janne Grunau <j@jannau.net>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on
2025-04-16 18:06 [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on Janne Grunau via B4 Relay
2025-04-16 18:07 ` Alyssa Rosenzweig
@ 2025-04-19 6:42 ` Sven Peter
1 sibling, 0 replies; 3+ messages in thread
From: Sven Peter @ 2025-04-19 6:42 UTC (permalink / raw)
To: Alyssa Rosenzweig, Neal Gompa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nick Chan, Sasha Finkelstein, Janne Grunau
Cc: Sven Peter, asahi, linux-arm-kernel, devicetree, linux-kernel
On Wed, 16 Apr 2025 20:06:18 +0200, Janne Grunau wrote:
> The driver depends on boot loader initialized state which resets when the
> ps_dispdfr_be power-domain is powered off. This happens on suspend or
> when the driver is missing during boot.
> Mark the domain as always on until the driver can handle this.
>
>
Applied to git@github.com:AsahiLinux/linux.git (asahi-soc/fixes), thanks!
[1/1] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on
https://github.com/AsahiLinux/linux/commit/dc5befecbe26
Best regards,
--
Sven Peter <sven@svenpeter.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-19 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-16 18:06 [PATCH] arm64: dts: apple: touchbar: Mark ps_dispdfr_be as always-on Janne Grunau via B4 Relay
2025-04-16 18:07 ` Alyssa Rosenzweig
2025-04-19 6:42 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).