From: Ingo Molnar <mingo@kernel.org>
To: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Ira Weiny <ira.weiny@intel.com>, Jann Horn <jannh@google.com>,
Jeff Xu <jeffxu@chromium.org>, Joey Gouly <joey.gouly@arm.com>,
Kees Cook <kees@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Lutomirski <luto@kernel.org>, Marc Zyngier <maz@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Pierre Langlois <pierre.langlois@arm.com>,
Quentin Perret <qperret@google.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: Re: [RFC PATCH v4 00/18] pkeys-based page table hardening
Date: Fri, 11 Apr 2025 11:21:30 +0200 [thread overview]
Message-ID: <Z_jfGlOEb4Bjl3vO@gmail.com> (raw)
In-Reply-To: <20250411091631.954228-1-kevin.brodsky@arm.com>
* Kevin Brodsky <kevin.brodsky@arm.com> wrote:
> Performance
> ===========
>
> Caveat: these numbers should be seen as a lower bound for the overhead
> of a real POE-based protection. The hardware checks added by POE are
> however not expected to incur significant extra overhead.
>
> +-------------------+----------------------------------+------------------+---------------+
> | Benchmark | Result Class | Without batching | With batching |
> +===================+==================================+==================+===============+
> | mmtests/kernbench | elsp-64 | 0.20% | 0.20% |
> | | syst-64 | 1.62% | 0.63% |
> | | user-64 | -0.04% | 0.05% |
> +-------------------+----------------------------------+------------------+---------------+
> | micromm/fork | fork: p:1 | (R) 225.56% | -0.07% |
> | | fork: p:512 | (R) 254.32% | 0.73% |
> +-------------------+----------------------------------+------------------+---------------+
> | micromm/munmap | munmap: p:1 | (R) 24.49% | 4.29% |
> | | munmap: p:512 | (R) 161.47% | (R) 6.06% |
> +-------------------+----------------------------------+------------------+---------------+
> | micromm/vmalloc | fix_size_alloc_test: p:1, h:0 | (R) 14.80% | (R) 11.85% |
> | | fix_size_alloc_test: p:4, h:0 | (R) 38.42% | (R) 10.47% |
> | | fix_size_alloc_test: p:16, h:0 | (R) 64.74% | (R) 6.41% |
> | | fix_size_alloc_test: p:64, h:0 | (R) 79.98% | (R) 3.24% |
> | | fix_size_alloc_test: p:256, h:0 | (R) 85.46% | (R) 2.77% |
> | | fix_size_alloc_test: p:16, h:1 | (R) 47.89% | 3.10% |
> | | fix_size_alloc_test: p:64, h:1 | (R) 62.43% | 3.36% |
> | | fix_size_alloc_test: p:256, h:1 | (R) 64.30% | (R) 2.68% |
> | | random_size_alloc_test: p:1, h:0 | (R) 74.94% | (R) 3.13% |
> | | vm_map_ram_test: p:1, h:0 | (R) 30.53% | (R) 26.20% |
> +-------------------+----------------------------------+------------------+---------------+
So I had to look 3 times to figure out what the numbers mean: they are
the extra overhead from this hardening feature, measured in system time
percentage, right?
So "4.29%" means there's a 4.29% slowdown on that particular workload
when the feature is enabled. Maybe add an explanation to the next iteration? :-)
Thanks,
Ingo
next prev parent reply other threads:[~2025-04-11 9:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 9:16 [RFC PATCH v4 00/18] pkeys-based page table hardening Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 01/18] mm: Introduce kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 02/18] set_memory: Introduce set_memory_pkey() stub Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 03/18] arm64: mm: Enable overlays for all EL1 indirect permissions Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 04/18] arm64: Introduce por_elx_set_pkey_perms() helper Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 05/18] arm64: Implement asm/kpkeys.h using POE Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 06/18] arm64: set_memory: Implement set_memory_pkey() Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 07/18] arm64: Reset POR_EL1 on exception entry Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 08/18] arm64: Context-switch POR_EL1 Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 09/18] arm64: Enable kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 10/18] mm: Introduce kernel_pgtables_set_pkey() Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 11/18] mm: Introduce kpkeys_hardened_pgtables Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 12/18] mm: Allow __pagetable_ctor() to fail Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 13/18] mm: Map page tables with privileged pkey Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 14/18] arm64: kpkeys: Support KPKEYS_LVL_PGTABLES Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 15/18] arm64: mm: Guard page table writes with kpkeys Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 16/18] arm64: Enable kpkeys_hardened_pgtables support Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 17/18] mm: Add basic tests for kpkeys_hardened_pgtables Kevin Brodsky
2025-04-11 9:16 ` [RFC PATCH v4 18/18] arm64: mm: Batch kpkeys level switches Kevin Brodsky
2025-04-11 9:21 ` Ingo Molnar [this message]
2025-04-11 12:37 ` [RFC PATCH v4 00/18] pkeys-based page table hardening Kevin Brodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_jfGlOEb4Bjl3vO@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=joey.gouly@arm.com \
--cc=kees@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=pierre.langlois@arm.com \
--cc=qperret@google.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).