From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0285FC47DAF for ; Mon, 22 Jan 2024 16:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=npE7OkB418b/cvH40TdmL0CqY4ofCD724tJBJFiYVDg=; b=pbM8A+NDa73wMS sicolCqL7CPxmOj4eR97VJeMUAWnm1b65b8kFxzq5dQJRCsIJTcNcEVRnmnCZ3XKVM1XqpXjCVz/z XQAaDd3IfXUXOQvQm3/D4/ekFCuXnSB4lJy/cA77mMO8fpIXK+CXp7K0DaNvinXxkO6zSxTebFAZF 6n74EELPIphJY5L1q74YaXYzp8mKU98Pe7+BRDDy+jIHroACQhqP2Oxq/Hvcpak6u0HBj8KxOXMzv rD1JSoBv31O1Ix4uj/XfTycTRdhjWz4Q5jq6jIvZcfN/ks7JWNw2mDROsBMb9D1obLZ6SBFmxG+Fj yCyPDaa6pAMnhXzP0vJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRx07-00Cul2-01; Mon, 22 Jan 2024 16:18:19 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRx04-00Cujd-2s for linux-arm-kernel@lists.infradead.org; Mon, 22 Jan 2024 16:18:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BDB62CE298C; Mon, 22 Jan 2024 16:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DF1EC433A6; Mon, 22 Jan 2024 16:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705940290; bh=WDAnCV9Ra1LfdfiCu5KUZtV9r+eTg+bc/y0G1AdYs68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RS+FCjUHhg+ZtvA25siHP9vJuHFDG9pNT0ZYWi9BoJg1/RjWftZzKK/17uqQ/Tpx8 WJVGnWUQXYyZ7pssaMJpxDdg0oAPCp3l/gD/yf9XD1Vj8ZTfm4Q7PTMBpDY3/5Ec9E UVMYUWswJfsZoai7e4TYHXtXrADib5wJRE0vcOGubW6v6HSQhey3/kX6+5SYFAmAv0 qwT+07n2gsqHjAZJCO6LfjPqdiD0cX7rbF/QU7IwILpFkEGhfvpkbhwCm/UnCRi1lQ H3qSb5vGJy4zachG7xZN2IIxxiJm5UIA6a5DNVRInn7d0Gaxv4JBIVMZbPbF8K1yU+ Gw05OJGYleqhQ== Date: Mon, 22 Jan 2024 17:18:04 +0100 From: Lorenzo Pieralisi To: linux-kernel@vger.kernel.org, Marc Zyngier Cc: Robin Murphy , Mark Rutland , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Fang Xiang , Robert Moore Subject: Re: [PATCH v4 3/3] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing Message-ID: References: <20230905104721.52199-1-lpieralisi@kernel.org> <20231227110038.55453-1-lpieralisi@kernel.org> <20231227110038.55453-4-lpieralisi@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231227110038.55453-4-lpieralisi@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_081817_116777_4B3B1F7E X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 27, 2023 at 12:00:38PM +0100, Lorenzo Pieralisi wrote: [...] > @@ -2380,6 +2385,10 @@ gic_acpi_parse_madt_gicc(union acpi_subtable_headers *header, > return -ENOMEM; > gic_request_region(gicc->gicr_base_address, size, "GICR"); > > + if (gic_acpi_non_coherent_flag(gicc->flags, > + ACPI_MADT_GICC_NON_COHERENT)) > + gic_data.rdists.flags |= RDIST_FLAGS_FORCE_NON_SHAREABLE; > + Quick question before reposting it. We run this function for every GICC entry, I didn't add a check to make sure all GICC entries have the same flag value, please let me know if that's OK. I don't think there is a point in keeping a live variable across calls to set the flag once for all either. Thanks, Lorenzo > gic_acpi_register_redist(gicc->gicr_base_address, redist_base); > return 0; > } > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 54189e0e5f41..a292f2bdb693 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -283,6 +283,9 @@ static inline bool invalid_phys_cpuid(phys_cpuid_t phys_id) > return phys_id == PHYS_CPUID_INVALID; > } > > + > +u8 __init acpi_get_madt_revision(void); > + > /* Validate the processor object's proc_id */ > bool acpi_duplicate_processor_id(int proc_id); > /* Processor _CTS control */ > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel