* [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer
[not found] <20240122184543.2501493-1-leitao@debian.org>
@ 2024-01-22 18:45 ` Breno Leitao
2024-01-22 19:31 ` Daniel Golle
2024-01-22 19:33 ` Andrew Lunn
2024-01-22 18:45 ` [PATCH net-next 20/22] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
1 sibling, 2 replies; 6+ messages in thread
From: Breno Leitao @ 2024-01-22 18:45 UTC (permalink / raw)
To: kuba, davem, abeni, edumazet, Ioana Ciornei, Andrew Lunn,
Heiner Kallweit, Russell King, Paolo Abeni, Alexander Couzens,
Daniel Golle, Matthias Brugger, AngeloGioacchino Del Regno,
Jose Abreu
Cc: dsahern, weiwan, open list:LYNX PCS MODULE, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/pcs/pcs-lynx.c | 1 +
drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
drivers/net/pcs/pcs-xpcs.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index dc3962b2aa6b..d51d09beaab3 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c
@@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
}
EXPORT_SYMBOL(lynx_pcs_destroy);
+MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
}
EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
index 31f0beba638a..9c020dd3c766 100644
--- a/drivers/net/pcs/pcs-xpcs.c
+++ b/drivers/net/pcs/pcs-xpcs.c
@@ -1456,4 +1456,5 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
}
EXPORT_SYMBOL_GPL(xpcs_create_mdiodev);
+MODULE_DESCRIPTION("Synopsys DesignWare XPCS helpers");
MODULE_LICENSE("GPL v2");
--
2.39.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next 20/22] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga
[not found] <20240122184543.2501493-1-leitao@debian.org>
2024-01-22 18:45 ` [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
@ 2024-01-22 18:45 ` Breno Leitao
1 sibling, 0 replies; 6+ messages in thread
From: Breno Leitao @ 2024-01-22 18:45 UTC (permalink / raw)
To: kuba, davem, abeni, edumazet, Alexandre Torgue, Jose Abreu,
Paolo Abeni, Maxime Coquelin
Cc: dsahern, weiwan, open list:STMMAC ETHERNET DRIVER,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE, open list
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the STMicro DWMAC for Altera SOCs.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index ba2ce776bd4d..68f85e4605cb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -585,4 +585,5 @@ static struct platform_driver socfpga_dwmac_driver = {
};
module_platform_driver(socfpga_dwmac_driver);
+MODULE_DESCRIPTION("Altera SOC DWMAC Specific Glue layer");
MODULE_LICENSE("GPL v2");
--
2.39.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer
2024-01-22 18:45 ` [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
@ 2024-01-22 19:31 ` Daniel Golle
2024-01-22 19:42 ` Breno Leitao
2024-01-22 19:33 ` Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Golle @ 2024-01-22 19:31 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, abeni, edumazet, Ioana Ciornei, Andrew Lunn,
Heiner Kallweit, Russell King, Paolo Abeni, Alexander Couzens,
Matthias Brugger, AngeloGioacchino Del Regno, Jose Abreu, dsahern,
weiwan, open list:LYNX PCS MODULE, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Hi Breno,
On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/net/pcs/pcs-lynx.c | 1 +
> drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> drivers/net/pcs/pcs-xpcs.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> index dc3962b2aa6b..d51d09beaab3 100644
> --- a/drivers/net/pcs/pcs-lynx.c
> +++ b/drivers/net/pcs/pcs-lynx.c
> @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> }
> EXPORT_SYMBOL(lynx_pcs_destroy);
>
> +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
Nah, pcs-lynx.c is used by various SoC vendors **other than MediaTek**
such as Freescale and STMicroelectronics.
Users of the pcs-lynx.c driver are
ethernet/stmicro/stmmac/dwmac-socfpga.c
ethernet/altera/altera_tse_main.c
ethernet/freescale/dpaa2/dpaa2-mac.c
ethernet/freescale/enetc/enetc_pf.c
ethernet/freescale/fman/fman_memac.c
dsa/ocelot/felix_vsc9959.c
dsa/ocelot/seville_vsc9953.c
> MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
> index 8501dd365279..4f63abe638c4 100644
> --- a/drivers/net/pcs/pcs-mtk-lynxi.c
> +++ b/drivers/net/pcs/pcs-mtk-lynxi.c
> @@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
> }
> EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
>
> +MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
Ack on this one.
> MODULE_LICENSE("GPL");
> diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
> index 31f0beba638a..9c020dd3c766 100644
> --- a/drivers/net/pcs/pcs-xpcs.c
> +++ b/drivers/net/pcs/pcs-xpcs.c
> @@ -1456,4 +1456,5 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
> }
> EXPORT_SYMBOL_GPL(xpcs_create_mdiodev);
>
> +MODULE_DESCRIPTION("Synopsys DesignWare XPCS helpers");
> MODULE_LICENSE("GPL v2");
> --
> 2.39.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer
2024-01-22 18:45 ` [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
2024-01-22 19:31 ` Daniel Golle
@ 2024-01-22 19:33 ` Andrew Lunn
2024-01-22 19:42 ` Breno Leitao
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2024-01-22 19:33 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, abeni, edumazet, Ioana Ciornei, Heiner Kallweit,
Russell King, Paolo Abeni, Alexander Couzens, Daniel Golle,
Matthias Brugger, AngeloGioacchino Del Regno, Jose Abreu, dsahern,
weiwan, open list:LYNX PCS MODULE, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.
That patch now does more than that.
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/net/pcs/pcs-lynx.c | 1 +
> drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> drivers/net/pcs/pcs-xpcs.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> index dc3962b2aa6b..d51d09beaab3 100644
> --- a/drivers/net/pcs/pcs-lynx.c
> +++ b/drivers/net/pcs/pcs-lynx.c
> @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> }
> EXPORT_SYMBOL(lynx_pcs_destroy);
>
> +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
pcs-lynx is for NXP hardware, not MediaTek.
Andrew
---
pw-bot: cr
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer
2024-01-22 19:31 ` Daniel Golle
@ 2024-01-22 19:42 ` Breno Leitao
0 siblings, 0 replies; 6+ messages in thread
From: Breno Leitao @ 2024-01-22 19:42 UTC (permalink / raw)
To: Daniel Golle
Cc: kuba, davem, abeni, edumazet, Ioana Ciornei, Andrew Lunn,
Heiner Kallweit, Russell King, Paolo Abeni, Alexander Couzens,
Matthias Brugger, AngeloGioacchino Del Regno, Jose Abreu, dsahern,
weiwan, open list:LYNX PCS MODULE, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Mon, Jan 22, 2024 at 07:31:18PM +0000, Daniel Golle wrote:
> Hi Breno,
>
> On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > drivers/net/pcs/pcs-lynx.c | 1 +
> > drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> > drivers/net/pcs/pcs-xpcs.c | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> > index dc3962b2aa6b..d51d09beaab3 100644
> > --- a/drivers/net/pcs/pcs-lynx.c
> > +++ b/drivers/net/pcs/pcs-lynx.c
> > @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> > }
> > EXPORT_SYMBOL(lynx_pcs_destroy);
> >
> > +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
>
> Nah, pcs-lynx.c is used by various SoC vendors **other than MediaTek**
> such as Freescale and STMicroelectronics.
>
> Users of the pcs-lynx.c driver are
> ethernet/stmicro/stmmac/dwmac-socfpga.c
> ethernet/altera/altera_tse_main.c
> ethernet/freescale/dpaa2/dpaa2-mac.c
> ethernet/freescale/enetc/enetc_pf.c
> ethernet/freescale/fman/fman_memac.c
> dsa/ocelot/felix_vsc9959.c
> dsa/ocelot/seville_vsc9953.c
Thanks. What about something as?
MODULE_DESCRIPTION("Lynx PCS MDIO helpers");
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer
2024-01-22 19:33 ` Andrew Lunn
@ 2024-01-22 19:42 ` Breno Leitao
0 siblings, 0 replies; 6+ messages in thread
From: Breno Leitao @ 2024-01-22 19:42 UTC (permalink / raw)
To: Andrew Lunn
Cc: kuba, davem, abeni, edumazet, Ioana Ciornei, Heiner Kallweit,
Russell King, Paolo Abeni, Alexander Couzens, Daniel Golle,
Matthias Brugger, AngeloGioacchino Del Regno, Jose Abreu, dsahern,
weiwan, open list:LYNX PCS MODULE, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Mon, Jan 22, 2024 at 08:33:31PM +0100, Andrew Lunn wrote:
> On Mon, Jan 22, 2024 at 10:45:24AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
>
> That patch now does more than that.
>
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > ---
> > drivers/net/pcs/pcs-lynx.c | 1 +
> > drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
> > drivers/net/pcs/pcs-xpcs.c | 1 +
> > 3 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> > index dc3962b2aa6b..d51d09beaab3 100644
> > --- a/drivers/net/pcs/pcs-lynx.c
> > +++ b/drivers/net/pcs/pcs-lynx.c
> > @@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
> > }
> > EXPORT_SYMBOL(lynx_pcs_destroy);
> >
> > +MODULE_DESCRIPTION("MediaTek SGMII library for Lynx PCS");
>
> pcs-lynx is for NXP hardware, not MediaTek.
Thanks. I will update!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-22 19:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240122184543.2501493-1-leitao@debian.org>
2024-01-22 18:45 ` [PATCH net-next 03/22] net: fill in MODULE_DESCRIPTION()s for PCS Layer Breno Leitao
2024-01-22 19:31 ` Daniel Golle
2024-01-22 19:42 ` Breno Leitao
2024-01-22 19:33 ` Andrew Lunn
2024-01-22 19:42 ` Breno Leitao
2024-01-22 18:45 ` [PATCH net-next 20/22] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).