Re: [PATCH] firmware: arm_scmi: Warn if domain frequency multiplier is 0 or rounded off

[Sudeep Holla <sudeep.holla@arm.com>]

On Fri, Jan 19, 2024 at 03:05:09PM +0100, Pierre Gondois wrote:
> Hello Sudeep,
> Thanks for the patch. Just to add a note, it means that the firmware must have
> freq and level values such as:
> - freq = K * level
> - K >= 1
> - K being an integer
>

Correct, if it helps for future references, I can add the info as a comment
in the code.

> If K is not an integer, the bigger K is, the lower the imprecision in the
> available frequencies is. Having imprecise frequency values did not impact
> the frequency changes when I tried it.

Agreed. But I don't want to make any assumption on the values to throw
this warning. We can silence it to debug in the future if it gets annoying
on some real systems where it doesn't matter much. I just want to keep
it to give f/w a change to correct/adjust it if they can.

>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>

Thanks.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel