From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA6D9C47DAF for ; Fri, 19 Jan 2024 14:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mJWKJ5ssRQfC+ocyWEuHsNctCKL1FMKfF5L+FivQaPI=; b=OXLVNg0uIWRbZE 5pek4/OLTMYDiAZjVUKbKoRc/ODncM7BGaJ5AkWF8OPf4UntxqcRkdA822C1g6+01v5bFbFjnAttg nDAifyorupeEN/0mDX32bphsg+Zv1+7tz172brBQzWEOvfGKaGrSf4van1SvJ/KUjQ3B2oPpn37dt WcsUkTyvHVL7YWdYTI35LoIfSMF5vvw77s4vfQxuUuy0WVtz7b+ZqzYGtEgJstEEKC3Ha1+WCo2Lz GTnq6z+W12v/CliqjK43Rko9vRovhP3ezuR8HJZUkXaQtY3wPL+WEE5aP9G9fppwV+BEzRtw/6+Gu 2eBtwjOrb0tsxCjtrUZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQq6B-005s6n-23; Fri, 19 Jan 2024 14:43:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQq67-005s60-2n for linux-arm-kernel@lists.infradead.org; Fri, 19 Jan 2024 14:43:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CFDB1042; Fri, 19 Jan 2024 06:44:34 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52CD73F73F; Fri, 19 Jan 2024 06:43:47 -0800 (PST) Date: Fri, 19 Jan 2024 14:43:44 +0000 From: Sudeep Holla To: Pierre Gondois Cc: linux-arm-kernel@lists.infradead.org, Sudeep Holla , Cristian Marussi Subject: Re: [PATCH] firmware: arm_scmi: Warn if domain frequency multiplier is 0 or rounded off Message-ID: References: <20240119111033.3011853-1-sudeep.holla@arm.com> <30b94dac-3c49-4bec-9803-2ff058f0fb0a@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <30b94dac-3c49-4bec-9803-2ff058f0fb0a@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_064356_013650_8EFE80FE X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 19, 2024 at 03:05:09PM +0100, Pierre Gondois wrote: > Hello Sudeep, > Thanks for the patch. Just to add a note, it means that the firmware must have > freq and level values such as: > - freq = K * level > - K >= 1 > - K being an integer > Correct, if it helps for future references, I can add the info as a comment in the code. > If K is not an integer, the bigger K is, the lower the imprecision in the > available frequencies is. Having imprecise frequency values did not impact > the frequency changes when I tried it. Agreed. But I don't want to make any assumption on the values to throw this warning. We can silence it to debug in the future if it gets annoying on some real systems where it doesn't matter much. I just want to keep it to give f/w a change to correct/adjust it if they can. > > Reviewed-by: Pierre Gondois > Thanks. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel