From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A4C7C48291 for ; Fri, 2 Feb 2024 20:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RFhgNhB0HIcRLJmudDjVi/MdH4l5eAjRYzczIrr5gjA=; b=v79owvYJwSWo8C peXBaOIlo3W5YMNjHApf+lGvBTE34OvHqR5OGWhPpDYCOvpoRowtyBOEx0TSbevzSsArs5CgvQJ9L ttP/1HrO1zho5tVd7qGCcxdfa3w2kBe/2ZtQ29z2JJW9LP5DEBrBlGllGT7FCUWq0GujShSXdnvK6 C8KtzD1RLwecomCUgBw3bq8Inx/nOrPMPH4TLV6x9J4QubaPspHIbp1PIfPWc9MDpl1KnZ0+1DbcQ oiCG7heCb/0SncZpO/pkF/J75HFKnTICHfnXdf6V2snuGtSr0fcItOUwbeyXmjf2oGkpRFzYl7YuP PT+9Z5J7VyCKz3Z8NtMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rW0SL-0000000DQ3Z-2mVx; Fri, 02 Feb 2024 20:48:13 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVyTg-0000000CwFT-1mrg for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 18:41:30 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d7354ba334so20870975ad.1 for ; Fri, 02 Feb 2024 10:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706899284; x=1707504084; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RN5ILJgfYC5Krqk3IcaE4UZm9MGXLWaA34ihsM5Im/Q=; b=c2eAzy6Pwptd6EU7ij18y1bIZgg5KSdzxWZyLFfzuyf32ZWix5Q0CbK0HocDprI6pM 0HpGOwxp9AW9MWmVbSpq9avxVuDPwuJCPE+86elD+u2GwE153hjiuPXs7lUBunJdS3tl YBGFDJZ3ahL7BUHAXRtDQFzbctgDjZvisySz6oELLC65t+Wx5v1MJ9BnuoCHwQ5i5SWq Lgu/waN+4Iu8WFPsxYAHeBlW4gz3tyw6PqOyz9ifFqO6SB9E7KFVldsOwSr7oxd5l3k8 dSBcQWLPUI7LSwHSpmhtUBQYf4OJGzfxD5Qn5bD6cSJukVsIHXOy5SNSvLZaZe0ixAnF quRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706899284; x=1707504084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RN5ILJgfYC5Krqk3IcaE4UZm9MGXLWaA34ihsM5Im/Q=; b=JsT4xUaosS8Hx3/RusIt4TjUl8xdD/3rkxT2xk0XJiUCJV1z6BtKrZxSKaGqvV9sSC D6/NhSUFtLXRrvAYBoebxj1qiX1LfbjkFXq4YhIpObkONKSFtKRooTBsRo7z53BzGPsL HkNvHvqFrrdjl3yxDrG7Wt4DX+lMrPeEZ41uSF4g2rjN2cHTp/C1GXHysOYTnhXxvnKl cscNg+gmSpb6XuYA1gYPyv7qqAib24LEtsBogma14pc7QmGdpIwclxFEZB2GhPr379zh dZIVKnAAXWayFt6BYRvpnFAHAxZZtVlnYFHgHpiN74UScfV6HLOxRTr1uUoTgDpcoFeD xRqQ== X-Gm-Message-State: AOJu0YyA4cSu4EimPUtbDhHOheBGYLA35DtdNM9xigYN1XY3scwIskFo 5enlY9J4NPptzTaZYne6mBZhMJJWA4X+EvgA3Zov5VY4OnjDotHzjgTiRbG3Pg4= X-Google-Smtp-Source: AGHT+IHI5+6GlfKqM/eae+kgC9KkWpCXw9/h0VW61qBwkA94b7R7Eqhzy6DQXTdDMRIc6K3dL9c31Q== X-Received: by 2002:a17:902:f68a:b0:1d8:fb17:a1f2 with SMTP id l10-20020a170902f68a00b001d8fb17a1f2mr12586111plg.34.1706899283798; Fri, 02 Feb 2024 10:41:23 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUVnzEB2v7TbbKqpsgt/c7PICyiD/6Uwyu7EeUzAU9R5HwoFu9fPYvE5IW2uIB8M0v0SEuFwksh87A25N1krBxkWlT9zzLQD7tiLE0ZE976/bkLAUbFdl/0tprp4Pt2UF1lR+H9syCgOmtkFUNw2iF4AHjeles10LJMnFQnAkbAa8xbpQ/Q1BTzOC/Bnx35JHOiNS+liqYwF2w3FLEHpUZbDK4j1RbQJeiSIVIS/QRZUFBnOz3Wv+GP4OcI1byvNM8y5R1Ck3BpP1uBs8ElGgi6bCjlWfuXMAoDdxzgKECoGJ/jv2mFd6JmoQHRuiwEyyFeo7NjhjGzjJOH+4tkUPhBS4tNgHODfZ2s7SDlRiyMtrTCFm/mj0ROAa19sKf1DOLtW/zuiCGrwXXBqhQneTNyY7W6fd7n9qW84P9T2vngmuXvkGFTep469o0zyWuwBPrMJI7dU+cJ25JTGKBc59q/ohjeqayAzp3n+t+Xci91MT0mCIDrVDX1GFOf9/z/w7cf+zecrUq+b8IkqBhoFg== Received: from p14s ([2604:3d09:148c:c800:9462:f236:7267:e14e]) by smtp.gmail.com with ESMTPSA id jh21-20020a170903329500b001d936a7bd46sm1902639plb.271.2024.02.02.10.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 10:41:22 -0800 (PST) Date: Fri, 2 Feb 2024 11:41:19 -0700 From: Mathieu Poirier To: Andrew Davis Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Konrad Dybcio , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 9/9] remoteproc: stm32: Use devm_rproc_alloc() helper Message-ID: References: <20240123184632.725054-1-afd@ti.com> <20240123184632.725054-9-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240123184632.725054-9-afd@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_104128_996996_70C93700 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 23, 2024 at 12:46:32PM -0600, Andrew Davis wrote: > Use the device lifecycle managed allocation function. This helps prevent > mistakes like freeing out of order in cleanup functions and forgetting to > free on error paths. > > Signed-off-by: Andrew Davis > --- > drivers/remoteproc/stm32_rproc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 4f469f0bcf8b2..fed0866de1819 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -843,7 +843,7 @@ static int stm32_rproc_probe(struct platform_device *pdev) > if (ret) > return ret; > > - rproc = rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > + rproc = devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > if (!rproc) > return -ENOMEM; > > @@ -897,7 +897,6 @@ static int stm32_rproc_probe(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > - rproc_free(rproc); > return ret; > } > > @@ -918,7 +917,6 @@ static void stm32_rproc_remove(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > - rproc_free(rproc); > } I have applied patches 1, 2, 8 and 9 of this set. Bjorn handles the QCOM peripherals and will take care of the remaining ones. Thanks, Mathieu > > static int stm32_rproc_suspend(struct device *dev) > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel