From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08866C4828F for ; Sat, 3 Feb 2024 13:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XEON3mizkPvstZZE2wqNjCg/mLkXco7MPwoKRgOlzLY=; b=P2YqaJN6jGivkB 3/QcqVTnALz5VPVDNVts7PiFrPx/j5dXajCUTePMaERTSwBy3xzPD4hLbWuM+kK/sf0ZaX70MJyqo AboAl1dl09EqiturMU8UikbiW6a5QES1gX/WQFH7QRyxHeolZAYAD8giGiYDd5362xR4XbHPj7r+9 mAknTAJexHh1t/AyQqEMd9xukR6UFYbPyB/LD6vCYg4+BzJyXlABAHo7dN0ngznMlWuPRRFMzhrmI euQNB9JGwNrESh5drG+BWhWLgSoZzHMeMd+s/8FE1GIO2XFzDQv3FNYjAEmK9gehT8sb7eI1p/8Rl 8ze8egqmXTj1CCfHXZ3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWFv5-0000000GWIj-1vSZ; Sat, 03 Feb 2024 13:18:55 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWFv2-0000000GWHu-1Uf8 for linux-arm-kernel@lists.infradead.org; Sat, 03 Feb 2024 13:18:53 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-33b2ee2d1d6so230727f8f.1 for ; Sat, 03 Feb 2024 05:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706966327; x=1707571127; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DWfHGvyLS9Vdj8BUW4SV7fQsQn/7GRDVDPI4v8u0+as=; b=lWfAt66XBRbo4shZmVNVWIfyIV2aruk/WnxDGSiLkxBE8H9erbYd/UI6vk1WuHr9H0 pvcwWTI9FyhkPck0AKDET6Ot1Wmn9LHARzEZ9tOaoIB3rpMNG5+o8n6489V9wv/BefdV cfAhUu4B9sywmqoy/gDe95PhEEHQfnkGSAIUeY7QiDHxMcdcD0BwIlHApU8zQcNZuf89 IQaa94RZMlcK4WpsdqgFiSeLt/h1No1p9aXW+e7kshb0gQ++pkDGuaOs48kmG2mWUNP7 GKuyzpru+jyNeHOFwjQUkhHIH6C3Kn2/tipw9xzmEuRVn6pWs8zAE6TpKEX97bn51ylN 1gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706966327; x=1707571127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DWfHGvyLS9Vdj8BUW4SV7fQsQn/7GRDVDPI4v8u0+as=; b=nwI7Yxhv1bSPMxHgoTvoQKqOPsDzZNizNoGCD6GkmOA4ulbI8FYPuye/RIILC4uCiD nt6cJoRbbqKoTfeyRXdtTWe3afWjdEZ6VQyr5D0Z4KgB2bARBEfnE5FSnPAP5a2pEQtr l2r7JBBkSPflanf6k1T55M1cAEaRNci/jFq6Cz7XF4rScg+CgF86GMhtjU7rr3d/cUYB 3J0mmswHjg3fAdwT4eQdt72ro4zA/xkNfgQszLWBFpsWaJ91HShheFQSWIojbZYu7UUb Ph55xaMRxWcd8WOPY3XG/Dq7ypgYzolNVrYHxurjo9kcaNXXcGaz8lca46Fc5G3/mXFm WCIA== X-Gm-Message-State: AOJu0YxJ5yD9YXhH6o4ddVD95tfrKaiBSyS5M4X2rDhaEtjuH948Dpkb fUUqeleFiFuqHihsbU+vKnvVPt3Vz75B5mOxMriApL2rbLlldk8U+xOhk0p4YX0= X-Google-Smtp-Source: AGHT+IHbhiTWLBl6YahL3JztbgGYK6YB780/wlpqRr77AzqPbB4zWyVEyfXchL5cgCYGdII6nMrG2w== X-Received: by 2002:adf:fd45:0:b0:33a:e56f:1ddb with SMTP id h5-20020adffd45000000b0033ae56f1ddbmr3178428wrs.46.1706966326943; Sat, 03 Feb 2024 05:18:46 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX8boruPRGCZlECRQFcP7XDgA7uXo0XyWVGVmXTuh79Q8jTdX7LTleA+Kmy8ecCa7gYnyawFJUfOGf7YK4k0mXE9M0sARfiyGnPPXQplpXIfF3PumEU7SNPYCLOnpvAiDwylGD2nvgqJA7odDPvgNY2XcYbigJx7JsdXGMo6/fNe7fmEI92Qn/M3FEBfMHgoMMEQK4gkSDxXz213p4Jf7WGlwY2aJWz4elfy+2MYDVb+vLDpira3eEBq7dgeMDsXQClnsaCgJEvd668GohgqIsWKU6zshmBGvOLTNxAsCa+ONdEEu71kfrwfinkI4ZoT3hnE0GeOim2oXmtYDs+B3mNYMyz0w57NkRwKC9CvyWh77yFKFdXYhj99/ZIU4Mnb6fT4r8H3Gr8Wm/TTzh1VY9MM1W+lZIAstMUREHZfOWiMrLDjv9ILLWxdyZcs3lL1sbRIaG3f/nv4V3aweMSBgXb4ksqXuu82PUIU8StcD8oEqPaSGVopkrptkmFtuO5wE7SCsjNzOu4aLpYMzsiSX+FM7gZCLfV6GSILppQhIvkJWiYIFHJ8OkW/+JJ1Fy9zEk= Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id s2-20020a056402164200b0055f2af9b01bsm1729280edx.17.2024.02.03.05.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 05:18:46 -0800 (PST) Date: Sat, 3 Feb 2024 14:18:43 +0100 From: Jiri Pirko To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , Serge Semin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net] net: stmmac: xgmac: fix a typo of register name in DPP safety handling Message-ID: References: <20240203053133.1129236-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240203053133.1129236-1-0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240203_051852_418140_967472F0 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sat, Feb 03, 2024 at 06:31:33AM CET, 0x1207@gmail.com wrote: >DDPP is copied from Synopsys Data book: > >DDPP: Disable Data path Parity Protection. > When it is 0x0, Data path Parity Protection is enabled. > When it is 0x1, Data path Parity Protection is disabled. > >The macro name should be XGMAC_DPP_DISABLE. > >Fixes: 46eba193d04f ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") >Signed-off-by: Furong Xu <0x1207@gmail.com> Looks okay, but this is net-next material. >--- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >index 5c67a3f89f08..6a2c7d22df1e 100644 >--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h >@@ -304,7 +304,7 @@ > #define XGMAC_TXCEIE BIT(0) > #define XGMAC_MTL_ECC_INT_STATUS 0x000010cc > #define XGMAC_MTL_DPP_CONTROL 0x000010e0 >-#define XGMAC_DDPP_DISABLE BIT(0) >+#define XGMAC_DPP_DISABLE BIT(0) > #define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x))) > #define XGMAC_TQS GENMASK(25, 16) > #define XGMAC_TQS_SHIFT 16 >diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >index 04d7c4dc2e35..323c57f03c93 100644 >--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c >@@ -928,7 +928,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp, > /* 5. Enable Data Path Parity Protection */ > value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL); > /* already enabled by default, explicit enable it again */ >- value &= ~XGMAC_DDPP_DISABLE; >+ value &= ~XGMAC_DPP_DISABLE; > writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL); > > return 0; >-- >2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel