From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5331EC4828D for ; Sat, 3 Feb 2024 17:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/J/64x9k2a9GLRqwUL7vhFcMZ0mmIwH/AGnQaNScCI=; b=fK7nyJHBUSme44 HbTzu25aoZnR/DncjWHB454w08jkSqa3hlwGZcqFIWUn1w3A4Ljyf7s1SP2seVathpOhFri4uFe0s d4QiBdJqOlB6uOkVdh/JCQTXhfubmu0L46JHSbaeFTXzUqBXca9nZiEJ//PtdxGOroNnHSu648b2g nFQJUzZ3vySfXBdEFAAZHiXWcl6aWeQk33+Bn5MzZf0oj4mKy79VLAkbVLW4GTt9B6g6cBDvW29+5 t1JtJHL5EOvOs/ckapi9o8LUTQ31SVhjztcvEk2h6NR3ztdmtx2/I4xhmyXQTt/+5WdyRJC4cJtRB KnrclEmr+Zw9smS5Nk0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWJkZ-0000000Gv9e-2X5w; Sat, 03 Feb 2024 17:24:19 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWJkW-0000000Gv8N-1OQv for linux-arm-kernel@lists.infradead.org; Sat, 03 Feb 2024 17:24:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5o3Xvx1PmTQzS2Sezw6yImp07a9AspKSvTzW4LzSUPU=; b=NJnGev0HwXBjm/0WS37JZ4cuBm Gvh1GJ4twuun3xWKFsJLhOYQ/Hq4Uj9g2V8GiMwI1/NcbKgdcZOFdW7UNdiHSmmnXM5JZCDWtxOR0 +KoFcfJlpeFGeqLkMwqMqt21odlH/5gml3HM0e/8ENA7HVa5liRzD14EhJkDsCqTMbrd+V80PZOF6 pVO5n4u6rNbPEXOXzhxOuYRcEtbuRtIohSsUtPx7Mfmy9wPrqc+BgZQNLO2e9Qa7Tx/l67+mK2POv HXm6dmd4lJlIbO8NOu6Ae40IP1daeOYXTYZ6ZmTaAOoUSnroAx3wNP0mfy2QAKhEBMabyjgOJBoqc wKxuca5A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59486) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rWJkH-0007Hw-13; Sat, 03 Feb 2024 17:24:01 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rWJkC-0000zS-LJ; Sat, 03 Feb 2024 17:23:56 +0000 Date: Sat, 3 Feb 2024 17:23:56 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Heiner Kallweit , Christian Marangi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: phy: constify phydev->drv Message-ID: References: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240203_092416_391474_0544583F X-CRM114-Status: GOOD ( 12.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 03, 2024 at 05:56:19PM +0100, Andrew Lunn wrote: > On Fri, Feb 02, 2024 at 05:41:45PM +0000, Russell King (Oracle) wrote: > > Device driver structures are shared between all devices that they > > match, and thus nothing should never write to the device driver > > nothing should never ??? > > I guess the never should be ever? Yes, thanks for spotting that. > > struct gmii2rgmii { > > struct phy_device *phy_dev; > > - struct phy_driver *phy_drv; > > + const struct phy_driver *phy_drv; > > struct phy_driver conv_phy_drv; > > struct mdio_device *mdio; > > }; > > Did you build testing include xilinx_gmii2rgmii.c ? It does funky > things with phy_driver structures. CONFIG_XILINX_GMII2RGMII=m So yes. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel