From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C247EC48260 for ; Fri, 26 Jan 2024 13:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ckCKSl86r533iX9Yl8OkkoiMRA0ukj3/cX+cEb+0mE=; b=vOpTdT3eEzDkrr szcNL3ylkLY0OmaYmG/aqvit6LVRR7qMUSGuGg4kW3Jk1i2aEsfOpl1/pjfz71bsMl3Rvivl9Mcs0 lkotUfXFh1lnh2Pdb34t7hReROCZJT5qjOHRHEMMvUWuioGWP2rSKxZAE4dHWRwiPoUJVAatw0Uk4 4l8MgmNPs4diTht751bnCh3PrW/KsmbF81fx+pFdpuNq0TMp1z9dOuv8FnpuBVs2TKBuAvfDYxO8H tTuqJTH3cd8CibcROAnW6KLjyWxdkqvSDbYRqzKdCtsSUvppUgueMxhH1rYgPsyRhUGCpZFQVNgAU gn9gAn0T6B7AlACJQm6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTLop-000000049jz-1F27; Fri, 26 Jan 2024 13:00:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTLoh-000000049fi-2CM2 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jan 2024 13:00:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E86F01FB; Fri, 26 Jan 2024 05:00:59 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.47.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D79BF3F73F; Fri, 26 Jan 2024 05:00:13 -0800 (PST) Date: Fri, 26 Jan 2024 12:59:55 +0000 From: Mark Rutland To: Nathan Chancellor Cc: akpm@linux-foundation.org, masahiroy@kernel.org, nicolas@fjasle.eu, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/11] arm64: Kconfig: Clean up tautological LLVM version checks Message-ID: References: <20240125-bump-min-llvm-ver-to-13-0-1-v1-0-f5ff9bda41c5@kernel.org> <20240125-bump-min-llvm-ver-to-13-0-1-v1-5-f5ff9bda41c5@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240125-bump-min-llvm-ver-to-13-0-1-v1-5-f5ff9bda41c5@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_050019_633943_1986D60A X-CRM114-Status: GOOD ( 20.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 25, 2024 at 03:55:11PM -0700, Nathan Chancellor wrote: > Now that the minimum supported version of LLVM for building the kernel > has been bumped to 13.0.1, several conditions become tautologies, as > they will always be true because the build will fail during the > configuration stage for older LLVM versions. Drop them, as they are > unnecessary. > > Signed-off-by: Nathan Chancellor > --- > Cc: catalin.marinas@arm.com > Cc: will@kernel.org > Cc: mark.rutland@arm.com > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/Kconfig | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5a8acca4dbf4..cb34e7d780c0 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -383,7 +383,7 @@ config BUILTIN_RETURN_ADDRESS_STRIPS_PAC > bool > # Clang's __builtin_return_adddress() strips the PAC since 12.0.0 > # https://github.com/llvm/llvm-project/commit/2a96f47c5ffca84cd774ad402cacd137f4bf45e2 > - default y if CC_IS_CLANG && (CLANG_VERSION >= 120000) > + default y if CC_IS_CLANG > # GCC's __builtin_return_address() strips the PAC since 11.1.0, > # and this was backported to 10.2.0, 9.4.0, 8.5.0, but not earlier > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94891 > @@ -1387,7 +1387,6 @@ choice > > config CPU_BIG_ENDIAN > bool "Build big-endian kernel" > - depends on !LD_IS_LLD || LLD_VERSION >= 130000 > # https://github.com/llvm/llvm-project/commit/1379b150991f70a5782e9a143c2ba5308da1161c We can delete the URL here, since that was just to describe why this depended upon LLVM 13+; it's weird for it to sit here on its own. The URL above for __builtin_return_address() can stay or go; it may as well stay since we have the comment aboout LLvm 12+ above it. With that: Acked-by: Mark Rutland Mark. > depends on AS_IS_GNU || AS_VERSION >= 150000 > help > @@ -2018,8 +2017,6 @@ config ARM64_BTI_KERNEL > depends on !CC_IS_GCC || GCC_VERSION >= 100100 > # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106671 > depends on !CC_IS_GCC > - # https://github.com/llvm/llvm-project/commit/a88c722e687e6780dcd6a58718350dc76fcc4cc9 > - depends on !CC_IS_CLANG || CLANG_VERSION >= 120000 > depends on (!FUNCTION_GRAPH_TRACER || DYNAMIC_FTRACE_WITH_ARGS) > help > Build the kernel with Branch Target Identification annotations > > -- > 2.43.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel