From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B03C2C47422 for ; Mon, 29 Jan 2024 08:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ODkaJl2BtCIKwkayJ/aHolW0WbPEYSh9qS3FUX9Xqj0=; b=2atobvawfi19uP RkKM5kviXA5/1WAIK+Hq9wOpbRtBICk0V89zEco/qRbfPDzJ48csaW2xZxVCYP9E4EiBuItHTqVQk Erge4Gig//QXLt/U2vLLd3N0ltYn09vL2QFlr9heDe29wqHrhrRHus1aPlN8ugokCoZp3xtb8SRbO LSoh1Q1ZWRC2jlM7z3GqI4HGrzeUZZ6iwufqCm0C7Mo8bjMUovN8lKOlw2wHYGceh4nJ6f+hepWqK 11aTnSTxSQN8XP5xSb9CWUcBR6iAy/46KxZl5kHr2OPKFPm51Nxv7ybIv1XxzQmJviuR4Yumu3exV qKTakXWhRE1cc+5LNGsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUNHE-0000000BryW-2sHL; Mon, 29 Jan 2024 08:46:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUNHB-0000000BrxS-3ybJ for linux-arm-kernel@lists.infradead.org; Mon, 29 Jan 2024 08:45:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D268361EDA; Mon, 29 Jan 2024 08:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F08EBC433F1; Mon, 29 Jan 2024 08:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706517956; bh=h+w67Av4j/ZtT+FxipGw15DHMifwDMi67xcC7YTpOW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JaW41u9q07rH9eLkLikVQ03Zi2vIlErkRPCy26x/LqPtHUw3clevjCrngCsngOnIa 5GA9xPvgWjjwP9g110+WAM6mGjJiY6rHTuAH/tBaf65VkKsR6P5FM4N9mohyvJs1EP Wu0jzL7St53u0V+mxvSwBvnMZVMb0pPKidIpwARr66BAoDilG+A2ogtZWjv1nhyoqD Vb8KE4l3o4BdzL5UaLKMJ1iDVUX0TBXbECCf6keFcP6eU0Xpj+3SJQYyUN5kFRv/AI fgBkOsUW8Vdp9ThjMc81YMKT2lX3hQ1YICJqFmwh1CVzvLBwbjA5cGO8OiYE8EhTyP 6I8opYtF3UM0g== Date: Mon, 29 Jan 2024 09:45:52 +0100 From: Lorenzo Pieralisi To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , yuzenghui@huawei.com, stable@vger.kernel.org Subject: Re: [PATCH] irqchip/gic-v3-its: Restore quirk probing for ACPI-based systems Message-ID: References: <20240127110702.4068488-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240127110702.4068488-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_004558_076680_487C85D2 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 27, 2024 at 11:07:02AM +0000, Marc Zyngier wrote: > While refactoring the way the ITSs are probed, the handling of > quirks applicable to ACPI-based platforms was lost. As a result, > systems such as HIP07 lose their GICv4 functionnality, and some Just noticed: s/functionnality/functionality > other may even fail to boot, unless they are configured to boot > with DT. > > Move the enabling of quirks into its_probe_one(), making it > common to all firmware implementations. > > Fixes: 9585a495ac93 ("irqchip/gic-v3-its: Split allocation from initialisation of its_node") > Signed-off-by: Marc Zyngier > Cc: stable@vger.kernel.org > --- > drivers/irqchip/irq-gic-v3-its.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I obviously tested it with ACPI with platforms not neededing its quirks, apologies. Reviewed-by: Lorenzo Pieralisi > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index fec1b58470df..250b4562f308 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -5091,6 +5091,8 @@ static int __init its_probe_one(struct its_node *its) > u32 ctlr; > int err; > > + its_enable_quirks(its); > + > if (is_v4(its)) { > if (!(its->typer & GITS_TYPER_VMOVP)) { > err = its_compute_its_list_map(its); > @@ -5442,7 +5444,6 @@ static int __init its_of_probe(struct device_node *node) > if (!its) > return -ENOMEM; > > - its_enable_quirks(its); > err = its_probe_one(its); > if (err) { > its_node_destroy(its); > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel