From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CF81C46CD2 for ; Tue, 30 Jan 2024 06:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4tZfpHThuWeXNpWXBcjMDSle5Ef62UUgEVz8rJIZmRM=; b=oTopd9YBCxPzGV Hgt0O3jgc9fkinJFabIem0JSh1vWwdH7Kq3yha2AZCqsH1E3fYdmfQVE+paClKaA6n9INqy37/MCO +y3BxFmfkaaXLNfs5dbKsPXEyLmFU7CFIbLifBTXrzq+Yo5P81vBSHdGlqj2/gAC9rpLx/QkhyGy1 KOXr/ecJxLs3NrSGYk8Gt4LOh3TI6U5XaNcUcPj0hG47BSFHXwBR8O5loxtVypLFcvdMtV1buJlaQ qAmJfev4whrEEuG/ja7OxYS8UOZGxAoz+rI3S7ZjHJM0Fx0d8T1cTHBANBPtQ+BSgFJGvIfElGEZ/ kF/alHxP3i7Nsvwp9maw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUhsY-0000000FSID-1gSV; Tue, 30 Jan 2024 06:45:54 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUhsU-0000000FSER-1Dwx for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 06:45:52 +0000 Received: from gaggiata.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id B59D8207BA; Tue, 30 Jan 2024 07:45:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1706597141; bh=FxsvfETjaPEQI8snXPU1qv7kZWitYTiHpzdkfTm0vnI=; h=Received:From:To:Subject; b=lRP5wqfhX9V/IqOzcCJ7+HtnietOccMFfiAIbBFa/UElj29ZEI+8smoeqU6R7tM3w FGzKZdVMT5lpXY8AnaBFRKMZQi++JlVvMCbwpUsvOfYYtROUTpTCYLiKNLxo66mee8 T+vdFoV2jKC7E6JhGnWabpATY3NzaHWziN+x8qhE/uUCtXAFQAK1Z7+eOwIVUMTQUm IfkMWt9qtooHt26Ac+ilqUJLQiOUpSYqYhQrnJUeYhRcwkv3rzLzr/yix4l49yEkSV sbrsG7Qp3cndkyCUZer8lmKurlubpf66tbrkrNVU2qtWHSsyKOVY/MWMo1ffvMh40n JWOdoZatFQumA== Received: by gaggiata.pivistrello.it (Postfix, from userid 1000) id C56CB7F9A0; Tue, 30 Jan 2024 07:45:23 +0100 (CET) Date: Tue, 30 Jan 2024 07:45:23 +0100 From: Francesco Dolcini To: Martin Kaiser Cc: Francesco Dolcini , Shawn Guo , Linus Walleij , Bartosz Golaszewski , Peng Fan , Andrew Lunn , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] gpio: vf610: allow disabling the vf610 driver Message-ID: References: <20240124205900.14791-1-martin@kaiser.cx> <20240124205900.14791-2-martin@kaiser.cx> <20240126122719.GA13659@francesco-nb> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_224551_379801_4361DFD6 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 29, 2024 at 10:26:16PM +0100, Martin Kaiser wrote: > Thus wrote Francesco Dolcini (francesco@dolcini.it): > > > On Wed, Jan 24, 2024 at 09:58:57PM +0100, Martin Kaiser wrote: > > > The vf610 gpio driver is enabled by default for all i.MX machines, > > > without any option to disable it in a board-specific config file. > > > > Most i.MX chipsets have no hardware for this driver. Change the default > > > to enable GPIO_VF610 for SOC_VF610 and disable it otherwise. > > > > Add a text description after the bool type, this makes the driver > > > selectable by make config etc. > > > > Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610") > > > Signed-off-by: Martin Kaiser > > > --- > > > > config GPIO_VF610 > > > - def_bool y > > > + bool "VF610 GPIO support" > > > + default y if SOC_VF610 > > > any reason for having this default y for SOC_VF610, but not for the > > other SOC that uses the same variant (i.MX7ULP, ... ?). > > Ok, it's probably not as consistent as it could be. ... > Does this make sense? sounds fair to me. Francesco > > Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel