From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DBAEC46CD2 for ; Tue, 30 Jan 2024 10:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EPVawOAzpELSLFwcV5tY9R855DZDRy3ZdZFKLvn3I74=; b=OLgFitCKFPctIE Rfny7bdfaoE7EzgeCJBOMeLT8VpFjY1LEUwc2tkqk4Jy3KsnXcW2aQpCIVIVc0UuAetmPBOr3+5u9 FpcemkRz9I0eQbV6ZlRnyXUo86saG0FkbZ1eBAeCtzDYfUHC7FNeqCsum1AJktxxLsZgUOnQnnIC5 20m+kh2NOiNBHlxXM3slml9L/gMWPX6T5S6U4XH8OAzICrn9sfYNy5na3LLX9gCS5cmm8DJEbbtWh MTnhJnwh/83TmSBhXYu6k0qfWI6ytgOVFziWoaFmZ7PuuRAi6BoMyXK0Pivym9UpsVsKFkiyWCFr3 7xD8QMj3WVtuajAs3eQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUlRn-0000000GC66-3zhg; Tue, 30 Jan 2024 10:34:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUlRl-0000000GC5c-0xap for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 10:34:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43DEFDA7; Tue, 30 Jan 2024 02:35:10 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.48.92]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2453D3F5A1; Tue, 30 Jan 2024 02:34:25 -0800 (PST) Date: Tue, 30 Jan 2024 10:34:22 +0000 From: Mark Rutland To: Kemeng Shi Cc: catalin.marinas@arm.com, will@kernel.org, revest@chromium.org, rostedt@goodmis.org, arnd@arndb.de, pengdonglin@sangfor.com.cn, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: make member of struct pt_regs and it's offset macro in the same order Message-ID: References: <20240130175504.106364-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240130175504.106364-1-shikemeng@huaweicloud.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_023429_337646_D86AD106 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 01:55:04AM +0800, Kemeng Shi wrote: > In struct pt_regs, member pstate is after member pc. Move offset macro > of pstate after offset macro of pc to improve readability a little. > > Signed-off-by: Kemeng Shi I think this makes sense as a trivial cleanup, so FWIW: Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/asm-offsets.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c > index 5ff1942b04fc..865ba901c233 100644 > --- a/arch/arm64/kernel/asm-offsets.c > +++ b/arch/arm64/kernel/asm-offsets.c > @@ -75,8 +75,8 @@ int main(void) > DEFINE(S_FP, offsetof(struct pt_regs, regs[29])); > DEFINE(S_LR, offsetof(struct pt_regs, regs[30])); > DEFINE(S_SP, offsetof(struct pt_regs, sp)); > - DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate)); > DEFINE(S_PC, offsetof(struct pt_regs, pc)); > + DEFINE(S_PSTATE, offsetof(struct pt_regs, pstate)); > DEFINE(S_SYSCALLNO, offsetof(struct pt_regs, syscallno)); > DEFINE(S_SDEI_TTBR1, offsetof(struct pt_regs, sdei_ttbr1)); > DEFINE(S_PMR_SAVE, offsetof(struct pt_regs, pmr_save)); > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel