From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F289DC46CD2 for ; Tue, 30 Jan 2024 11:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WI4G0UWdPFjgRgPfGY2tuX8QGexwO9rRG/R4CUZNvF8=; b=o7pOau4i1t4otq jekgZi+X7cFU5CezDDGLYVBCCkkfRA2rswIxK/o0J4glRU+oNSNY6qhTPW9HPPjCHJDkEWjaW2ftt xvPQMfQHN0xHA+pjaMU9oN0P3C2GojVNk3b/5zSrAHoYjEuTHYoQbIi9C8NkPBRiDyu1tA6aoG1ns nP9YQJla2K1K7jcaRGjIeNz8GUtb6sio1hsSUH0URj3t3mTaL4vDlphPd9iTdT702i35ajTnt5zDk wwXgDONQZQBmIgWk3CsqS555RX/GtmAWip4PwmPSTXyX9+Z2N0XDy5CQsvt+MqaPkWHSQjFcA3fb5 1/aqUQZAzPdP8chCpVSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmjd-0000000GZqh-3UKD; Tue, 30 Jan 2024 11:57:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmjQ-0000000GZlL-08NY for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 11:56:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37B73DA7; Tue, 30 Jan 2024 03:57:27 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B37A3F762; Tue, 30 Jan 2024 03:56:37 -0800 (PST) Date: Tue, 30 Jan 2024 11:56:31 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 01/35] mm: page_alloc: Add gfp_flags parameter to arch_alloc_page() Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-2-alexandru.elisei@arm.com> <3fbfb5fc-83a4-49da-ba75-9b671ffe0569@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3fbfb5fc-83a4-49da-ba75-9b671ffe0569@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_035648_144648_535A0826 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Jan 30, 2024 at 09:56:10AM +0530, Anshuman Khandual wrote: > > > On 1/29/24 17:11, Alexandru Elisei wrote: > > Hi, > > > > On Mon, Jan 29, 2024 at 11:18:59AM +0530, Anshuman Khandual wrote: > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> Extend the usefulness of arch_alloc_page() by adding the gfp_flags > >>> parameter. > >> Although the change here is harmless in itself, it will definitely benefit > >> from some additional context explaining the rationale, taking into account > >> why-how arch_alloc_page() got added particularly for s390 platform and how > >> it's going to be used in the present proposal. > > arm64 will use it to reserve tag storage if the caller requested a tagged > > page. Right now that means that __GFP_ZEROTAGS is set in the gfp mask, but > > I'll rename it to __GFP_TAGGED in patch #18 ("arm64: mte: Rename > > __GFP_ZEROTAGS to __GFP_TAGGED") [1]. > > > > [1] https://lore.kernel.org/lkml/20240125164256.4147-19-alexandru.elisei@arm.com/ > > Makes sense, but please do update the commit message explaining how > new gfp mask argument will be used to detect tagged page allocation > requests, further requiring tag storage allocation. Will do, thanks! Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel