From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F94EC46CD2 for ; Tue, 30 Jan 2024 11:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cnjzZ/ZxHqW8wJ34Eqji0uVIXCzSnZvwsrFc1mTDDfY=; b=WsftVNt+JsBjS/ uA7SAL6e7DtBG+wVu6s2NuekLt6udfFvQLrVVtqZ7cjU829LWG6juTGS7Lgt3tCUZmcf38m524Y9C c13hIwTZCx/PVN2NqLJ9IONurzbRK2LM9aciBylf6bT04rzjYAMVjGaVtKt3+2rozM9s0oxUM2gRe xOLBCpe+Ce/ZqubEN5T3oypwjp4sH+DKZlD7M/IFwF0slqpA6MrKvXMxIeN3q9DFdGYtUKdU8GQ2j w0D/VJwJciPGAALu9/tMxBqzXHo1hQ5rW//qyWqUSUK3OoXsLsdxK53kQEZ/GY4BN7epY7YMJd4Pj eUKg0Fgwp69K67aYgB0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmkI-0000000Ga2o-2hb9; Tue, 30 Jan 2024 11:57:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmkE-0000000Ga14-1IVP for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 11:57:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EDF3DA7; Tue, 30 Jan 2024 03:58:19 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 194363F762; Tue, 30 Jan 2024 03:57:29 -0800 (PST) Date: Tue, 30 Jan 2024 11:57:23 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially revert "mm: page_alloc: remove stale CMA guard code" Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-5-alexandru.elisei@arm.com> <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_035738_425437_525FCE56 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Jan 30, 2024 at 10:04:02AM +0530, Anshuman Khandual wrote: > > > On 1/29/24 17:16, Alexandru Elisei wrote: > > Hi, > > > > On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: > >> > >> > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") > >>> removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list > >>> because CMA is always allowed when __GFP_MOVABLE is set. > >>> > >>> With the introduction of the arch_alloc_cma() function, the above is not > >>> true anymore, so bring back the filter. > >> > >> This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being > >> assigned to alloc_flags in gfp_to_alloc_flags_cma(). > > > > Can I add your Reviewed-by tag then? > > I think all these changes need to be reviewed in their entirety > even though some patches do look good on their own. For example > this patch depends on whether [PATCH 03/35] is acceptable or not. > > I would suggest separating out CMA patches which could be debated > and merged regardless of this series. Ah, I see, makes sense. Since basically all the core mm changes are there to enable dynamic tag storage for arm64, I'll hold on until the series stabilises before separating the core mm from the arm64 patches. Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel