From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 320CDC46CD2 for ; Tue, 30 Jan 2024 14:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KuAFqfMHYwaC124x3MneWJ4NUDjDYw+r9eswrb4YI2A=; b=IBJFCEz7jIIoNi 7jGAogczMeIjoe+Zvo2GzZwJnQbZm8H2c2wT3PgE8HO1W8hhQeScjpOqdjt+erqJcNNiXwmqXs90/ TIl3GCTMI/MuDuE9JxhzgG9VtXRldtTlI/ejb8ihwNtnGmUl7Rx9P5FG70SNrOpGRezGefvKUAzYJ 7cLxodXSWqGwNQBzLk4IwmItVvmSwAxlOSv6Yu9o5nU3wlAG2r0rkr8WATogngL3xE0bD3f3m+WkG Mri2BGVjVOPacoHleJQLr4OtAVgXsUe5sQzh82eCWD6l1N+fjooL6XfJq+1zgrsJ4PY5WH+afngZg gZRQdBLsOdGJu802w6YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUoh9-0000000Guz5-3Y7y; Tue, 30 Jan 2024 14:02:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUoh7-0000000Gux2-01xl for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 14:02:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B+qqCMS/lknoBXhTRlhfXHK7D4gHB5v8JSzkpcRldtE=; b=gwySDtMvJgokkQQEsZ7zsFDcUD iMsZL8ktSjeZ/04CwdzjTluKIpxBhO75Chs9HpAEBk1i37cS11wCx98d6zpOsoYF+oBMLQ40BY2w1 b9dlQ9S4mgx2TWrAAwmyW4U29XhtvOEBX6C8M4zldexpS2Xa7MXUJN1TSpIQ9na58HqeE19ak+8rl hiF6kSf4hrL9CFcEbopeT4GyFY+TFyP5qTFZUHCm8HiKLET5qnHbKLBXhI44itJ9w8Oe5/AgcgAwe C1htZBHaqVodvNJZ/6/jEh1dblWhOWJU+JD0UQnjJ/7DFrHQbu9nHKh4XVlmeSpq7WmXevl87woHQ pTja/jXw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44332) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rUogr-0001ub-0v; Tue, 30 Jan 2024 14:02:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rUogm-0005Yl-RT; Tue, 30 Jan 2024 14:02:12 +0000 Date: Tue, 30 Jan 2024 14:02:12 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Romain Gantois , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Maxime Chevallier , Miquel Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH net-next v2 1/7] net: phy: add PHY_F_RXC_ALWAYS_ON to PHY dev flags Message-ID: References: <20240130-rxc_bugfix-v2-0-5e6c3168e5f0@bootlin.com> <20240130-rxc_bugfix-v2-1-5e6c3168e5f0@bootlin.com> <78ee61dc-3f1e-4092-b2a3-5831f8caf132@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78ee61dc-3f1e-4092-b2a3-5831f8caf132@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_060233_069343_609C5B89 X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 30, 2024 at 02:55:50PM +0100, Andrew Lunn wrote: > > @@ -768,6 +768,7 @@ struct phy_device { > > > > /* Generic phy_device::dev_flags */ > > #define PHY_F_NO_IRQ 0x80000000 > > +#define PHY_F_RXC_ALWAYS_ON BIT(30) > > It is a bit odd mixing 0x numbers and BIT() macros for the same class > of thing. I would use 0x40000000, or convert PHY_F_NO_IRQ to BIT(31) If I used 0x40000000, there would be review comments suggesting the use of BIT(). Can't win! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel