From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4C78C47DB3 for ; Fri, 2 Feb 2024 13:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZeKu7+wtjXE6FEI7/wkqQN7sX+LPC5AruDLbfliB91c=; b=bE1MMVxZ/jiqUW bNRgDFGMUg6m4VzMlA7QiNdmDGkY93QvlA+VzW98rFkxNMjFtfGwLNXpaNfj5HIH/hRWoVSmZgcTb jo5/11xKRLCP9v2gDlUK0EfUoYBVP2lZ3K1ql4ADFF95GX4qnRklEr23H2Jin6amWZCX3R9ZhHvPC YTbLIuAF581ZfxXMV0tKqJIaanK+1bVk4HQD9TKzqiRcO1gNw5SOcRoq+xKBHHGNXeqQ4rFT4dnkj waNkrCdtSDoKAo2uff5OlvagHYI/zSOEFPckEc4m3nw+XiVBCt4Gjem53FHOrCqX7a463T4hZviqc R2I/WqXoUA37/skfHd1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVtrn-0000000BePc-0GFW; Fri, 02 Feb 2024 13:46:03 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVtrk-0000000BeP9-2kcR for linux-arm-kernel@lists.infradead.org; Fri, 02 Feb 2024 13:46:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7hFvlERHieFAUVwlSVD673jXkZUakpcgcmrI0kwzE+Q=; b=ml2LZsqYjytchOT37m3ldtskih 8BlyHKRB07xDljmVdrFSERYHH1plpteURpODM5Vq/d+IPZO+LHZlRaRUVf67OJmbhjdIiE37e+vva 37DG9vtOcfZBmVswhST+mNnSSti+wB6eTDKAfzSbfXC7cMnpgvHtwxjCSBiGt1pk4+yc/W3JZMB4t TwaNeLJgUyssyER2l37LnXGrSydladNs3goAm41WVV2d50ZUmscFAzZFxE7Gq6nQFct3FRJNYIjRx 3OxUAy2ECxEmaq1Xh3FTZI6YBJoVPUuD2b34+q4Vcsy/FYrL7N98JiP5neHHFcKpJDBcGY6Y37G50 swML5u6g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59704) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVtrW-00063T-0c; Fri, 02 Feb 2024 13:45:46 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rVtrP-0008Mp-Lz; Fri, 02 Feb 2024 13:45:39 +0000 Date: Fri, 2 Feb 2024 13:45:39 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: g@lunn.ch, Heiner Kallweit , Alexandre Torgue , bcm-kernel-feedback-list@broadcom.com, Byungho An , Clark Wang , "David S. Miller" , Doug Berger , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jose Abreu , Justin Chen , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, NXP Linux Team , Paolo Abeni , Shenwei Wang , Vladimir Oltean , Wei Fang Subject: Re: [PATCH net-next 3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee() Message-ID: References: <011cb523-0561-436a-9f64-4479648b4770@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <011cb523-0561-436a-9f64-4479648b4770@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_054600_718838_499ED0B5 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 02, 2024 at 02:22:02PM +0100, Andrew Lunn wrote: > On Fri, Feb 02, 2024 at 09:33:54AM +0000, Russell King (Oracle) wrote: > > fec_enet_get_eee() sets edata->eee_active and edata->eee_enabled from > > its own copy, and then calls phy_ethtool_get_eee() which in turn will > > call genphy_c45_ethtool_get_eee(). > > > > genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active > > with its own interpretation from the PHYs settings and negotiation > > result. > > > > Therefore, setting these members in fec_enet_get_eee() is redundant. > > Remove this, and remove the setting of fep->eee.eee_active member which > > becomes a write-only variable. > > I _think_ p->eee_enabled becomes write only as well? Thanks for spotting, I'll remove it in v2! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel