From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61276C48BC3 for ; Wed, 14 Feb 2024 21:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3aBKr2kdJLQyL2ll7UXXPx4rtgSNYhcZK2PwL6E7qb4=; b=0t0CxXN9LYWXRR lYHwVJzX95ZzYDJkrGpNg/HoRSPWmx0lN+cWwzlUC8UtBRnzH1uJa+JaVWg7MOw7auD6aQiYjeBlV u9kn3mxBh0tMkADmmkgqM9KaEWlWyYP1HAgB/qeATo1IZhO6ciPsz7izXcoaWd+J0YlxZZBnGQC9G HGas4aR9DzxOPNlb7OaVIEya/mD9u5eA95zrx0OYLQkfG6e3ttQVpv6tHSEXivNzxla7l5l6m8lGv j8Wo27PEHEx8v4DP3A+hqtzVLGpuF3xYi6ZmBoYgyPW8Wlgt9NFFbiUuLXo8+8i8bfiOvlwZFfOBF 90RbUFLrUlATE+Sy7QsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raMwj-0000000EKKf-2tt7; Wed, 14 Feb 2024 21:37:37 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raMwh-0000000EKJN-0HGD for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 21:37:36 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a3d159220c7so18765466b.2 for ; Wed, 14 Feb 2024 13:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707946653; x=1708551453; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ir/unotnfD5rMdtsGoyJfuSxeOlSTFmP2bDl4ko9QIQ=; b=zvGYQOyYfhQoP1s/74zsNpIH5lmQK+db9CDuMys0XzlveRpnjC7E1xDVU0Rnaqi3G1 sOIaQRxw6467ySTqUFDOd2I6tz4aWLb1JO3iiAFEL/89sEAW1bVUEM9+Hg3h/ZoMKBJE ldiJ4k4lBkEsY/EUffbCpUtO2qPK4yG1q/y9BTO6LwUdMHWHIl5iwKpttO/ERQdKV2OI x8uUFc363I+sjeGiz8qV6g55eftNRVe9R3QqrjM/mfW17wafjbw2ZdJb5dLXWt+FsFnK GUEGqwbfS5Jzaj3CHPk65AsTXyMc6X4t3Rk3dXTCaZawhRBFBcr+x6YWXn9PsMWFDG1m fDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707946653; x=1708551453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ir/unotnfD5rMdtsGoyJfuSxeOlSTFmP2bDl4ko9QIQ=; b=pH9W7XZUFVUM542c+LEgofvcJthpIV7pc4U5nUE4oOAiCrorEPvCF/1D65VPye7Grj rTWAUZe4UWCXsvaDfD9zrySWRGfnLVcMOHuIsNeawug7RTSqhUmS6cVfkQIaK0Dd8bM4 dWX+Bj5K2+Z31RyC0nnmgm2M3aQUErN0xPrb5TwyyVHPujaY37cQdKNdd4sOsy8CW+v+ RJa2gcnPJvUvJWCjK3vyKKA1DT8I0tdqNhnosHI2wbHMd+IwXCHpGWQhqobffOhBVG3N jxndZMb1NXDQVq0LRcJbChoQz/dnflSDTq9wHgR8vbDmRLHcn9TGOSCnMhpgNRfC18La KbFg== X-Forwarded-Encrypted: i=1; AJvYcCUfUeydfywVhXBUq7ijrzrVdHa+ipQHwDlww92ycq7Riy7u7bDwhP+b4dVRCg+4XRxEBV9K9Efe30Y4hM82eaTnETW638Jw6CfrklpBWvYgpFKQBNo= X-Gm-Message-State: AOJu0YyCuNIo+re13K068aWNgthETpcQNmoOVO6HyDi49/N+oeqkfcbG rBKD9ibGHhBnLe1kSHYhdQeehg+jWw4yFuzWwxTp8wP59YKhRufUIvfWBNYmwiQ= X-Google-Smtp-Source: AGHT+IHk8JLhkU3PqjlB3r1X7UjDpDlD05JGbvpAVKzdIOh6hcCu0LS+v/I1vied8tFOXqlMkHNH4g== X-Received: by 2002:a17:906:ccc1:b0:a3d:30a0:2e79 with SMTP id ot1-20020a170906ccc100b00a3d30a02e79mr2565149ejb.54.1707946653601; Wed, 14 Feb 2024 13:37:33 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWf55Ibmdxn4mP1NgfJga60DJOumX4O0k/ju9udq+ijqg03KBqFzNuxp3XkGYlC8PLAgOML2h7P9FIrghvOxk+13ZbEiPwSDSQpzylyKcGKntugzulOXfO+UO0HJWUMaqvCtevi42PRrUUzUS/BXVaAnsPCZC/Oyp1WTdnoNVxdUl+Q/KiUx+tTpiXOcnfxIQlJBxP/YAuDrCiniNFjo24YgFRBqo4nznj4EKhPoBPPe6Xk1vCO3tz+0OO7F2YPl5wZAgtZicZTKn+kA0Ee7eAHqaB/QuO4hnkES/QspkiETCivrxFxKUBnNk9GepzntLozlmbkNCQVFg5F3PnRJ2SHFpX81NPX4ua6xQCF7KGxdftPmEEb60b3KfHRaxI8+qf+9lKArK5F7+YfQnM6yTVzZ/lbYBqPnCsF8ERlRsMjex4BvwfrPksIMGVL5h03HdQxtVn9pfBqTxB+ceGzYV88sL/GGwpt/zOx2WWJJkTRKegN/sMgqQ== Received: from linaro.org ([188.24.162.93]) by smtp.gmail.com with ESMTPSA id hw20-20020a170907a0d400b00a3cf243de37sm2249089ejc.111.2024.02.14.13.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 13:37:33 -0800 (PST) Date: Wed, 14 Feb 2024 23:37:31 +0200 From: Abel Vesa To: Konrad Dybcio Cc: Stephen Boyd , Matthias Brugger , Bjorn Andersson , Dmitry Baryshkov , Neil Armstrong , AngeloGioacchino Del Regno , Srini Kandagatla , Johan Hovold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC v3 2/4] spmi: pmic-arb: Make the APID init a version operation Message-ID: References: <20240214-spmi-multi-master-support-v3-0-0bae0ef04faf@linaro.org> <20240214-spmi-multi-master-support-v3-2-0bae0ef04faf@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_133735_134108_41D07BDD X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-02-14 22:16:58, Konrad Dybcio wrote: > On 14.02.2024 22:13, Abel Vesa wrote: > > Rather than using conditionals in probe function, add the APID init > > as a version specific operation. Due to v7, which supports multiple > > buses, pass on the bus index to be used for sorting out the apid base > > and count. > > > > Signed-off-by: Abel Vesa > > --- > > [...] > > > > + > > /* > > * v5 offset per ee and per apid for observer channels and per apid for > > * read/write channels. > > @@ -1178,6 +1246,49 @@ static int pmic_arb_offset_v5(struct spmi_pmic_arb *pmic_arb, u8 sid, u16 addr, > > return offset; > > } > > > > +/* > > + * Only v7 supports 2 bus buses. Each bus will get a different apid count, > > "bus buses"? Urgh. Will fix in the next version. > > Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel