From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1B10C4829E for ; Thu, 15 Feb 2024 16:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GT5Bx+dmOvMJo70QciS/UOjMTVsM7zlpn7vImfsdZY8=; b=hMoWxFwMPLNJi4 Qz9bQa+pMRZVUYYsHVK4IeSnhayalHXx2lAekltt2PY1Nk3K2/YFD+JROhoTzjYqlVdcy2r7brLWU YJo9knLPq7ug97kCin8VdmwdUx8MN9MjHOQeJXNuJbTkTDO33LceJYOvXtSbD+7aP07GYkkN7jUGw A2lXTj40fHkcWno3OCT5G46Pp1OCh6xVjlS08wYARyrolLwt6WqafqpyvHZ5mvDO36fZq+Gv4DKVv UOGq0XJVps5jATlE2FLsP7bFQ3+L2zd4UVwyKK7hvaFYXb68GcYORTgbsQFg4qkzTzqT1FV3ClhzN CkEPKvM59Lw753um7rkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raeEe-0000000Gsq5-2YwX; Thu, 15 Feb 2024 16:05:16 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raeEc-0000000GsoH-3BTY; Thu, 15 Feb 2024 16:05:15 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2222947" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2222947" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 08:04:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="912185118" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="912185118" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 08:04:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1raeE9-00000004prW-0Y4C; Thu, 15 Feb 2024 18:04:45 +0200 Date: Thu, 15 Feb 2024 18:04:44 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 17/18] PCI: j721e: add reset GPIO to struct j721e_pcie Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-17-5c2e4a3fac1f@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v3-17-5c2e4a3fac1f@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_080514_856416_72971430 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 04:18:02PM +0100, Thomas Richard wrote: > From: Th=E9o Lebrun > = > Add reset GPIO to struct j721e_pcie, so it can be used at suspend and > resume stages. ... > case PCI_MODE_RC: > - gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); > - if (IS_ERR(gpiod)) { > - ret =3D PTR_ERR(gpiod); > + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_L= OW); > + if (IS_ERR(pcie->reset_gpio)) { > + ret =3D PTR_ERR(pcie->reset_gpio); > if (ret !=3D -EPROBE_DEFER) > dev_err(dev, "Failed to get reset GPIO\n"); > goto err_get_sync; > @@ -504,9 +504,9 @@ static int j721e_pcie_probe(struct platform_device *p= dev) > * mode is selected while enabling the PHY. So deassert PERST# > * after 100 us. > */ > - if (gpiod) { > + if (pcie->reset_gpio) { > usleep_range(100, 200); > - gpiod_set_value_cansleep(gpiod, 1); > + gpiod_set_value_cansleep(pcie->reset_gpio, 1); > } Instead of all this, just add one line assignment. Moreover, before or after this patch refactor the code to use ret =3D dev_err_probe(...); pattern that eliminates those deferral probe checks. -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel