[PATCH 1/2] Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

[PATCH 1/2] Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.

Marek reported:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this
patch, it is detected.

Please drop this patch for now."

Revert it to avoid the regression.

Reported-by: Marek Vasut <marex@denx.de>
Closes: https://lore.kernel.org/linux-arm-kernel/623c294a-5c53-4e01-acbf-104acc180e14@denx.de/T/#u
Fixes: a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
index fea67a9282f0..b749e28e5ede 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
@@ -175,14 +175,10 @@ typec@3d {
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_ptn5150>;
 
-				connector {
-					compatible = "usb-c-connector";
-					label = "USB-C";
-
-					port {
-						ptn5150_out_ep: endpoint {
-							remote-endpoint = <&dwc3_0_ep>;
-						};
+				port {
+
+					ptn5150_out_ep: endpoint {
+						remote-endpoint = <&dwc3_0_ep>;
 					};
 				};
 			};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector"

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

This reverts commit 095b96b2b8c6dcabf40bbfe4bb99a95fe55c7463.

Marek reported the similar change in imx8mp-dhcom-pdk3.dts
caused a regression:

"This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this
patch, it is detected.

Please drop this patch for now."

Revert it here as well.

Fixes: 095b96b2b8c6 ("arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../boot/dts/freescale/imx8mn-var-som-symphony.dts    | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
index f38ee2266b25..a6b94d1957c9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts
@@ -128,14 +128,9 @@ extcon_usbotg1: typec@3d {
 		pinctrl-0 = <&pinctrl_ptn5150>;
 		status = "okay";
 
-		connector {
-			compatible = "usb-c-connector";
-			label = "USB-C";
-
-			port {
-				typec1_dr_sw: endpoint {
-					remote-endpoint = <&usb1_drd_sw>;
-				};
+		port {
+			typec1_dr_sw: endpoint {
+				remote-endpoint = <&usb1_drd_sw>;
 			};
 		};
 	};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] Revert "arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector"

[Shawn Guo]

On Sat, Jan 13, 2024 at 07:43:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> This reverts commit a4dca89fe8a1585af73e362f5f4e3189a00abf8e.
> 
> Marek reported:
> 
> "This patch breaks USB-C port on this board.
> 
> If I plug in USB-C storage device, it is not detected. If I revert this
> patch, it is detected.
> 
> Please drop this patch for now."
> 
> Revert it to avoid the regression.
> 
> Reported-by: Marek Vasut <marex@denx.de>
> Closes: https://lore.kernel.org/linux-arm-kernel/623c294a-5c53-4e01-acbf-104acc180e14@denx.de/T/#u
> Fixes: a4dca89fe8a1 ("arm64: dts: imx8mp-dhcom-pdk3: Describe the USB-C connector")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel