From: Shawn Guo <shawn.gsc@gmail.com>
To: Charles Perry <charles.perry@savoirfairelinux.com>
Cc: shawnguo@kernel.org, robh@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: imx-weim: fix imx_weim_gpr_setup()
Date: Tue, 6 Feb 2024 15:07:21 +0800 [thread overview]
Message-ID: <ZcHaqasXS60LtbVn@dragon> (raw)
In-Reply-To: <20240122205738.2432552-1-charles.perry@savoirfairelinux.com>
On Mon, Jan 22, 2024 at 03:57:29PM -0500, Charles Perry wrote:
> Commit 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges"
> parsing") changes the parsing of the "ranges" field by using
> for_each_of_range instead of of_property_for_each_u32. The number of
> iteration of the loop is now equal to the number of range within
> ranges. It is therefore no longer needed to check that i is divisible
> by 4, otherwise, valid configurations will fail imx_weim_gpr_setup().
>
> Fixes: 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges" parsing")
> Signed-off-by: Charles Perry <charles.perry@savoirfairelinux.com>
Thanks for the patch! But I have picked up the one [1] from Lucas.
Shawn
[1] https://lore.kernel.org/all/20240119185026.1192333-1-l.stach@pengutronix.de/
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 6b5da73c85417..837bf9d51c6ec 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -120,7 +120,7 @@ static int imx_weim_gpr_setup(struct platform_device *pdev)
> i++;
> }
>
> - if (i == 0 || i % 4)
> + if (i == 0)
> goto err;
>
> for (i = 0; i < ARRAY_SIZE(gprvals); i++) {
> --
> 2.43.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-02-06 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 20:57 [PATCH] bus: imx-weim: fix imx_weim_gpr_setup() Charles Perry
2024-02-06 7:07 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcHaqasXS60LtbVn@dragon \
--to=shawn.gsc@gmail.com \
--cc=charles.perry@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).