From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB009C4828D for ; Tue, 6 Feb 2024 07:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0kuIq5c+HwHsUqr4jwkYEhNdYqWHo7uNQpzFM2/EAAQ=; b=eP30hiZmKuLuYg nMbHNDXH0u2VBcY66hNgwovptzGiaJheHG+U841mWg8IaEcEhm9FZf1r1iJpsbMLlggdPvuNkfahB j4XSbKN/nvGfXmUGnI4D1ySCgRrL+3dxLsWox8ksE5yQ/1RzcXkLlPixWzsblVFB9QBKD7200NEzS wXimES+MCZvPeL9bzISrC1zhSTuUjGap4LGUttbXDFXHQfcUjJ9jAZOOpAZkDtCTE9yReSvy3LIUc kN/I5+IQli+CE9aPDza7aYuwGJsMCCDNI+Z0vmTb9GCBhTtaAGMqf96oHpaZ2cXb0YS9kesiaEPEr cvFV5rBFJ4PNdTlcWyew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXFYM-00000006F2K-1lT6; Tue, 06 Feb 2024 07:07:34 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXFYK-00000006F1v-1QOk for linux-arm-kernel@lists.infradead.org; Tue, 06 Feb 2024 07:07:33 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d74045c463so41481815ad.3 for ; Mon, 05 Feb 2024 23:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707203250; x=1707808050; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1nVgxtxxB24ooM015/bjH1PamdQQY17NCPa4n0g2/8c=; b=FVjtUhDmigt0BCUs9NHKGY0XZjv+IlBN85yQ81szoAhArOa/Tdl3wTRIzm89n3OFzL FzNIfOOa5HwNkLz3kxlroghRTnnI9kh32bQ8U1+Ne9SN7WzKysPNoqvhTVEFArKtA+/9 LQyk9Md9uu1Qv83Ej1jtbu6uX50N+63MdzJ3VMBG5yabeGSBCBJE1GkZYMT1NgfyXFQ3 Tceyayi/75A2dUJx37rmBbiDDJ/fLnaPu5MCRdTYKAC0fFYe9aKEFIqNXGHK8hax5u1w bhwxFrR6n/gFVzSUPOd5isXAPKV0MwfKVxcLeLJIn60C2ju6vdWtmLkV7pdTIE2iWgxU hwHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707203250; x=1707808050; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1nVgxtxxB24ooM015/bjH1PamdQQY17NCPa4n0g2/8c=; b=lxLOGftfSqK+0kX6/CMty7GackSRMgOhtOBRra9uHxVSqUlphg2T8L9EkOEeM3k+4f FxAx3ar1x1h6+sMiEdGH1U2fMUhWLYCF1h+YCCiodCxbIXaGgaBounUPiCfbfPTFAB3R tCbdspUCHgGsZC4DQWPspb3UYpicE7xiYXVTx5b65+it3xIsJVuYEk1Y7LpYSC13AHPP C9elaVehkx8ia8XB4NXO0OxnX7Z3clIvHdMldqvUmS2O8xbyzlV9ici20rVKRxNp5Xsu M/YmEsJ6lEMsM/2Edn+eTYrJZbCPQfHfKtRzVTyN8AGZXMRuFS8lNV+45ilGCZqn040e vPng== X-Gm-Message-State: AOJu0YwQUHFZljET1pzU8TcVN7oMG3qyRLXicHBO/awkVEvuq2+YZZ5u WaKWrL39t6lTvan32mg9zUK1e7vQkifuMBFKByqx/vztbFZMMokG X-Google-Smtp-Source: AGHT+IGOc6rrXPB1S9d1QiU78oRJLaHBtNbQ06ZRU0AUlLCWpIimBm/knEqicCOHNU4qjV4EH+7XAg== X-Received: by 2002:a17:902:d2cc:b0:1d9:bed3:ba0b with SMTP id n12-20020a170902d2cc00b001d9bed3ba0bmr975627plc.9.1707203250524; Mon, 05 Feb 2024 23:07:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUCcxcEFPgZFK73jbaI0vIPkcdpUfWSZmClbsGqVh3dIf3HjD3nd6n7lkU1vNa+O+zLZzPBmPtKIiR/dPBY6pJ77ngNf/nPhvRmIFnjEwqrk+NE5OdG/Le/L6CON7GUw4mf+PjNzjnNFbiuVfHyNkf65KkDAKTpFSaZx0U+Eah+b/B4jA== Received: from dragon (144.34.186.27.16clouds.com. [144.34.186.27]) by smtp.gmail.com with ESMTPSA id iy15-20020a170903130f00b001d8f3c7fb96sm1079796plb.166.2024.02.05.23.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 23:07:29 -0800 (PST) Date: Tue, 6 Feb 2024 15:07:21 +0800 From: Shawn Guo To: Charles Perry Cc: shawnguo@kernel.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: imx-weim: fix imx_weim_gpr_setup() Message-ID: References: <20240122205738.2432552-1-charles.perry@savoirfairelinux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240122205738.2432552-1-charles.perry@savoirfairelinux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_230732_407631_51E3CB0A X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 22, 2024 at 03:57:29PM -0500, Charles Perry wrote: > Commit 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges" > parsing") changes the parsing of the "ranges" field by using > for_each_of_range instead of of_property_for_each_u32. The number of > iteration of the loop is now equal to the number of range within > ranges. It is therefore no longer needed to check that i is divisible > by 4, otherwise, valid configurations will fail imx_weim_gpr_setup(). > > Fixes: 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges" parsing") > Signed-off-by: Charles Perry Thanks for the patch! But I have picked up the one [1] from Lucas. Shawn [1] https://lore.kernel.org/all/20240119185026.1192333-1-l.stach@pengutronix.de/ > --- > drivers/bus/imx-weim.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index 6b5da73c85417..837bf9d51c6ec 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -120,7 +120,7 @@ static int imx_weim_gpr_setup(struct platform_device *pdev) > i++; > } > > - if (i == 0 || i % 4) > + if (i == 0) > goto err; > > for (i = 0; i < ARRAY_SIZE(gprvals); i++) { > -- > 2.43.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel