From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64C29C4828F for ; Thu, 8 Feb 2024 11:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UbVuEZn9cHOSrWh8mV8VmnIjWwFUqOtzLWHA6f4sJrM=; b=JHmDOplYUiy+d+ 7KD72qbMwFLnkBHnJXuEJwzVlj+MCoKDPZe5H2OnOhcXuYFMj02YJn51b6uSRdt9nDGVpi2tn0K+t HwJwsb98vd+GxsayGgOXzbpqQSlcuLl/Ae/2dNCd2JCMhePe9lnT3vsxwjnolXqcMZmqFoQ82V13m sqw5/+Poa3mLvyHXkERCxEadPE8IPVj55vSiCNQBrl5f9gbHc6XMpHEBnvzlyQwVAVJHnbj0e1tKv dXk3YqylntnVzXDCRfg/b161nAoZfK14kGlCiV6IowxU2voYoJYkANkeXjFlnHyjj2ZNtPug8arcN AIH0HiaGIE/eZPC8ePdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY2U6-0000000DYkN-2z0L; Thu, 08 Feb 2024 11:22:26 +0000 Received: from out-185.mta0.migadu.com ([2001:41d0:1004:224b::b9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY2U3-0000000DYje-1jH3 for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 11:22:24 +0000 Date: Thu, 8 Feb 2024 11:22:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707391332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+JLC0bJbodI8ZiE9KumZ6n3ksTg1WYrWoPpSkRILYLQ=; b=IGzNTig5GF8t6a3J0S1YdVllPWiEh/7KZrPf71DcSnhDhIThtk5lrzJW8l06r5mfmUbYGg BM6IiuXguDkYNGYk3PvyHZPZGX2Cd35bAQUcWDdc94wdAn6xwdsrYOLgZnxnR87IwmayYl zxpuX570/mSCjclRcGWULt7i9k0Chr0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Joey Gouly Cc: kvmarm@lists.linux.dev, maz@kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v1 0/2] small kern_hyp_va() cleanups Message-ID: References: <20240208105422.3444159-1-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240208105422.3444159-1-joey.gouly@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_032223_672186_9D92BB1B X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Joey, Thanks for having a look. On Thu, Feb 08, 2024 at 10:54:20AM +0000, Joey Gouly wrote: > I wanted to add some comments to __kern_hyp_va(), since I was recently trying > to understand it, and I think it could be helpful for someone looking at it in > the future. That part is definitely a bit screwy :) > The second patch removes the assembly macro version, since it is unused. Maybe > (out-of-tree) pkvm uses it or it's just worth keeping around in case someone > needs it in the future. So if that patch isn't applied it's not too important. Keeping unused code hanging around is rarely useful. While it is nice to give consideration to the pKVM folks (looks like they don't need it), it is easy enough to re-introduce later on. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel