From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 024F6C4828F for ; Thu, 8 Feb 2024 13:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/Ik2XCuFBT3jS6i7Jrs4DLcjaa3gWa90tvgX5YH0bs=; b=gLdgY4ykG8EvCe 0CK1zVQW2pcl+zXynGRB8ytui+acgsl57CElSF9bh5onatnt7VAufsNLfj+Vb63E5mTdbmlxBKn/x vkJL45ZLct2+p1nrULnylpSRv1Wwgr0/i28F96X7XBDReoz5xU7VgBQ7LBCBiQVLR7NeirQNl9SEl TDTxVo8QbJsEwbdcmYEi6klldKvo6Gt2nJAVsAHWoGBlqZa4hjqlN6OSPzwMc4FQqOWAoWe29Qog1 4zPU9JXDsx1GiyrZSQaO/xBBdqdMzTydWWT1vMToyoY19/q5i61d6aJyc0S6dbf2LM564Oge3RiES +4eoB2j91fxkIRJxOJ+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY4Rs-0000000Du2j-3LVO; Thu, 08 Feb 2024 13:28:16 +0000 Received: from out-176.mta0.migadu.com ([91.218.175.176]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY4Rp-0000000Du1a-2IAX for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 13:28:14 +0000 Date: Thu, 8 Feb 2024 13:28:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707398887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5GXASM88lSpru4mOfS9feCUAUHk/xaBVPwiBCs6tZso=; b=Nso1E9AeB7QJB9zlavDTtNgdXuA/FvvSO8ItEA69sNLuviA2zUvFZaQ5tpyqnT8+WDtojd JzNwv4JxIbRvg/qXPcx/dsEQtkNXSlTXte0zCDHAQ82lYL3un+eNenj2bCASSFZop3thlD 1kzC5JrI4lpzC0H0SxK6Ze7SWpVje+s= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Joey Gouly , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v1 2/2] KVM: arm64: removed unused kern_hyp_va asm macro Message-ID: References: <20240208105422.3444159-1-joey.gouly@arm.com> <20240208105422.3444159-3-joey.gouly@arm.com> <86jznf5dqm.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86jznf5dqm.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_052813_752358_26531560 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 08, 2024 at 12:42:25PM +0000, Marc Zyngier wrote: > On Thu, 08 Feb 2024 10:54:22 +0000, > Joey Gouly wrote: > > > > The last usage of this macro was removed in: > > commit 5dc33bd199ca ("KVM: arm64: nVHE: Pass pointers consistently to hyp-init") > > > > Signed-off-by: Joey Gouly > > Cc: Marc Zyngier > > Cc: Oliver Upton > > --- > > arch/arm64/include/asm/kvm_mmu.h | 21 --------------------- > > 1 file changed, 21 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h > > index d248a7ae627a..961d4431654b 100644 > > --- a/arch/arm64/include/asm/kvm_mmu.h > > +++ b/arch/arm64/include/asm/kvm_mmu.h > > @@ -53,27 +53,6 @@ > > > > #include > > > > -/* > > - * Convert a kernel VA into a HYP VA. > > - * reg: VA to be converted. > > - * > > - * The actual code generation takes place in kvm_update_va_mask, and > > - * the instructions below are only there to reserve the space and > > - * perform the register allocation (kvm_update_va_mask uses the > > - * specific registers encoded in the instructions). > > Consider moving this comment to the C version instead of deleting it > completely (the part about the register allocation is pretty crucial). > > Oliver can probably fix this when applying it, and my previous Ack > still stands. Yeah -- this comment is still rather useful. I'll fix it up when I apply the series. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel