From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 757F4C48260 for ; Thu, 8 Feb 2024 13:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7PL/EncYzZyJAK1SIoiM1c30udpCM85dX/xqtxrVTJA=; b=cgLjCswTFfvf9x 8zGUbmJKWd+t6YY1WEhovFwGoMvB33xZIqM3DuGIdiBZiHg7YamHeqmlJMTKxYSRApiIUwulW5Vz4 s5IbIMogFUXAyTzr/Lfg4a3sRbZ3hEoBDGszgsy0vc5JdB46uNrXW4LJ1zJ9Nu9bEfFfMHnFH/UgU pYJPoDAFNuXe3aHzyUgvuuLBtHy4djhfhQDlMaFVO1jmA1Tj4HDfdrWPD4kQxwc2Rt0zaCE13y9/b a0I9Cw8N1W1ymV8O5SHyxWgEUzRUBBZOhS5uuCzsxnYPKkGSV1e51Ky5RDkxxpVR+MV++udFDo2dU M1Ud18l/yQqrnPq+qgmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY4Ov-0000000DtWt-0sn3; Thu, 08 Feb 2024 13:25:13 +0000 Received: from out-181.mta1.migadu.com ([2001:41d0:203:375::b5]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rY4Os-0000000DtWE-3GJ4 for linux-arm-kernel@lists.infradead.org; Thu, 08 Feb 2024 13:25:12 +0000 Date: Thu, 8 Feb 2024 13:24:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707398704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7lGdYQhRSSfN0dykRkya8P4upBClWyVoqhyocRgWZ8E=; b=Tvi1paTTnVNkLWQ4FgCp0lp4590qKyU+DMW/1tenbAuA71NOiHdT0sIcFrHjZZt6+qnifI OGwMwmpbvxHwN3YvP4Eb1gWO9mMevwVbdsnC658WCysAX7SkPT2Rjxj3cs1498TfKkffbf f0PZpFefakmGx/dYyp3yTn8u6VLlMLg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Catalin Marinas Cc: ankita@nvidia.com, jgg@nvidia.com, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, reinette.chatre@intel.com, surenb@google.com, stefanha@redhat.com, brauner@kernel.org, will@kernel.org, mark.rutland@arm.com, alex.williamson@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, andreyknvl@gmail.com, wangjinchao@xfusion.com, gshan@redhat.com, ricarkol@google.com, linux-mm@kvack.org, lpieralisi@kernel.org, rananta@google.com, ryan.roberts@arm.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, kvmarm@lists.linux.dev, mochs@nvidia.com, zhiw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 1/4] kvm: arm64: introduce new flag for non-cacheable IO memory Message-ID: References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-2-ankita@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240208_052511_041336_D008B530 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 08, 2024 at 01:00:59PM +0000, Catalin Marinas wrote: > On Thu, Feb 08, 2024 at 02:16:49AM +0530, ankita@nvidia.com wrote: > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > > index c651df904fe3..2a893724ee9b 100644 > > --- a/arch/arm64/kvm/hyp/pgtable.c > > +++ b/arch/arm64/kvm/hyp/pgtable.c > > @@ -717,15 +717,28 @@ void kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu, > > static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot prot, > > kvm_pte_t *ptep) > > { > > - bool device = prot & KVM_PGTABLE_PROT_DEVICE; > > - kvm_pte_t attr = device ? KVM_S2_MEMATTR(pgt, DEVICE_nGnRE) : > > - KVM_S2_MEMATTR(pgt, NORMAL); > > + kvm_pte_t attr; > > u32 sh = KVM_PTE_LEAF_ATTR_LO_S2_SH_IS; > > > > + switch (prot & (KVM_PGTABLE_PROT_DEVICE | > > + KVM_PGTABLE_PROT_NORMAL_NC)) { > > + case 0: > > + attr = KVM_S2_MEMATTR(pgt, NORMAL); > > + break; > > + case KVM_PGTABLE_PROT_DEVICE: > > + if (prot & KVM_PGTABLE_PROT_X) > > + return -EINVAL; > > + attr = KVM_S2_MEMATTR(pgt, DEVICE_nGnRE); > > + break; > > + case KVM_PGTABLE_PROT_NORMAL_NC: > > + attr = KVM_S2_MEMATTR(pgt, NORMAL_NC); > > + break; > > Does it make sense to allow executable here as well? I don't think it's > harmful but not sure there's a use-case for it either. Ah, we should just return EINVAL for that too. I get that the memory attribute itself is not problematic, but since we're only using this thing for MMIO it'd be a rather massive bug in KVM... We reject attempts to do this earlier in user_mem_abort(). If, for some reason, we wanted to do Normal-NC actual memory then we would need to make sure that KVM does the appropriate cache maintenance at map / unmap. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel