From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B56F4C4829B for ; Sun, 11 Feb 2024 14:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qnACgcE1LTCg4fg3DmlT8kshE6N+Op/Lry/au4z79s0=; b=xe302CSxVN4V40 6tivhCKMvDrQJCARPfr+gmPsv/nNUfb9iK3x2e065jZoeqre1uFCy0e2uJvXp6pNK7TQHaRhjTEDL qYrFQIFyAS1GIDHev6gBREJ3SJjM9F9K/mfdckF8LWFnHAGv8NeEc67emJZZsfNFdDBSSqKOkODuH r2qLERbevO8qbiRrEMb/4eRD4OeKpxNTQA3PqyzHGZAvC/rVNjxa3heUoT6+hzwZb2L0bEGhpbIxb WNPSmXOvqS3F5UQW/n2JS36JoLHce0K9O7Q/mdZ7vojaJCDe/eOOFex6JMRkbkU6+XcHtAjjjaPb6 vg3LQ7nKuZuauAarNFzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZAkt-00000002pv0-0neL; Sun, 11 Feb 2024 14:24:27 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZAkr-00000002puX-1HPw for linux-arm-kernel@lists.infradead.org; Sun, 11 Feb 2024 14:24:26 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-51186925925so671136e87.0 for ; Sun, 11 Feb 2024 06:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707661461; x=1708266261; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=GCAOLl3pei0rSyoGXtik0PziUaBSCc9hClSrM+7S6s4=; b=JMhVOICfR5uW5k9439L4R5X1VOJCK7lENxI3Gn0QQ+ycfJXYCTea+dunXfMc+BVNkH poGV/9D6+w/Fk/gtUTxM0Eyv07+LaGUDxhZvZj+MLFCkiiFdwMv0zSh9TXL/lTxIH8vo NXS5gJnBC7LyGT4FJNNhJHf9dGqV0RiUeB72MEsP/EK+0ogueHmbGPTBwR99eMxYY+XU WspqPrskexWxFhP99pf8JWp6rPf2iVRDIWGvx+FHRXqME9o7Ujs/sDXa0POAZUIDS9wD fl3Z+pBWRkiuJHvztGlyEv0hNmhmZ2eG92uqTJMc74AbTFwtbfXVWFsy25R1hIADUWZQ Kihg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707661461; x=1708266261; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GCAOLl3pei0rSyoGXtik0PziUaBSCc9hClSrM+7S6s4=; b=ThKsJwGVqT7Dd5DgOwRxDQdb/mGAGPcbMaF9ia49FYTExKtp4+VKqVu3ndsbK8sSFV w3TOCBghRVrUvjTfmeZS+d6DaVhkQa1sjVsQqSGKsW+dh5jGTPrwUbSplsv3pJbYWIr6 yzU0KblCGKc5tibiKDoir47ebmi2Z0f/RyQ0tjmKWhllJ6Zu+FrIVoWK8D48EtVluWy+ RLSjRixKUKX20Q15qXRJmAk0M0jAc70XKN1mn4KyEzyGFtuSZg9CBBfoJDcrvttP4fEU dpy8919iYi7Cl5dOoHJBGyAAPncisskJXskvj5+RHIcHweihSljI3vaT2jJq6ZdCil6+ u9kw== X-Forwarded-Encrypted: i=1; AJvYcCUHD0cpOSUvsyujKwuIJLcf+F3uJdUyGp7yGxQXK8UkJjPpnttMuJvwnsl7FFEBF3PJieK2csHmPQT9jA8afHeQXHvp09LdZjPTBtW94y8w647GSSQ= X-Gm-Message-State: AOJu0Yy6xMfCvzO//0YAR3ltm0s9oZbHzXYhWfWE8GdnNTepEK21+Cqy n/I9rD3SDrmzFTz5UjmkrHuWAIhHjgYdob3H4nCCaDPIEr1NegHB X-Google-Smtp-Source: AGHT+IHZpUJzzYsh4gKWkK7ZJHSVvy0xwkNJvI45AqT/LzplWFW3ITpDHyQyraOqk+co4xr+fdoUQQ== X-Received: by 2002:a05:6512:2101:b0:511:31b4:ac16 with SMTP id q1-20020a056512210100b0051131b4ac16mr2642019lfr.47.1707661460349; Sun, 11 Feb 2024 06:24:20 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUyuas5J8CkYG9BE8O92OW7jFT2z/udTl3RiHKENMJiWoCinJ0gPn5XNXNC7qpby9Odovk2GJvJ3BLydrUUwOXp1A49uSqhIhFuebACfzNuuTnlZ4MNIggb9nFyFryjSu534so0x1Li9zdChHh0xfc1olyM9S1enIvdpH0AjPXRxJesD/7yM0aGbPdPiFjd5WdckVAb7TLdxua7URCZS2wcJYgjWGds8mFihcj+w/su8iPWctN9cnTKZ2pDzZZ6/dECXbU+A7+hR6OSugzG35J/N3Wpu9JZS/cQAo9WYBVrMVAathTcpb11015pfSs6fyoInx8JuQmuj/iycXFYGDcX8HtAFT5nrK3OlQz/kGcAWM2cBpQ6k6uCV9sGaTaaZlrFqwIeC8qhcfQ3Q1MAztw04gLEztxsI/qUc2tEgUIMYG/JyhOWdZOI/Ef9vMLjdH6W283YrI5Pg0Rubip+RPR7hGXkt9yjtTTwqRI3CLckRJlDLDa+ Received: from localhost ([2a05:3580:f312:6c01:1b8f:2a1b:d18:1951]) by smtp.gmail.com with ESMTPSA id v8-20020a056512348800b005114e5d3515sm537766lfr.96.2024.02.11.06.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 06:24:19 -0800 (PST) Date: Sun, 11 Feb 2024 17:24:19 +0300 From: Andrey Skvortsov To: Andre Przywara Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris , Alexey Klimov , Daniel Lezcano Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add thermal trip points for GPU Message-ID: Mail-Followup-To: Andrey Skvortsov , Andre Przywara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris , Alexey Klimov , Daniel Lezcano References: <20240211105326.506049-1-andrej.skvortzov@gmail.com> <20240211125209.15d58462@minigeek.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240211125209.15d58462@minigeek.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240211_062425_373019_1D07458A X-CRM114-Status: GOOD ( 30.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, On 24-02-11 12:52, Andre Przywara wrote: > On Sun, 11 Feb 2024 13:53:26 +0300 > Andrey Skvortsov wrote: > > Hi Andrey, > > > From: Alexey Klimov > > > > Without trip points for GPU, the following errors are printed in the > > dmesg log and the sun8i-thermal driver fails to load: > > So how does that post differ from Alexey one's a few weeks back: > https://lore.kernel.org/linux-arm-kernel/20240101000008.65747-1-alexey.klimov@linaro.org/ > It seems like the same patch? Yes, it's the same patch. I've added only information about failed dtbs_check errors in already supported boards to commit message. I've found this patch from June 2023 without any feedback. [1] Since I've worked on dts changes for PinePhone A64, I've decided to resend it. Sorry, I wasn't aware that Alexey resent it in the mean time. It's better to continue discussion in original Alexey's patch. > And Jernej and I had some comments (no mentioning of "Linux" in commit > message, add cooling maps, source of trip temperature values), can you > please try to address them? > > > > thermal_sys: Failed to find 'trips' node > > thermal_sys: Failed to find trip points for thermal-sensor id=1 > > sun8i-thermal: probe of 1c25000.thermal-sensor failed with error -22 > > I think it's pretty obvious that the trip points are missing when they > shouldn't, so this does not need too much explanation or rationale in > the commit message, so you can cut this short. > > > When thermal zones are defined, trip points definitions are mandatory. > > Trip values for the GPU are assumed to be the same values as the CPU > > ones. The available specs do not provide any hints about thermal regimes > > for the GPU and it seems GPU is implemented on the same die as the CPU. > > > > 'make dtbs_check' complains about problem in dts for 18 A64-based boards > > supported by the kernel: > > > > sun50i-a64-pine64.dtb: thermal-zones: gpu0-thermal: 'trips' is a required property > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > sun50i-a64-pine64.dtb: thermal-zones: gpu1-thermal: 'trips' is a required property > > from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# > > > > Tested on Pine a64+ and PinePhone 1.2. > > > > Cc: Samuel Holland > > Cc: Jernej Skrabec > > Cc: Chen-Yu Tsai > > Cc: Daniel Lezcano > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Alexey Klimov > > Tested-by: Andrey Skvortsov > > You would need your Signed-off-by: here, since you send this, even when > on Alexey's behalf. > > Cheers, > Andre > 1. https://lkml.org/lkml/2023/6/4/416 -- Best regards, Andrey Skvortsov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel