From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08EE8C4829B for ; Mon, 12 Feb 2024 12:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=93CSg29VCWB9fok/2+YZKiyiefai2fz3ZGv5nyFxhgw=; b=j44FTK5wIyvVne Gwapg5G8t7GsF7lNi3RmxKCFixX0SdszqTY9RVV1j9KoTtVF0EYfv87XkTJujjn8Gjgv8d4X1V0/C 00lisvDPWoxzqYmBWiR+AE+oXRpGofpIm57ceCXnRkr2sNlbIM2zpYeopTNkMvlmgPGDj8DjtKpOT Z0ib9nQFJjU4/X+j/WF0qbMmS79MdZQUhE+Wl44TkW6UMIG6cKIwmhGZVRfNa8ZLnGiLtVwxn14Nj 3zQ8kiRGhYXmeVvckJv3pTjS9XoXwUk+FNlkbPyPfxlvOvEUuEe2NLAapGgFxlu87P1bJfbhvcypV ZpKAnQ32ExdU1ji4PPFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVg1-00000005JLj-40ii; Mon, 12 Feb 2024 12:44:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZVfz-00000005JKm-1md4 for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 12:44:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B275EDA7; Mon, 12 Feb 2024 04:45:27 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A2CE33F7BD; Mon, 12 Feb 2024 04:44:44 -0800 (PST) Date: Mon, 12 Feb 2024 12:44:42 +0000 From: Cristian Marussi To: Sudeep Holla , Sibi Sankar Cc: viresh.kumar@linaro.org, morten.rasmussen@arm.com, rafael@kernel.org, dietmar.eggemann@arm.com, lukasz.luba@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 1/4] firmware: arm_scmi: Add perf_notify_support interface Message-ID: References: <20240117104116.2055349-1-quic_sibis@quicinc.com> <20240117104116.2055349-2-quic_sibis@quicinc.com> <20240131112854.24euh6c6xgljsj6c@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131112854.24euh6c6xgljsj6c@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_044447_554949_8A5CDD56 X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 31, 2024 at 11:28:54AM +0000, Sudeep Holla wrote: > On Mon, Jan 29, 2024 at 05:33:42PM +0000, Cristian Marussi wrote: Hi Sibi, > > On Mon, Jan 29, 2024 at 03:50:20PM +0000, Cristian Marussi wrote: > > > On Wed, Jan 17, 2024 at 04:11:13PM +0530, Sibi Sankar wrote: > > > > Add a new perf_notify_support interface to the existing perf_ops to export > > > > info regarding limit/level change notification support. > > > > > > > > > > Hi Sibi, > > > > > > as I mentioned previously, in order not to add a needless stream of SCMI > > > Perf accessors I posted this: > > > > > > https://lore.kernel.org/linux-arm-kernel/20240129151002.1215333-1-cristian.marussi@arm.com/T/#u > > > > > > to expose all the Perf domains infos via the usual info_get(), similarly > > > to how other SCMI protocols do already. > > > > > > I think that reworking this series on that, you can certainly drop this patch and just > > > check the _notify booleans on the retrieved domain info. > > > > Sorry, but hold on with this change, I will probably post an updated version > > my patch above. > > > > As discussed in private, I would prefer to avoid exposing all the internals > to the users of SCMI perf. At the same time may we can do better if we can > check the availability of notification as part of notification enablement > from the SCMI driver, I need to think the details yet. > as previously mentioned, after speaking with Sudeep, I posted a new series at [1], that aims to solve your problem with registering notifications and looking up reported Perf frequencies in a new way. Using the changes at [1] you should be able to: - register your notifier without caring to check if the notification is supported, since the SCMI core will take care of checking that and report an error if not supported, without sending any unneeded attempted notification enable message (so you can drop 1/4 in this series) - retrieve the pre-calculated OPPs frequencies from the new extended Perf notifications reports no matter if the system if operating in level_indexing_mode or not. (so you can drop 2/4 in this series) Thanks, Cristian [1]: https://lore.kernel.org/linux-arm-kernel/20240212123233.1230090-1-cristian.marussi@arm.com/T/#ma68cefd753e34ba3e1f2d4392e978026a87e1bf8 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel