From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65AEBC48260 for ; Tue, 13 Feb 2024 08:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TXf5PqKIpsHgioRXrI/giJV9Kqs5ziRN+eGh9CKlVJ4=; b=4Hp/KL4mQwpFA1 mJ/IDPmtOM5SD2ZL4CGjxV0O4r25ayhMGbT4WeKlHIFp+zvP0wMOQrzeropvHpR/c4far3Yh+2LOD +GmaYFP7LXAycaz2bgAlLnVQ1+YYjEWJEN2NMsCGOJ0D826DBfn/dLfwbyfJCaDCm7gekZePjFPsG bwkDh2vGMgLmX3j36i78PJEexQ54Ewb97uxbc6z/4BgvTzGo2ZEps4PZXBap5+8N8mbgf0aI5M3Nu QawR6mMhKr5hS51kQdIKx5Nxb6ILWkYwh2JQaHctf4FG3s3ISXaygb/kQHEvbBkbfnLqEpTFQ9JwH 5uH9eRiRWNLs6XTv0RaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZoc3-00000008WdQ-1XjT; Tue, 13 Feb 2024 08:57:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZoc1-00000008Wck-2UR3 for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 08:57:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD445DA7; Tue, 13 Feb 2024 00:58:36 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF7503F5A1; Tue, 13 Feb 2024 00:57:54 -0800 (PST) Date: Tue, 13 Feb 2024 08:57:52 +0000 From: Cristian Marussi To: "Ricardo B. Marliere" Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 2/2] firmware: arm_scmi: make scmi_bus_type const Message-ID: References: <20240211-bus_cleanup-firmware2-v1-0-1851c92c7be7@marliere.net> <20240211-bus_cleanup-firmware2-v1-2-1851c92c7be7@marliere.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240211-bus_cleanup-firmware2-v1-2-1851c92c7be7@marliere.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_005757_711291_805FB1F6 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 11, 2024 at 12:51:30PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the scmi_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Ricardo B. Marliere > --- Reviewed-by: Cristian Marussi Thanks, Cristian > drivers/firmware/arm_scmi/bus.c | 2 +- > drivers/firmware/arm_scmi/common.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c > index c15928b8c5cc..609a6496c1d4 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -263,7 +263,7 @@ static void scmi_dev_remove(struct device *dev) > scmi_drv->remove(scmi_dev); > } > > -struct bus_type scmi_bus_type = { > +const struct bus_type scmi_bus_type = { > .name = "scmi_protocol", > .match = scmi_dev_match, > .probe = scmi_dev_probe, > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index 00b165d1f502..6affbfdd1dec 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -141,7 +141,7 @@ scmi_revision_area_get(const struct scmi_protocol_handle *ph); > void scmi_setup_protocol_implemented(const struct scmi_protocol_handle *ph, > u8 *prot_imp); > > -extern struct bus_type scmi_bus_type; > +extern const struct bus_type scmi_bus_type; > > #define SCMI_BUS_NOTIFY_DEVICE_REQUEST 0 > #define SCMI_BUS_NOTIFY_DEVICE_UNREQUEST 1 > > -- > 2.43.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel